Re: [FFmpeg-devel] [PATCH v2] avformat: add Software Defined Radio support

[James Almer <jamrial@gmail.com>]

On 6/22/2023 12:05 PM, Michael Niedermayer wrote:
> On Thu, Jun 22, 2023 at 10:55:44AM -0300, James Almer wrote:
>> On 6/22/2023 10:43 AM, Michael Niedermayer wrote:
>>> On Mon, Jun 19, 2023 at 12:28:05AM +0200, Michael Niedermayer wrote:
>>>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
>>>> ---
>>>>    configure                |    4 +
>>>>    doc/demuxers.texi        |   71 ++
>>>>    libavformat/Makefile     |    2 +
>>>>    libavformat/allformats.c |    2 +
>>>>    libavformat/sdrdemux.c   | 1739 ++++++++++++++++++++++++++++++++++++++
>>>>    5 files changed, 1818 insertions(+)
>>>>    create mode 100644 libavformat/sdrdemux.c
>>>
>>> Ill post a v3 later today or tomorrow that makes this work with the RTL-SDR Blog V3
>>
>> Shouldn't the SDR "demuxer" be in libavdevice? Being AVFMT_NOFILE and pretty
>> much a capture device, it seems to me that's the proper place.
>> I guess the problem arises with the sdrfile demuxer, which shares code with
>> the other one.
> 
> I have no oppinon on this. I can move it to libavdevice if people prefer.
> do people prefer libavdevice for this ?

I do. It's a capture device and depends on an external library to 
interface with hardware. And like i said, you can keep the file demuxer 
in lavf, where it does fit.

> 
> 
> personally i think libavdevice should be merged with libavformat.

It's been suggested plenty of times. Anton attempted to at least 
kickstart it once, but his plan was shot down.
No one has tried anything ever since.

> Their APIs and ABIs are the same, they are not truly seperate libs
> One could say libavdevice is a plugin for libavformat. And with that view
> having each device from libavdevice a plugin would be "better" than all
> together as a plugin
> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".