From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2F07940D62 for ; Mon, 7 Feb 2022 04:05:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7D90168B234; Mon, 7 Feb 2022 06:05:14 +0200 (EET) Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 35F5E68B163 for ; Mon, 7 Feb 2022 06:05:07 +0200 (EET) Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4JsXbl13k1z9scx for ; Mon, 7 Feb 2022 05:05:07 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Message-ID: <8d58f24d-2a44-776c-7a29-afd11b7159f5@gyani.pro> Date: Mon, 7 Feb 2022 09:34:50 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220205132242.52049-1-ffmpeg@gyani.pro> <5089defa-c3c1-f52b-4ec9-e18efec4459@passwd.hu> From: Gyan Doshi In-Reply-To: <5089defa-c3c1-f52b-4ec9-e18efec4459@passwd.hu> Subject: Re: [FFmpeg-devel] [PATCH] avformat/mpegts: initialize max_packet_size when sub-demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-02-07 03:59 am, Marton Balint wrote: > > > On Sat, 5 Feb 2022, Gyan Doshi wrote: > >> bca30570d2 added a user option to set max_packet_size replacing >> a hardcoded value. This had a side-effect of leaving the field >> set to 0 when packet demuxing is carried out from another demuxer >> using avpriv functions, which could lead to demux failure. >> >> Hardcoded max_packet_size inside avpriv_mpegts_parse_open to >> 2048000 to avoid this. Value chosen to be 10x that of default value >> to accommodate large payloads. > > I don't understand why the default is different from the normal mpegts > case. Large payloads can happen there as well, and previously it was > assumed that splitting is OK, because it will be parsed anyway. The option was added because MPEG-TS allows any codec to be carried as a private stream and when demuxing that, the parser isn't inserted, even when forcing a decoder, hence the need to not have split packets. In this case, the user can't tune the value, so I went with an expansive one. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".