From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mpegts: initialize max_packet_size when sub-demuxer
Date: Mon, 7 Feb 2022 09:34:50 +0530
Message-ID: <8d58f24d-2a44-776c-7a29-afd11b7159f5@gyani.pro> (raw)
In-Reply-To: <5089defa-c3c1-f52b-4ec9-e18efec4459@passwd.hu>
On 2022-02-07 03:59 am, Marton Balint wrote:
>
>
> On Sat, 5 Feb 2022, Gyan Doshi wrote:
>
>> bca30570d2 added a user option to set max_packet_size replacing
>> a hardcoded value. This had a side-effect of leaving the field
>> set to 0 when packet demuxing is carried out from another demuxer
>> using avpriv functions, which could lead to demux failure.
>>
>> Hardcoded max_packet_size inside avpriv_mpegts_parse_open to
>> 2048000 to avoid this. Value chosen to be 10x that of default value
>> to accommodate large payloads.
>
> I don't understand why the default is different from the normal mpegts
> case. Large payloads can happen there as well, and previously it was
> assumed that splitting is OK, because it will be parsed anyway.
The option was added because MPEG-TS allows any codec to be carried as a
private stream and when demuxing that, the parser isn't inserted, even
when forcing a decoder, hence the need to not have split packets. In
this case, the user can't tune the value, so I went with an expansive one.
Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-02-07 4:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 13:22 Gyan Doshi
2022-02-06 22:29 ` Marton Balint
2022-02-07 4:04 ` Gyan Doshi [this message]
2022-02-08 11:03 ` Gyan Doshi
2022-02-10 11:37 ` Gyan Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d58f24d-2a44-776c-7a29-afd11b7159f5@gyani.pro \
--to=ffmpeg@gyani.pro \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git