From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 0EB9448878
	for <ffmpegdev@gitmailbox.com>; Wed, 20 Dec 2023 08:07:05 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7B03968D15F;
	Wed, 20 Dec 2023 10:07:02 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 84AEC68CC54
 for <ffmpeg-devel@ffmpeg.org>; Wed, 20 Dec 2023 10:06:56 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 3BK86tQv032330-3BK86tQw032330
 for <ffmpeg-devel@ffmpeg.org>; Wed, 20 Dec 2023 10:06:55 +0200
Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144])
 by mail9.parnet.fi (Postfix) with ESMTPS id 580BBA146B
 for <ffmpeg-devel@ffmpeg.org>; Wed, 20 Dec 2023 10:06:55 +0200 (EET)
Date: Wed, 20 Dec 2023 10:06:53 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
In-Reply-To: <20231217220434.2867783-1-martin@martin.st>
Message-ID: <8cb3aae7-bf28-bb6f-4e56-597ff9cda780@martin.st>
References: <20231217220434.2867783-1-martin@martin.st>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH] checkasm: Remove unnecessary const on
 scalar parameters
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-15"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/8cb3aae7-bf28-bb6f-4e56-597ff9cda780@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Mon, 18 Dec 2023, Martin Storsj=F6 wrote:

> The ffmpeg coding style doesn't usually use const on scalar
> parameters (or on the pointer values - as opposed to the type
> that is pointed to, where it has a semantic meaning), contrary
> to the dav1d coding style (where this was imported from).
>
> This avoids warnings about differences in the type signatures
> between declaration and definition of this function, with older
> versions of MSVC.
>
> The issue was observed with one version of MSVC 2017,
> 19.16.27024.1, with warnings like these:
>
>    src/tests/checkasm/checkasm.c(969): warning C4028: formal parameter 3 =
different from declaration

FWIW, newer versions of MSVC don't warn about this - the warning is bogus =

indeed. But these const markings are unnecessary here anyway, and aren't =

endorsed in the ffmpeg coding style.

Anyway, this patch got generally favourable response on irc yesterday, so =

I'll push it today.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".