From: "Martin Storsjö" <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] checkasm: Remove unnecessary const on scalar parameters
Date: Wed, 20 Dec 2023 10:06:53 +0200 (EET)
Message-ID: <8cb3aae7-bf28-bb6f-4e56-597ff9cda780@martin.st> (raw)
In-Reply-To: <20231217220434.2867783-1-martin@martin.st>
On Mon, 18 Dec 2023, Martin Storsjö wrote:
> The ffmpeg coding style doesn't usually use const on scalar
> parameters (or on the pointer values - as opposed to the type
> that is pointed to, where it has a semantic meaning), contrary
> to the dav1d coding style (where this was imported from).
>
> This avoids warnings about differences in the type signatures
> between declaration and definition of this function, with older
> versions of MSVC.
>
> The issue was observed with one version of MSVC 2017,
> 19.16.27024.1, with warnings like these:
>
> src/tests/checkasm/checkasm.c(969): warning C4028: formal parameter 3 different from declaration
FWIW, newer versions of MSVC don't warn about this - the warning is bogus
indeed. But these const markings are unnecessary here anyway, and aren't
endorsed in the ffmpeg coding style.
Anyway, this patch got generally favourable response on irc yesterday, so
I'll push it today.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-12-20 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 22:04 Martin Storsjö
2023-12-20 8:06 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cb3aae7-bf28-bb6f-4e56-597ff9cda780@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git