[FFmpeg-devel] [PATCH] configure: warn when threading is disabled

[FFmpeg-devel] [PATCH] configure: warn when threading is disabled

[Anton Khirnov]

Explicitly state what the implications of this are.
---
 configure | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/configure b/configure
index 8a1a1b8584..5ba2698798 100755
--- a/configure
+++ b/configure
@@ -7493,6 +7493,12 @@ check_deps $CONFIG_LIST       \
 
 enabled threads && ! enabled pthreads && ! enabled atomics_native && die "non pthread threading without atomics not supported, try adding --enable-pthreads or --cpu=i486 or higher if you are on x86"
 
+enabled threads || warn \
+    "Threading support was disabled or is not available on this platform."   \
+    "This means that not only is this build not multi-threaded, but also"    \
+    "that the libraries from this build MUST NOT be used in a multi-threaded"\
+    "environment."
+
 case $target_os in
 haiku)
     disable memalign
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: warn when threading is disabled

[James Almer]

On 10/3/2023 10:37 AM, Anton Khirnov wrote:
> Explicitly state what the implications of this are.
> ---
>   configure | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/configure b/configure
> index 8a1a1b8584..5ba2698798 100755
> --- a/configure
> +++ b/configure
> @@ -7493,6 +7493,12 @@ check_deps $CONFIG_LIST       \
>   
>   enabled threads && ! enabled pthreads && ! enabled atomics_native && die "non pthread threading without atomics not supported, try adding --enable-pthreads or --cpu=i486 or higher if you are on x86"
>   
> +enabled threads || warn \
> +    "Threading support was disabled or is not available on this platform."   \

nit: The target platform

> +    "This means that not only is this build not multi-threaded, but also"    \
> +    "that the libraries from this build MUST NOT be used in a multi-threaded"\
> +    "environment."
> +
>   case $target_os in
>   haiku)
>       disable memalign
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: warn when threading is disabled

[Anton Khirnov]

Quoting James Almer (2023-10-03 15:40:12)
> On 10/3/2023 10:37 AM, Anton Khirnov wrote:
> > Explicitly state what the implications of this are.
> > ---
> >   configure | 6 ++++++
> >   1 file changed, 6 insertions(+)
> > 
> > diff --git a/configure b/configure
> > index 8a1a1b8584..5ba2698798 100755
> > --- a/configure
> > +++ b/configure
> > @@ -7493,6 +7493,12 @@ check_deps $CONFIG_LIST       \
> >   
> >   enabled threads && ! enabled pthreads && ! enabled atomics_native && die "non pthread threading without atomics not supported, try adding --enable-pthreads or --cpu=i486 or higher if you are on x86"
> >   
> > +enabled threads || warn \
> > +    "Threading support was disabled or is not available on this platform."   \
> 
> nit: The target platform

very right, fixed locally

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".