From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 356EC43606 for ; Sat, 18 Jun 2022 22:21:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 967A768B595; Sun, 19 Jun 2022 01:21:46 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 658B268ACE6 for ; Sun, 19 Jun 2022 01:21:40 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 25IMLdgi027119-25IMLdgj027119 for ; Sun, 19 Jun 2022 01:21:39 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id A84B8A142E for ; Sun, 19 Jun 2022 01:21:39 +0300 (EEST) Date: Sun, 19 Jun 2022 01:21:39 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220617093141.9826-1-nil-admirari@mailo.com> Message-ID: <8bf7f1e7-933a-1ea9-bdee-f777624f22@martin.st> References: <20220617093141.9826-1-nil-admirari@mailo.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 17 Jun 2022, Nil Admirari wrote: > wchartoutf8() converts strings returned by WinAPI into UTF-8, > which is FFmpeg's preffered encoding. > > Some external dependencies, such as AviSynth, are still > not Unicode-enabled. utf8toansi() converts UTF-8 strings > into ANSI in two steps: UTF-8 -> wchar_t -> ANSI. > wchartoansi() is responsible for the second step of the conversion. > Conversion in just one step is not supported by WinAPI. > > Since these character converting functions allocate the buffer > of necessary size, they also facilitate the removal of MAX_PATH limit > in places where fixed-size ANSI/WCHAR strings were used > as filename buffers. > > getenv_utf8() wraps _wgetenv() converting its input from > and its output to UTF-8. Compared to plain getenv(), > getenv_utf8() requires a cleanup. > > Because of that, in places that only test the existence of > an environment variable or compare its value with a string > consisting entirely of ASCII characters, the use of plain getenv() > is still preferred. (libavutil/log.c check_color_terminal() > is an example of such a place.) > > Plain getenv() is also preffered in UNIX-only code, > such as bktr.c, fbdev_common.c, oss.c in libavdevice > or af_ladspa.c in libavfilter. > --- > configure | 1 + > libavutil/getenv_utf8.h | 71 ++++++++++++++++++++++++++++++++++++++ > libavutil/wchar_filename.h | 51 +++++++++++++++++++++++++++ > 3 files changed, 123 insertions(+) > create mode 100644 libavutil/getenv_utf8.h This looks generally good - as others seem to be ok with this and there doesn't seem to be any more objections, I can push this in a while. (I'm not familiar with the avisynth bits though, but it seems like there's agreement about it.) > diff --git a/libavutil/getenv_utf8.h b/libavutil/getenv_utf8.h > new file mode 100644 > index 0000000000..161e3e6202 > --- /dev/null > +++ b/libavutil/getenv_utf8.h > @@ -0,0 +1,71 @@ > +#ifndef AVUTIL_GETENV_UTF8_H > +#define AVUTIL_GETENV_UTF8_H > + > +#include > + > +#include "mem.h" > + > +#ifdef HAVE_GETENV Note that this should be #if HAVE_GETENV - these constants are always defined and evaluate to 0 or 1. No need to resend the patchset just for that. (I added an explicit #include "config.h" above here too, just to make it clearer.) // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".