From: Carl Hetherington via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Carl Hetherington <cth@carlh.net>
Subject: [FFmpeg-devel] [PATCH] libavfilter: Fix incorrect ebur128 peak calculation.
Date: Mon, 3 Nov 2025 20:38:57 +0000 (GMT)
Message-ID: <8bc32ae6-77aa-e5fe-bd1-cb55abdf9cc@carlh.net> (raw)
Since 3b26b782eeded9b9ab7fac013cd1a83a30d68206 it would only look at the
first channel.
Signed-off-by: cth@carlh.net
---
libavfilter/f_ebur128.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/f_ebur128.c b/libavfilter/f_ebur128.c
index a352f3831f..84d8e44035 100644
--- a/libavfilter/f_ebur128.c
+++ b/libavfilter/f_ebur128.c
@@ -657,7 +657,7 @@ double ff_ebur128_find_peak_c(double *restrict ch_peaks, const int nb_channels,
for (int ch = 0; ch < nb_channels; ch++) {
double ch_peak = ch_peaks[ch];
for (int i = 0; i < nb_samples; i++) {
- const double sample = fabs(samples[i * nb_channels]);
+ const double sample = fabs(samples[i * nb_channels + ch]);
ch_peak = FFMAX(ch_peak, sample);
}
maxpeak = FFMAX(maxpeak, ch_peak);
--
2.51.0
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
reply other threads:[~2025-11-03 20:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bc32ae6-77aa-e5fe-bd1-cb55abdf9cc@carlh.net \
--to=ffmpeg-devel@ffmpeg.org \
--cc=cth@carlh.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git