From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31517430E0 for ; Fri, 20 May 2022 16:47:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9298F68B475; Fri, 20 May 2022 19:47:41 +0300 (EEST) Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EC32368B2C4 for ; Fri, 20 May 2022 19:47:34 +0300 (EEST) Received: by mail-wr1-f45.google.com with SMTP id h14so12268742wrc.6 for ; Fri, 20 May 2022 09:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:references:from :in-reply-to:content-transfer-encoding; bh=e+NLNimumlwpvKXGAE3hAif7R5pT9ehgwCNKol2MCFk=; b=pGB9kMQ4ufbheFjL8zpA2dIgPB2l2ZOKijDgR60uDxeX/6Vsl7a5+fG85ABrCjtYJC kvE0SJsx0/YZf4F/1oA8VIqnFv/aOi55uZzLRcart6o3iw7/CX4V0xRuw/5viG+YMKD6 pWxT5zTVriEYLpFzZnoKXVXHKiSF2VQv4GxCbmfSrRVUTmIhEE/ylRPVOfGAkVTPe3AN MjXm74ctkuelRgYTF1qU+V2rVkzuhTKJjxwKXrCTCIDZ6r956nYNnVVesIzFlpszpP2W 4w8gQHJznb3TNmjYZofxdi6+N8+2vvIsGALKygqvWi1pUrcFKUD06PANFHoyrj/0+7ik zd0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:references:from:in-reply-to:content-transfer-encoding; bh=e+NLNimumlwpvKXGAE3hAif7R5pT9ehgwCNKol2MCFk=; b=XPxztJ6Tg22vrD8UVAED4Eg42Doh2HlTGLbp323NcZ5JyoW/kDjkUgGguAQi/0/+KZ +k1E6QzuGL+m9/fdO+kqVDR5fRHoXZydJiNtKDFYJz+CYTDq6/UhMEvOYFZ39Hxgyh8X FxijGozg7qPlB3KbJt+xPnvOjI4alQSYnZTWPf8u7dhpDKwsJ+sxmVFzxnV6HvAAuTPP Ztr56DdBixUoVBJjKqrKPGU0Q7yR6umcHw++7Rakvt2BTohKrZCOsEwIoRCsuE47yYKL zi7Cv1eDgvvVmpcLAV8auAqPLVlWwInRF4vOM45OibUnCQBj2P3gQRZ4hpVwFXLFs9ei gkWg== X-Gm-Message-State: AOAM533/eV1q+BaKl4HvQWDkdPzW6f3V9Yhw4dXSBv9kBluzedEM434h BH9Da/DHuDIAH3ZFqxUG8W3cf9exyvM= X-Google-Smtp-Source: ABdhPJyQlAbTsUBG8HGbql62TinKT5AZ4d3iB1HjWkavGr4wIdZLAQwhrM+XDTq4Hi47mnBorHuEHw== X-Received: by 2002:a5d:6d48:0:b0:20e:5f80:bd29 with SMTP id k8-20020a5d6d48000000b0020e5f80bd29mr9056803wri.428.1653065254087; Fri, 20 May 2022 09:47:34 -0700 (PDT) Received: from [192.168.1.106] ([149.12.10.163]) by smtp.googlemail.com with ESMTPSA id o4-20020a05600c338400b00394708a3d7dsm2392449wmp.15.2022.05.20.09.47.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 May 2022 09:47:33 -0700 (PDT) Message-ID: <8bbee5d6-9705-58bb-ba06-59340094d5b1@gmail.com> Date: Fri, 20 May 2022 17:47:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 To: ffmpeg-devel@ffmpeg.org References: <6aa08dec-4d80-298b-7d98-11a88e74bcff@gmail.com> From: Derek Buitenhuis In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/libx264: allow to disable definition of X264_API_IMPORTS macro X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/20/2022 5:37 PM, Soft Works wrote: > But if Matt's patch would be agreeable, then that would surely be > the best outcome. > > I can rebase and resubmit his patch if you would find it agreeable. Ah - that was not clear to me. If Ubuntu LTS does indeed ship such an old x264, the fallback discussed there may be indeed needed, but it's pretty simple to add. It does seem a tad silly given that the define only affects Windows, but I get where Michael is coming from. I think Matt's patch + fallback for older versions seems reasonable, if, in fact needed. Ideally we'd just drop support for older x264, though. Not sure which most people would prefer. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".