Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avdevice: Fix disabling audiotoolbox_outdev build on iOS
@ 2023-07-29 18:40 L. E. Segovia
  2023-07-29 19:00 ` [FFmpeg-devel] [PATCH v2] " L. E. Segovia
  0 siblings, 1 reply; 4+ messages in thread
From: L. E. Segovia @ 2023-07-29 18:40 UTC (permalink / raw)
  To: ffmpeg-devel

audiotoolbox.m uses CoreAudio APIs that are only available in macOS.
The existing CoreAudio framework check is already enough for this case
(as CoreAudio.h does not exist for the iDevices), however, it was never
passed as a dependency of audiotoolbox_outdev. This caused the
build system to include that output device into the targets.

Signed-off-by: L. E. Segovia <amy@amyspark.me>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 99388e7664..ccb9d7be7a 100755
--- a/configure
+++ b/configure
@@ -3577,7 +3577,7 @@ alsa_outdev_deps="alsa"
 avfoundation_indev_deps="avfoundation corevideo coremedia pthreads"
 avfoundation_indev_suggest="coregraphics applicationservices"
 avfoundation_indev_extralibs="-framework Foundation"
-audiotoolbox_outdev_deps="audiotoolbox pthreads"
+audiotoolbox_outdev_deps="audiotoolbox coreaudio pthreads"
 audiotoolbox_outdev_extralibs="-framework AudioToolbox -framework
CoreAudio"
 bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h
dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
 caca_outdev_deps="libcaca"
-- 
2.41.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [FFmpeg-devel] [PATCH v2] avdevice: Fix disabling audiotoolbox_outdev build on iOS
  2023-07-29 18:40 [FFmpeg-devel] [PATCH] avdevice: Fix disabling audiotoolbox_outdev build on iOS L. E. Segovia
@ 2023-07-29 19:00 ` L. E. Segovia
  2023-08-08 14:09   ` L. E. Segovia
  2023-08-16 21:05   ` L. E. Segovia via ffmpeg-devel
  0 siblings, 2 replies; 4+ messages in thread
From: L. E. Segovia @ 2023-07-29 19:00 UTC (permalink / raw)
  To: ffmpeg-devel

audiotoolbox.m uses CoreAudio APIs that are only available in macOS.
The existing CoreAudio framework check is already enough for this case
(as CoreAudio.h does not exist for the iDevices), however, it was never
passed as a dependency of audiotoolbox_outdev. This caused the
build system to include that output device into the targets.

Signed-off-by: L. E. Segovia <amy@amyspark.me>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 99388e7664..ccb9d7be7a 100755
--- a/configure
+++ b/configure
@@ -3577,7 +3577,7 @@ alsa_outdev_deps="alsa"
 avfoundation_indev_deps="avfoundation corevideo coremedia pthreads"
 avfoundation_indev_suggest="coregraphics applicationservices"
 avfoundation_indev_extralibs="-framework Foundation"
-audiotoolbox_outdev_deps="audiotoolbox pthreads"
+audiotoolbox_outdev_deps="audiotoolbox coreaudio pthreads"
 audiotoolbox_outdev_extralibs="-framework AudioToolbox -framework CoreAudio"
 bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
 caca_outdev_deps="libcaca"
-- 
2.41.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [PATCH v2] avdevice: Fix disabling audiotoolbox_outdev build on iOS
  2023-07-29 19:00 ` [FFmpeg-devel] [PATCH v2] " L. E. Segovia
@ 2023-08-08 14:09   ` L. E. Segovia
  2023-08-16 21:05   ` L. E. Segovia via ffmpeg-devel
  1 sibling, 0 replies; 4+ messages in thread
From: L. E. Segovia @ 2023-08-08 14:09 UTC (permalink / raw)
  To: ffmpeg-devel

Ping for review.

amyspark

On 29/07/2023 16:00, L. E. Segovia wrote:
> audiotoolbox.m uses CoreAudio APIs that are only available in macOS.
> The existing CoreAudio framework check is already enough for this case
> (as CoreAudio.h does not exist for the iDevices), however, it was never
> passed as a dependency of audiotoolbox_outdev. This caused the
> build system to include that output device into the targets.
> 
> Signed-off-by: L. E. Segovia <amy@amyspark.me>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 99388e7664..ccb9d7be7a 100755
> --- a/configure
> +++ b/configure
> @@ -3577,7 +3577,7 @@ alsa_outdev_deps="alsa"
>  avfoundation_indev_deps="avfoundation corevideo coremedia pthreads"
>  avfoundation_indev_suggest="coregraphics applicationservices"
>  avfoundation_indev_extralibs="-framework Foundation"
> -audiotoolbox_outdev_deps="audiotoolbox pthreads"
> +audiotoolbox_outdev_deps="audiotoolbox coreaudio pthreads"
>  audiotoolbox_outdev_extralibs="-framework AudioToolbox -framework CoreAudio"
>  bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
>  caca_outdev_deps="libcaca"

-- 
amyspark 🌸 https://www.amyspark.me
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [FFmpeg-devel] [PATCH v2] avdevice: Fix disabling audiotoolbox_outdev build on iOS
  2023-07-29 19:00 ` [FFmpeg-devel] [PATCH v2] " L. E. Segovia
  2023-08-08 14:09   ` L. E. Segovia
@ 2023-08-16 21:05   ` L. E. Segovia via ffmpeg-devel
  1 sibling, 0 replies; 4+ messages in thread
From: L. E. Segovia via ffmpeg-devel @ 2023-08-16 21:05 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: L. E. Segovia

Ping again for review.

amyspark

On 29/07/2023 16:00, L. E. Segovia wrote:
> audiotoolbox.m uses CoreAudio APIs that are only available in macOS.
> The existing CoreAudio framework check is already enough for this case
> (as CoreAudio.h does not exist for the iDevices), however, it was never
> passed as a dependency of audiotoolbox_outdev. This caused the
> build system to include that output device into the targets.
> 
> Signed-off-by: L. E. Segovia <amy@amyspark.me>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 99388e7664..ccb9d7be7a 100755
> --- a/configure
> +++ b/configure
> @@ -3577,7 +3577,7 @@ alsa_outdev_deps="alsa"
>  avfoundation_indev_deps="avfoundation corevideo coremedia pthreads"
>  avfoundation_indev_suggest="coregraphics applicationservices"
>  avfoundation_indev_extralibs="-framework Foundation"
> -audiotoolbox_outdev_deps="audiotoolbox pthreads"
> +audiotoolbox_outdev_deps="audiotoolbox coreaudio pthreads"
>  audiotoolbox_outdev_extralibs="-framework AudioToolbox -framework CoreAudio"
>  bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
>  caca_outdev_deps="libcaca"

-- 
amyspark 🌸 https://www.amyspark.me
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-08-16 21:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-29 18:40 [FFmpeg-devel] [PATCH] avdevice: Fix disabling audiotoolbox_outdev build on iOS L. E. Segovia
2023-07-29 19:00 ` [FFmpeg-devel] [PATCH v2] " L. E. Segovia
2023-08-08 14:09   ` L. E. Segovia
2023-08-16 21:05   ` L. E. Segovia via ffmpeg-devel

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git