Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "L. E. Segovia" <amy@amyspark.me>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avdevice: Fix disabling audiotoolbox_outdev build on iOS
Date: Tue, 8 Aug 2023 11:09:44 -0300
Message-ID: <8baadf53-16e4-4d10-b3a6-63877bd3396b@amyspark.me> (raw)
In-Reply-To: <a68ca9a4-356b-4af1-99ec-541dce6f9c5b@amyspark.me>

Ping for review.

amyspark

On 29/07/2023 16:00, L. E. Segovia wrote:
> audiotoolbox.m uses CoreAudio APIs that are only available in macOS.
> The existing CoreAudio framework check is already enough for this case
> (as CoreAudio.h does not exist for the iDevices), however, it was never
> passed as a dependency of audiotoolbox_outdev. This caused the
> build system to include that output device into the targets.
> 
> Signed-off-by: L. E. Segovia <amy@amyspark.me>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 99388e7664..ccb9d7be7a 100755
> --- a/configure
> +++ b/configure
> @@ -3577,7 +3577,7 @@ alsa_outdev_deps="alsa"
>  avfoundation_indev_deps="avfoundation corevideo coremedia pthreads"
>  avfoundation_indev_suggest="coregraphics applicationservices"
>  avfoundation_indev_extralibs="-framework Foundation"
> -audiotoolbox_outdev_deps="audiotoolbox pthreads"
> +audiotoolbox_outdev_deps="audiotoolbox coreaudio pthreads"
>  audiotoolbox_outdev_extralibs="-framework AudioToolbox -framework CoreAudio"
>  bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
>  caca_outdev_deps="libcaca"

-- 
amyspark 🌸 https://www.amyspark.me
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-08-08 14:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29 18:40 [FFmpeg-devel] [PATCH] " L. E. Segovia
2023-07-29 19:00 ` [FFmpeg-devel] [PATCH v2] " L. E. Segovia
2023-08-08 14:09   ` L. E. Segovia [this message]
2023-08-16 21:05   ` L. E. Segovia via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8baadf53-16e4-4d10-b3a6-63877bd3396b@amyspark.me \
    --to=amy@amyspark.me \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git