From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 901FA44A3F for ; Tue, 6 Dec 2022 18:21:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 84DEC68BD7B; Tue, 6 Dec 2022 20:21:45 +0200 (EET) Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 21EF468BD39 for ; Tue, 6 Dec 2022 20:21:39 +0200 (EET) Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1433ef3b61fso18380898fac.10 for ; Tue, 06 Dec 2022 10:21:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9fnJTrbyAKlNNa7vfQZVk91tRv20ptN6WYUphNt5p8o=; b=kMtt/jW5TriDWTjeUPaf7ZHSo7UMVhyWN4yFQ8pLiciFYWQgWvoy5NaUIiO3R/QVAJ HGiDtWluLHg+PsOqWtdfBfiML7Elsu+f8AJr7bth5mhc7ymDPYagX3VwTzd8ZWp8bb1q MMdx4qSdltbwaiugGKwCwnfh+Z9ItC2GwIpf1DA2XeQtYqUpAb9PeeomOKj1H27E5Mei OqNMXzVOvxM/4JT3HYZSROf29nDp/JgTyeYz+zKzLx1oujbXVeURSPYsBfzsEVhdicft Dib9R08jkuafx3IP82tronn/Ee2Adk61dxxLSaOR+XcIgFWYkpWdqXZunMVjklIBwANq CUqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9fnJTrbyAKlNNa7vfQZVk91tRv20ptN6WYUphNt5p8o=; b=ExjW2aUQH+AsuH8XhBws7Nz7AoYGxr5z+z57N6U4bGyD6sZ7E/k7SD8mlZnSXtcWTf 3wohPCFN8tFspMWgDPicTYiGp3unO+XSNNwc8KPkOONjsIwG02yVff63pEhZf8FKN0Kk CX0S2ElanmuBQX+o/511vrP0hBtFZRvzMukCfGBPhFtUGQL6mBCXwZFqmp0MjvwB+168 PNELeEUyuaegYGu7H16lDc0H+cU88ncyrJ7Jx2V39jY1OU+O3OYU+IJjn7E4H8q94bNh cVBEA7ocZ7TUYttnPZ+AWzPZVx1Qxc0V+7256yBQMEpjBTvdyIxXC+5tAixxtAUrM1EO hrsQ== X-Gm-Message-State: ANoB5pm+jJwmXDol+45fsLSMPaZGU6RR6ImmdrRh50Um1ZxG7uUg2FSk WopnBvl07BhkIeINHIZRdTlkDF9jBOA= X-Google-Smtp-Source: AA0mqf6eMi59Jgh7vW7YbEEnyQv4d/dRSr7aGK5KPqnHJt63XhKxnikh/nTRS0dOCqTaY9Wmvn12Rw== X-Received: by 2002:a05:6870:7014:b0:144:5f0d:9ff6 with SMTP id u20-20020a056870701400b001445f0d9ff6mr8794399oae.228.1670350896933; Tue, 06 Dec 2022 10:21:36 -0800 (PST) Received: from [192.168.0.11] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id i15-20020a056808054f00b0035468f2d410sm4152357oig.55.2022.12.06.10.21.35 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 10:21:36 -0800 (PST) Message-ID: <8b87a0c1-2691-98aa-1bc2-fee897bd81ba@gmail.com> Date: Tue, 6 Dec 2022 15:21:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20221205221641.1215-1-mindmark@gmail.com> From: James Almer In-Reply-To: <20221205221641.1215-1-mindmark@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avutil: move bswapdsp from avcodec to avutil X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/5/2022 7:16 PM, mindmark@gmail.com wrote: > diff --git a/libavcodec/bswapdsp.h b/libavutil/bswapdsp.h > similarity index 71% > rename from libavcodec/bswapdsp.h > rename to libavutil/bswapdsp.h > index 6f4db66115..b540560d6a 100644 > --- a/libavcodec/bswapdsp.h > +++ b/libavutil/bswapdsp.h > @@ -16,18 +16,16 @@ > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > */ > > -#ifndef AVCODEC_BSWAPDSP_H > -#define AVCODEC_BSWAPDSP_H > +#ifndef AVUTIL_BSWAPDSP_H > +#define AVUTIL_BSWAPDSP_H > > #include > > -typedef struct BswapDSPContext { > - void (*bswap_buf)(uint32_t *dst, const uint32_t *src, int w); > +typedef struct AVBSwapDSPContext { > + void (*bswap32_buf)(uint32_t *dst, const uint32_t *src, int len); > void (*bswap16_buf)(uint16_t *dst, const uint16_t *src, int len); > -} BswapDSPContext; > +} AVBSwapDSPContext; > > -void ff_bswapdsp_init(BswapDSPContext *c); > -void ff_bswapdsp_init_riscv(BswapDSPContext *c); > -void ff_bswapdsp_init_x86(BswapDSPContext *c); > +void av_bswapdsp_init(AVBSwapDSPContext *c); > > -#endif /* AVCODEC_BSWAPDSP_H */ > +#endif /* AVUTIL_BSWAPDSP_H */ For what's supposed to become an installer header, this is barebones in the documentation department. Also, does this have any real use for API users? If you want to access these functions from swscale as well as lavc, you could either duplicate the code, or use the avpriv prefix. I'm not a fan of adding public API for something that has no use outside of our own libraries. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".