From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 66C0148810 for ; Tue, 28 Jan 2025 08:46:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8D25F68BC9A; Tue, 28 Jan 2025 10:46:49 +0200 (EET) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E556968AECF for ; Tue, 28 Jan 2025 10:46:42 +0200 (EET) Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-3061f1e534bso54459731fa.1 for ; Tue, 28 Jan 2025 00:46:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1738054002; x=1738658802; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=hI0MyutTwCgBiSFSr4MDb3GB9HTOxtfPL2EZ3OjXxQ0=; b=lQI5m5ADVQ9kaQy4dtfliM/M3pxMU2iAPjivQkm++p97Fh+zYd/hV/9d9mPil3tEn6 0G3++hiztWkXMp9XZt/23C64uQd+ZVJ3TrAmma1YrZ8XLZMCnn4d3/OwSbGySmBwNrg+ Fhrd1qz47cT150kKCH5MlqZI/T422B+2LPnYXQIrgjgV2H7H00QixpgDoF6dSAwmwbFh PfGLznlHOxwhLrVa4Xi1fuYKaobqSKophkCiFI+JTrVJNMl62yHQ3UZrRlo1FUK6fJFC kWcLAy3p7lSLRzauknE9DeY3SNvd6Dz9q3ibw2wjRf/P5Ms7zel2rSPxdVPgrj6x63Gi +vxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738054002; x=1738658802; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hI0MyutTwCgBiSFSr4MDb3GB9HTOxtfPL2EZ3OjXxQ0=; b=EtoOxXhjPur9p4Hyr6cXWi/Fj1zuDIOPl+hgTgx5wgnYZVygBmj8u+3H44CfRpv0en VaEsJnjiP8+GM0t8kY1FhYrH5UFD0D7FXcOf4cIobD/ZKm0N4Nf2/gNZ9CcJFtVwYBrf j63kxyQbrcP+az4lKSMX9/4lIfORYX5kZ2sMoNAFJFFdWYlGQwk+aRoAntdIhUqluWfU KSUpCiy5zg2A+W4phA/Bgql1HNyydo2qdTpubQ8tR4f3QbH2wgoAtBq1ns/zH9pMOfFX W+qF3V2xBUDb51fNkE7sIXajcO2mfeNwj4PmP7Fszde6rF98Ly1qVtux8PCiwwxpr59D hX8A== X-Gm-Message-State: AOJu0Yz/Br0C+AuoT3dn2Q+kNOKE1VTJ05bEaInXalBYixT7pZiwoQ8o gttn3uI0aWBqFYuINqjoO6+zpM1nCsYVdj4R7TdsKyGD8UvtqGzW9zrNVAWTG1fJjNNtToiuLF7 83w== X-Gm-Gg: ASbGncsE2yJrNGweU0vQfi4bZVwGKUPd5LdrHmKDAaBn5DPa4uWZ1m0r72FH2V+rhhI j5//g1rX62xk1qomc+cyOpeVxhLYkoI2afXkg4L9x966rCj9ipAhJUr1bmgXboW8bUNSf2cTefj v30DGByJcCMDM7MLNT/VMXTOmOgQsUv7iaJzkhukrBg8h6tD8rL2bdSQhyB3mfsTN87wyTc07/1 Khof7FMhlJrnPsgSMCooZjjKJJraVy/L+Qtptf1sS0Keh3KjTSE+/aXAAHh77G4hEiK0rRqagvM my+TXN7jcfB++DPo/vg5ZWRZfcGC54zUnf/1LR5vCqIz2zmmSYmIIYQqmJsFQr391/V21H/r9C+ 5Cxk/OAg0rBc= X-Google-Smtp-Source: AGHT+IENnqMp2fErJEAt/h5AjE98B+3Z6j61iHUjamWjp1gKjoGP4bMW8h9D5ov+pxDrpY42bsZh3A== X-Received: by 2002:a05:651c:508:b0:304:4e03:f9d9 with SMTP id 38308e7fff4ca-3072cb137e2mr182415341fa.28.1738054001666; Tue, 28 Jan 2025 00:46:41 -0800 (PST) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3076baef4desm17516901fa.59.2025.01.28.00.46.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jan 2025 00:46:40 -0800 (PST) Date: Tue, 28 Jan 2025 10:46:37 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Krzysztof Pyrkosz via ffmpeg-devel In-Reply-To: Message-ID: <8b851b99-5416-b5ed-021-107d22dfaa9d@martin.st> References: <20250124185825.1323-3-ffmpeg@szaka.eu> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aarch64/aacencdsp: NEON implementation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Krzysztof Pyrkosz Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 27 Jan 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote: > On Sun, Jan 26, 2025 at 01:29:38AM +0200, Martin Storsj=F6 wrote: >> With the following diff: >> >> @@ -40,8 +41,8 @@ function ff_aac_quant_bands_neon, export=3D1 >> movi v5.4s, 0x80, lsl #24 >> .irp signed,1,0 >> \signed: >> - subs w3, w3, #4 >> ld1 {v3.4s}, [x2], #16 >> + subs w3, w3, #4 >> fmul v3.4s, v3.4s, v0.s[0] >> .if \signed >> ld1 {v4.4s}, [x1], #16 >> >> I'm getting the following improvement: >> >> Before: Cortex A53 A72 A78 >> quant_bands_signed_neon: 5661.0 2383.2 1113.2 >> quant_bands_unsigned_neon: 5401.5 2067.8 811.8 >> After: >> quant_bands_signed_neon: 5402.5 2385.5 1090.0 >> quant_bands_unsigned_neon: 5145.5 2067.8 809.5 >> >> No change on the A72 here, but apparently a (very) small improvement on = the >> A78, and a bigger improvement on the A53 as expected. >> >> If you don't mind these changes, we could land the change with that twea= ked. >> (I guess the numbers in the commit message could be re-measured, but I'm= not >> sure if they change enough to make much of a difference there, especiall= y on >> the cores you've measured on.) >> >> // Martin > > I don't mind these changes, I'm perfectly fine with applying any > improvements on top of the patch. > The speeds on A78 and x13s did not change significantly, the initial > benchmark values can be used. Ok, great, I've pushed this patch then. Thanks for your contribution! // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".