From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 564E940297 for ; Fri, 22 Jul 2022 12:46:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 78C0C68B69E; Fri, 22 Jul 2022 15:46:23 +0300 (EEST) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B161B68B36E for ; Fri, 22 Jul 2022 15:46:16 +0300 (EEST) Received: by mail-oi1-f181.google.com with SMTP id s188so5507424oie.0 for ; Fri, 22 Jul 2022 05:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=Jj4w1SyUK3LJnLpfsdUUtREEE3310w/N42qc+Ser5K8=; b=S0XJgcFWfTsOZZ/7pe7qKj3vKJ+eDWCSmmNp1vb9ItSGTbTuoHhCP2VTguwFZsj0VE QLW862r6gVKkuhNTNlcpj5SvJNI8+gm5hil8kv8pfvAhQEDWTaHXLq1VZXLXUkq5AcQA lLqga+SwSHMULIDfS2fFrJLBCXN8k+oh1gxJYVX4x/Q4sfrSqZkObZGiMN5fG4iqHzSx Fr6xuTnB2cc52qh9ftvFJTeypUMyEQWAkoQPHdM8R+SMyjq2tuAmpG3JFdj2kwpDOPMR xDu/zydoj+an7FW4OaH/wubatWIgJgJrXG4u4EnpIJK4CxadJYM/CE2VHIGnFuJBqB4U hl/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=Jj4w1SyUK3LJnLpfsdUUtREEE3310w/N42qc+Ser5K8=; b=6q5EFkQUcrDN05eBPvgD+zQboQ25cq2WBWYM8qI13J01zyoEEVLwoJhwTK/BzD4v3h Ogz54m42mk8mnbVHF3cbZN7LqnyBVWR8vLshi6wssDkmgziTsH+AMx66MNtQWW0+mvEF 1DZseGsDiG0N8GCI9ShQHFzX8dUAc8mXDNylk+9bzVO18QTcizn+N4tUgzpPrCYVGcRC DIaoNNZFS6Up/1u27vK0WVeZcAVx6S3LSm9o+Z9Gfn2HXXCqOazzYlw3GndibBAeMEIH 7irQ/epYbD7uKNAGiyQABAqIzPtZOORDScTSunM2X9SXMiuvv0yDU9Wgoc72nWUaQ+ci Q6kg== X-Gm-Message-State: AJIora/7FKEjjrdTpm3MM5yK9FA3VJomPRguc1LxDqk2B+kqoo0Qrrkm UoGhGY/Hz50OST8THa30lFrBZviAwuCYrg== X-Google-Smtp-Source: AGRyM1uh5vQSE4UaVfdnneIpInZN3Uq6vJd7rkFAxOKRKuBemSo8DkbmF1h9Ra+NkF+6YS/CFdQMYA== X-Received: by 2002:a05:6808:1495:b0:33a:ad84:1dc7 with SMTP id e21-20020a056808149500b0033aad841dc7mr3227325oiw.177.1658493974120; Fri, 22 Jul 2022 05:46:14 -0700 (PDT) Received: from [192.168.0.11] ([186.136.131.204]) by smtp.gmail.com with ESMTPSA id j19-20020a9d7693000000b0061c9ab1032dsm1915834otl.18.2022.07.22.05.46.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 05:46:13 -0700 (PDT) Message-ID: <8b484a4e-ba96-d54e-a4b5-84e1ee5e53f9@gmail.com> Date: Fri, 22 Jul 2022 09:46:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220713175948.1955-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: don't force HE-AACv2 profile if no PS info is present X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/18/2022 10:57 AM, Andreas Rheinhardt wrote: > James Almer: >> On 7/14/2022 9:10 AM, Andreas Rheinhardt wrote: >>> James Almer: >>>> Should fix ticket #3361 >>>> >>>> Signed-off-by: James Almer >>>> --- >>>> This also needs an update to some fate ref samples i'll upload before >>>> pushing >>>> (fate-aac-al_sbr_ps_04_ur and fate-aac-al_sbr_ps_06_ur which are now >>>> decoded >>>> properly as he_aac mono, so the .s16 files need to be replaced). >>>> >>> >>> We have both a fixed-point AAC as well as a floating point AAC decoder. >>> Is there actually a test that tests that the output they produce is >>> reasonably close? If not, could we make the test so that the same file >>> is decoded once with the fixed-point and once with the floating-point >>> decoder and then compared? >> >> That wouldn't help much, i think. Almost all changes to *_template.c >> files are going to affect both decoders, so a breakage would not be >> detected if you compare their output with each other as they would both >> exhibit it. >> > > I actually thought that the aac_fixed tests used checksums instead of > ref files; then changes and breakages would be visible by changes to > these files. Apparently I was wrong about that and the ref files are > used for both aac and aac_fixed. But a test like the one outlined above > would nevertheless obviate the need for a new ref file. Judging by https://git.videolan.org/?p=ffmpeg.git;a=blob;f=tests/fate/aac.mak;h=1743428f544fad8946dba11dd4ecec0630eb70a6;hb=HEAD#l117 it seems at least for these samples the fixed decoder does not generate a decoded stream comparable to the float one, so I'll just upload a new raw pcm file. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".