* [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E
@ 2022-12-07 2:43 Xiang, Haihao
2022-12-07 5:21 ` Gyan Doshi
0 siblings, 1 reply; 3+ messages in thread
From: Xiang, Haihao @ 2022-12-07 2:43 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Haihao Xiang
From: Haihao Xiang <haihao.xiang@intel.com>
PI, PHI and E are defined in libavutil/eval.c, and user may use these
constants for scale_qsv filter, so we needn't re-define these variables
in vf_scale_qsv.c
Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
---
libavfilter/vf_scale_qsv.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
index 758e730f78..fa37e95429 100644
--- a/libavfilter/vf_scale_qsv.c
+++ b/libavfilter/vf_scale_qsv.c
@@ -44,9 +44,6 @@
#include "video.h"
static const char *const var_names[] = {
- "PI",
- "PHI",
- "E",
"in_w", "iw",
"in_h", "ih",
"out_w", "ow",
@@ -57,9 +54,6 @@ static const char *const var_names[] = {
};
enum var_name {
- VAR_PI,
- VAR_PHI,
- VAR_E,
VAR_IN_W, VAR_IW,
VAR_IN_H, VAR_IH,
VAR_OUT_W, VAR_OW,
@@ -470,9 +464,6 @@ static int qsvscale_config_props(AVFilterLink *outlink)
char *expr;
int ret;
- var_values[VAR_PI] = M_PI;
- var_values[VAR_PHI] = M_PHI;
- var_values[VAR_E] = M_E;
var_values[VAR_IN_W] = var_values[VAR_IW] = inlink->w;
var_values[VAR_IN_H] = var_values[VAR_IH] = inlink->h;
var_values[VAR_OUT_W] = var_values[VAR_OW] = NAN;
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E
2022-12-07 2:43 [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E Xiang, Haihao
@ 2022-12-07 5:21 ` Gyan Doshi
2022-12-08 6:38 ` Xiang, Haihao
0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2022-12-07 5:21 UTC (permalink / raw)
To: ffmpeg-devel
On 2022-12-07 08:13 am, Xiang, Haihao wrote:
> From: Haihao Xiang <haihao.xiang@intel.com>
>
> PI, PHI and E are defined in libavutil/eval.c, and user may use these
> constants for scale_qsv filter, so we needn't re-define these variables
> in vf_scale_qsv.c
LGTM.
>
> Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> ---
> libavfilter/vf_scale_qsv.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
> index 758e730f78..fa37e95429 100644
> --- a/libavfilter/vf_scale_qsv.c
> +++ b/libavfilter/vf_scale_qsv.c
> @@ -44,9 +44,6 @@
> #include "video.h"
>
> static const char *const var_names[] = {
> - "PI",
> - "PHI",
> - "E",
> "in_w", "iw",
> "in_h", "ih",
> "out_w", "ow",
> @@ -57,9 +54,6 @@ static const char *const var_names[] = {
> };
>
> enum var_name {
> - VAR_PI,
> - VAR_PHI,
> - VAR_E,
> VAR_IN_W, VAR_IW,
> VAR_IN_H, VAR_IH,
> VAR_OUT_W, VAR_OW,
> @@ -470,9 +464,6 @@ static int qsvscale_config_props(AVFilterLink *outlink)
> char *expr;
> int ret;
>
> - var_values[VAR_PI] = M_PI;
> - var_values[VAR_PHI] = M_PHI;
> - var_values[VAR_E] = M_E;
> var_values[VAR_IN_W] = var_values[VAR_IW] = inlink->w;
> var_values[VAR_IN_H] = var_values[VAR_IH] = inlink->h;
> var_values[VAR_OUT_W] = var_values[VAR_OW] = NAN;
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E
2022-12-07 5:21 ` Gyan Doshi
@ 2022-12-08 6:38 ` Xiang, Haihao
0 siblings, 0 replies; 3+ messages in thread
From: Xiang, Haihao @ 2022-12-08 6:38 UTC (permalink / raw)
To: ffmpeg-devel
On Wo, 2022-12-07 at 10:51 +0530, Gyan Doshi wrote:
>
> On 2022-12-07 08:13 am, Xiang, Haihao wrote:
> > From: Haihao Xiang <haihao.xiang@intel.com>
> >
> > PI, PHI and E are defined in libavutil/eval.c, and user may use these
> > constants for scale_qsv filter, so we needn't re-define these variables
> > in vf_scale_qsv.c
>
> LGTM.
Thanks for review, applied.
-Haihao
>
>
> > Signed-off-by: Haihao Xiang <haihao.xiang@intel.com>
> > ---
> > libavfilter/vf_scale_qsv.c | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
> > index 758e730f78..fa37e95429 100644
> > --- a/libavfilter/vf_scale_qsv.c
> > +++ b/libavfilter/vf_scale_qsv.c
> > @@ -44,9 +44,6 @@
> > #include "video.h"
> >
> > static const char *const var_names[] = {
> > - "PI",
> > - "PHI",
> > - "E",
> > "in_w", "iw",
> > "in_h", "ih",
> > "out_w", "ow",
> > @@ -57,9 +54,6 @@ static const char *const var_names[] = {
> > };
> >
> > enum var_name {
> > - VAR_PI,
> > - VAR_PHI,
> > - VAR_E,
> > VAR_IN_W, VAR_IW,
> > VAR_IN_H, VAR_IH,
> > VAR_OUT_W, VAR_OW,
> > @@ -470,9 +464,6 @@ static int qsvscale_config_props(AVFilterLink *outlink)
> > char *expr;
> > int ret;
> >
> > - var_values[VAR_PI] = M_PI;
> > - var_values[VAR_PHI] = M_PHI;
> > - var_values[VAR_E] = M_E;
> > var_values[VAR_IN_W] = var_values[VAR_IW] = inlink->w;
> > var_values[VAR_IN_H] = var_values[VAR_IH] = inlink->h;
> > var_values[VAR_OUT_W] = var_values[VAR_OW] = NAN;
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-08 6:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 2:43 [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E Xiang, Haihao
2022-12-07 5:21 ` Gyan Doshi
2022-12-08 6:38 ` Xiang, Haihao
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git