From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 9BE334A5D5
	for <ffmpegdev@gitmailbox.com>; Thu,  2 May 2024 21:29:47 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F69968D84D;
	Fri,  3 May 2024 00:29:44 +0300 (EEST)
Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com
 [209.85.210.169])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9055268D7DC
 for <ffmpeg-devel@ffmpeg.org>; Fri,  3 May 2024 00:29:37 +0300 (EEST)
Received: by mail-pf1-f169.google.com with SMTP id
 d2e1a72fcca58-6edc61d0ff6so8382231b3a.2
 for <ffmpeg-devel@ffmpeg.org>; Thu, 02 May 2024 14:29:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20230601; t=1714685375; x=1715290175; darn=ffmpeg.org;
 h=content-transfer-encoding:in-reply-to:from:content-language
 :references:to:subject:user-agent:mime-version:date:message-id:from
 :to:cc:subject:date:message-id:reply-to;
 bh=L30Cdok2D2kKqBHzd2eVZqS5DTGFgiarsKl/Vo62r04=;
 b=lVCBowudNMXQYrFUCuMEHHFElFEpXXgRlRqdEV9wSbewMVK6jMPeIbfc4ocnxTEb5v
 XktUvgkaLFBAhOj49rlE9sWS3Tqzqv4uOAZt2zO1KeDXat3cjShT/Dpao0t8EOkLIphZ
 NAbkymbon93h4ctwwRq5yP+MvbTyDSMPMHdKUQvwUQX97qr9JHg3ysr3QOblMUL64iBQ
 fDKYcErS7G0xXYwzJIfB2RorfwNY9y/0MefrmGG9o+2vAp5DyGJMWxCwTQ7IU9zFm5tz
 TZE5n0iIWsY3w1pAWCzgOaxUcnYxWrkOztdrHhtfPtO2cda+8eZiHgIrit81ZvmX+BZV
 UblA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1714685375; x=1715290175;
 h=content-transfer-encoding:in-reply-to:from:content-language
 :references:to:subject:user-agent:mime-version:date:message-id
 :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=L30Cdok2D2kKqBHzd2eVZqS5DTGFgiarsKl/Vo62r04=;
 b=T2A/kBxc31EwBs38x2IJyhpmFmUauo+Npkfrahvkw1jNIKJEDT9ARerq4BB2yFjjMc
 eZLMWF+DYK7DV5GROalno1PDpeOKznuCwLh5uCgskFOgkTx4T8rxg3LtR24k1yEIMZe3
 ZBiExMXQjPSreLXBhPHbsbWCyGWmImgWpE47HflF8OFQ90+vp0jt8+q5C3+FfbDdjJAm
 7xfQn5DW9/qFlZK9zKIij+MwIt4c4TIRAPcFC0deXP7ay0xyme15xcjaH0TYDnnE0jlA
 PHrQkpYP80eJnOImAOZBFJiYBmbpiuJg/IzleJd+3P0W5MydpqfAEkG5EId83+6REvEu
 1v6g==
X-Gm-Message-State: AOJu0Yw7Gtc3zCFn1J25U64YU0kpERJ5SrBZGa4LrYP0jJg1gUvlVGJs
 uXkF3m3a/REkMIcAfGb8A6PN41FaHJtKIO9kz5Xb/DNTuNSqQFPjdIuqrQ==
X-Google-Smtp-Source: AGHT+IGc85oOlFgSeANauk+95J20Xl4g7//uZ9ilFROcCFzch71Dvk/EAfniLp2Ze29ZI0wviU0msA==
X-Received: by 2002:a05:6a20:a309:b0:1a9:5eb1:7f35 with SMTP id
 x9-20020a056a20a30900b001a95eb17f35mr860445pzk.46.1714685374791; 
 Thu, 02 May 2024 14:29:34 -0700 (PDT)
Received: from [192.168.0.10] ([190.194.167.233])
 by smtp.gmail.com with ESMTPSA id
 y21-20020a056a00191500b006ece7bb5636sm1725007pfi.134.2024.05.02.14.29.33
 for <ffmpeg-devel@ffmpeg.org>
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Thu, 02 May 2024 14:29:34 -0700 (PDT)
Message-ID: <8aa7804e-ce52-48ff-8909-dc4ca98763da@gmail.com>
Date: Thu, 2 May 2024 18:29:34 -0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20240430231926.2506728-1-michael@niedermayer.cc>
 <ab4c8ccb-815b-05e7-5b94-d34f032ed2d5@passwd.hu>
Content-Language: en-US
From: James Almer <jamrial@gmail.com>
In-Reply-To: <ab4c8ccb-815b-05e7-5b94-d34f032ed2d5@passwd.hu>
Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the
 checksum for side data
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/8aa7804e-ce52-48ff-8909-dc4ca98763da@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 5/2/2024 6:23 PM, Marton Balint wrote:
> 
> 
> On Wed, 1 May 2024, Michael Niedermayer wrote:
> 
>> This allows detecting issues in side data related code, same as what
>> framecrc does for before already for packet data itself.
>>
>> This basically reverts c6ae560a18d67b9ddaa25a0338b7fb55e3312e57.
> 
> Can you at least add an option which allows disabling dumping the side 
> data? Changing the format of framecrc output again and again is not very 

The framehash/framemd5 muxer is versioned, which is what you should use 
if you want parseable output.

> nice, as it is a public muxer, surely some users depend on it behaving 
> in a certain way... Also some feedback from Anton would be nice, as he 
> made the original commit which removed side data support...

Anton afaik is on holidays, but agree, this patch can wait a bit.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".