Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for side data
Date: Thu, 2 May 2024 18:29:34 -0300
Message-ID: <8aa7804e-ce52-48ff-8909-dc4ca98763da@gmail.com> (raw)
In-Reply-To: <ab4c8ccb-815b-05e7-5b94-d34f032ed2d5@passwd.hu>

On 5/2/2024 6:23 PM, Marton Balint wrote:
> 
> 
> On Wed, 1 May 2024, Michael Niedermayer wrote:
> 
>> This allows detecting issues in side data related code, same as what
>> framecrc does for before already for packet data itself.
>>
>> This basically reverts c6ae560a18d67b9ddaa25a0338b7fb55e3312e57.
> 
> Can you at least add an option which allows disabling dumping the side 
> data? Changing the format of framecrc output again and again is not very 

The framehash/framemd5 muxer is versioned, which is what you should use 
if you want parseable output.

> nice, as it is a public muxer, surely some users depend on it behaving 
> in a certain way... Also some feedback from Anton would be nice, as he 
> made the original commit which removed side data support...

Anton afaik is on holidays, but agree, this patch can wait a bit.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-05-02 21:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 23:19 Michael Niedermayer
2024-05-02 15:05 ` [FFmpeg-devel] [PATCH] avformat/framecrcenc: support calculating checksum of IAMF " James Almer
2024-05-02 15:16   ` Andreas Rheinhardt
2024-05-02 18:33     ` James Almer
2024-05-02 21:23 ` [FFmpeg-devel] [PATCH v3] avformat/framecrcenc: compute the checksum for " Marton Balint
2024-05-02 21:29   ` James Almer [this message]
2024-05-04  8:34     ` Marton Balint
2024-05-04 15:16       ` James Almer
2024-05-04 17:17         ` Marton Balint
2024-05-04 20:58         ` Michael Niedermayer
2024-05-04 21:02           ` James Almer
2024-05-05  1:45             ` Michael Niedermayer
2024-05-05  1:54               ` James Almer
2024-05-06  1:34                 ` Michael Niedermayer
2024-05-02 23:27   ` Michael Niedermayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8aa7804e-ce52-48ff-8909-dc4ca98763da@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git