From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B2FB443FDB for ; Thu, 25 Aug 2022 00:11:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CDF6568B7CC; Thu, 25 Aug 2022 03:11:53 +0300 (EEST) Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 214AC68B06F for ; Thu, 25 Aug 2022 03:11:47 +0300 (EEST) Received: by mail-vs1-f54.google.com with SMTP id 67so19289397vsv.2 for ; Wed, 24 Aug 2022 17:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Pg+ttf473j8jTWn4yTBrcoEhWxoxeW2DeOnUrG/hcEo=; b=inUKzfB5zeC9wpSFmXeJ+6mmBQns22jAjH4PehOd5LZ5VDxKKkHD/WQFVLtdRovxDR pUI3auQi8rQLNDMjO70qsTBc+ZKjEoqiD/G2JiYXTVYvz9/PnyoJX6ahTAptzn8e6/bw uREcRE/MNxb9ykg1UR9XxcUw5G/QaPK+LHOrKhBoEDgS4C2U07GohxcpxRvzKXK/c8/z w7JHlARlhHH3L56SF6SYz9tfD2nUpgAzq3MZrDgc/jEVgDZ6hnK8q1qWS68coheGBzai MhrQ5Mw9wWU9mdRk139H17oPEPi8Z0KlwBecLXDX4oSMM4RmrPu12pDXfPPmlunNR1Wx eKRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Pg+ttf473j8jTWn4yTBrcoEhWxoxeW2DeOnUrG/hcEo=; b=5KVLCnusBRY8hCSubuA7dK2wJa2/IlzvCRf3ovsQLCdKO82Glquh6/gxWkQq7f33gt kSJ3fSEh9kbdrQ5s9pZ7HLtEfQ7q040xEs06gu6UQybgxmZpxqVD0zVfS0W8oMOXqceT qw/iFzzS44OARIK/0dTkKuIfuLLH1fJtroLMU/J2hqn7XNy9ZMBdrOrlItSnRUyOQrxz X18/u9ZAh+npz6zgfW6I4x+1UgkOVnCTaXeYbn/wDpR21jD5ucnK4HOoRmFGwRGu32Se x7dkSAWrP6RMY57WdY48OcFd6RyHK+nOmJ009fYhJ/MaetgEUAHD51fH+tLhG07Toyew 0DFw== X-Gm-Message-State: ACgBeo06D69tDNNqV7zTqdoShVjBftK+A0cQ6CYjUwZ4iJIlFtFoYoU9 ayIOPZMMZqjhhY7/sZgzy/WYXRmkQ72CmA== X-Google-Smtp-Source: AA6agR4ey0T0TkSd1I1L7s81BilsVXIm5eyxsxc1tYC35yCxQwIWK70HUrq5bbClvxegBxHdjAZYVA== X-Received: by 2002:a67:a604:0:b0:390:7cb0:12ea with SMTP id p4-20020a67a604000000b003907cb012eamr677540vse.3.1661386304361; Wed, 24 Aug 2022 17:11:44 -0700 (PDT) Received: from [192.168.1.15] (075-115-109-114.inf.spectrum.com. [75.115.109.114]) by smtp.gmail.com with ESMTPSA id z20-20020ab06294000000b00384ca77a9e8sm15071103uao.27.2022.08.24.17.11.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 17:11:43 -0700 (PDT) Message-ID: <8a7161a1-ef76-0958-ba9e-8ecf7b7fa998@gmail.com> Date: Wed, 24 Aug 2022 20:11:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220208110240.4179-1-qyot27@gmail.com> <20220208110240.4179-3-qyot27@gmail.com> From: Stephen Hutchinson In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/3] avisynth: use AviSynth+'s frame properties to set various fields X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/24/22 1:04 PM, Steinar Apalnes wrote: > tir. 8. feb. 2022 kl. 12:03 skrev Stephen Hutchinson : > >> * Field Order >> * Chroma Location >> * Color Transfer Characteristics >> * Color Range >> * Color Primaries >> * Matrix Coefficients >> >> The existing TFF/BFF detection is retained as a fallback for >> older versions of AviSynth that can't access frame properties. >> The other properties have no legacy equivalent to detect them. >> >> Signed-off-by: Stephen Hutchinson >> > ....... > Hi Stephen, > > Would it be possible to add support for "_SARum" and "_SARDen" so that > ffmpeg could also recognize the sample aspect ratio in avs scripts? > I'm a bit hesitant to do so, namely because the _SARNum/Den properties are much more likely to need to have been changed due to operations in-script, and unless the user is studious about updating those properties after even just a basic resizing operation, then _SARNum/Den will still be set to the original values populated by the source filter, and will be wrong, leading to encodes ending up wrong and potentially bug reports to Trac which aren't actually the fault of the demuxer. This is partially coming from the fact that even the color-based properties that were already added have experienced some level of backlash because of the requirement for users to ensure the properties are correctly updated if they've done any changes to those factors (as best as I'm aware, the filters in the AviSynth+ core still only pass through the existing properties, but they don't update them if they pertain to that property's functionality; I believe some external filters do update them, however). I would be fairly confident in betting that users resizing video is far more common than them doing color correction ops that would require updating the frameprops FFmpeg can currently read. One mitigation to that, IMO, would be to flag that as an experimental feature, making it to where FFmpeg won't read _SARNum/Den unless the -strict option has been used. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".