From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2849048FAB for ; Tue, 30 Jan 2024 21:59:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B79EF68D083; Tue, 30 Jan 2024 23:59:04 +0200 (EET) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 10EF968CDA0 for ; Tue, 30 Jan 2024 23:58:59 +0200 (EET) Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6e117e0fee8so1902142a34.2 for ; Tue, 30 Jan 2024 13:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706651936; x=1707256736; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FbAjD45jtCIiH6SNJE82KzxchvfIOeAUXnsu3Dhlt/E=; b=RGaNJkYEp5HMSipz+eN4JeSciIbN0cu4tg84dW25MAg1BJ8UG015tpsmzhIWllhoml Qjl+MSLfgfBW2KDE/2jT3OW89cQUefTEpDSGoeWcnazdoWIR83DWzXTegOxD2jKd/e0T NAVZOX3ryISyqcmIqLxubnMA9objTVlv1iIORwOezjTYKSP5+9r+D9sU48w19cZ3fULo PH0pRcQJpqBw0mO/11ZFDhOTE/oV3WVGnbmQnL3ma+VH6xlY17JxlWL8nHjgwJGuQlrw WSA7fkNOyf3uROvIvOvB1rIQ1B1HI/D+Nx+/Byhy6a0VoBGQ4qWBDiKjOLyoxQoqdnhQ D1fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706651936; x=1707256736; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FbAjD45jtCIiH6SNJE82KzxchvfIOeAUXnsu3Dhlt/E=; b=idnua+F5p3/Xps5XAm6o4YLyCpajK/lWmkHMTr514voTLJNQ3fbHX7Hka6RVJS7Lo7 ivl3zEAQHcwRBB1xbawylO2w9/57/36XqBFgj3G4FNUHMDz2lSN6VKDIGe411i6BWcLj BKgNXXfRjoKIl5K76s+eXn+2mQzpr+9z5zZ15k5IK50RMzQ1FCK8cgkGhZ9ktHyZS+1T bES62D62Sf1pOnMLr6kzYJcJe+nV8I9+WEa2Lsf1lTh7zzU7xS20Z9a0wh2WMhPxRVg0 y0nsJQd/wBUqMVVJZnxu94UesAod6eusC43Wu/XR40YGJXevNovJweV6bQzqrspRX6pw rsoA== X-Gm-Message-State: AOJu0YxXDKL5Xj/LjYBWr8rkSX4haMsUXApDWCUy3gYUhSk8H9cKAJF0 0vkIZ9SrVoXX4Oyg2JuJNScecQBAa3mtmU9hjusDtmkxS37HJLA5rFfLPtpQ X-Google-Smtp-Source: AGHT+IEHZ/ScRJP9crqkOooVQ8KgQtd/vktTUh3fHR44YNVn+N/aioscVj347IFuNpfSquxoRMfEAQ== X-Received: by 2002:a05:6359:459c:b0:176:d0a8:8df with SMTP id no28-20020a056359459c00b00176d0a808dfmr11616355rwb.8.1706651936114; Tue, 30 Jan 2024 13:58:56 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id l12-20020a633e0c000000b005cfc1015befsm8915179pga.89.2024.01.30.13.58.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jan 2024 13:58:55 -0800 (PST) Message-ID: <8a5e6efa-9be1-4247-8330-eab641e5da0b@gmail.com> Date: Tue, 30 Jan 2024 18:59:18 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240130173218.63297-1-jamrial@gmail.com> <20240130173218.63297-6-jamrial@gmail.com> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 6/7] avcodec/put_bits: add put_leb() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/30/2024 6:53 PM, Andreas Rheinhardt wrote: > James Almer: >> Signed-off-by: James Almer >> --- >> libavcodec/put_bits.h | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/libavcodec/put_bits.h b/libavcodec/put_bits.h >> index 4561dc131a..04dedd3342 100644 >> --- a/libavcodec/put_bits.h >> +++ b/libavcodec/put_bits.h >> @@ -370,6 +370,22 @@ static inline void put_sbits63(PutBitContext *pb, int n, int64_t value) >> put_bits64(pb, n, (uint64_t)(value) & (~(UINT64_MAX << n))); >> } >> >> +static inline void put_leb(PutBitContext *s, unsigned value) >> +{ >> + int len; >> + uint8_t byte; >> + >> + len = (av_log2(value) + 7) / 7; >> + >> + for (int i = 0; i < len; i++) { >> + byte = value >> (7 * i) & 0x7f; >> + if (i < len - 1) >> + byte |= 0x80; >> + >> + put_bits_no_assert(s, 8, byte); >> + } >> +} >> + >> /** >> * Return the pointer to the byte where the bitstream writer will put >> * the next bit. > > This function does use any internals of PutBitContext and should > therefore be in user-code. In fact, get_leb() should not exist in > get_bits.h. You could say the same about skip_1stop_8data_bits(), decode210(), decode012() and get_vlc_multi(). And the idea is to have these be reusable. leb is evidently going to be used by anything AOMedia will make. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".