Re: [FFmpeg-devel] [PATCH v7 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl

From: Marvin Scholz <epirat07@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v7 3/5] avcodec/libjxl: add Jpeg XL encoding via libjxl
Date: Tue, 22 Mar 2022 16:52:34 +0100
Message-ID: <8DF71AAE-1251-4D4C-9B53-E3586E47DB4C@gmail.com> (raw)
In-Reply-To: <MymGE6c--3-2@lynne.ee>

On 22 Mar 2022, at 16:35, Lynne wrote:

> 19 Mar 2022, 18:26 by leo.izen@gmail.com:
>
>> This commit adds encoding support to libavcodec
>> for Jpeg XL images via the external library libjxl.
>> ---
>>  configure              |   3 +-
>>  libavcodec/Makefile    |   1 +
>>  libavcodec/allcodecs.c |   1 +
>>  libavcodec/libjxlenc.c | 386 +++++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 390 insertions(+), 1 deletion(-)
>>  create mode 100644 libavcodec/libjxlenc.c
>>
>
> I can't accept this as-is, so NAK.
>
> The coding style needs to be fixed.
> And you must remove the sneaky MAINTAINERS change to get yourself
> push access. We made that against the rules, which you've clearly read
> before submitting the patchset, right?

Since when do people in MAINTAINERS automatically get push access?
Back then when I contributed the Icecast module I was specifically
asked to add me to the MAINTAINERS file for it and I do not have commit
access.

As far as I can see there is nothing in the rules stating what you said?

The only relevant entry I found is:

 Check your entries in MAINTAINERS.

 Make sure that no parts of the codebase that you maintain are missing from the MAINTAINERS file.
 If something that you want to maintain is missing add it with your name after it. If at some point
 you no longer want to maintain some code, then please help in finding a new maintainer and also don’t
 forget to update the MAINTAINERS file.

which seems to imply that what was done here is actually what is supposed to be done.
If that's not true, it would probably help to reword this to clarify things…

>
> Then I'll spare time to look at it and merge it myself.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".