From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DA1F94E81E for ; Wed, 11 Jun 2025 21:05:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8673168A0C3; Thu, 12 Jun 2025 00:05:41 +0300 (EEST) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 64A57687FCC for ; Thu, 12 Jun 2025 00:05:34 +0300 (EEST) Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-450cb2ddd46so1109355e9.2 for ; Wed, 11 Jun 2025 14:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749675934; x=1750280734; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6k7DYMy74okj2dIsFR6uR5f1biKw0KgYlhfJKo1lMmo=; b=TlmRu4Ang7wwIqpz3tMlFDH/Wv0+rqmItoZiTGvZUaeWluqGrw8gKUK+KUAn8Whys0 CngaHjJFFJGOtE96VUGNMHGghvvDPo5WCu86LTRtEx0RmflR0yZiEiJ4Z6dkyy9sjPOz o1bVfhzUNbhGQFzhWjHfW8aF18TVkjyYSX5M5ixRBsaJgOPYFzIZA8Yr99lpONhpupNB GHCish1+QgP9mpwQ4U6LWuwTriC0/NYemT+Am2BbKRiTAb8ZqaDAngvmD9oZ0AVMuWfD Xw5CKfteCx5WyTvEWpxPsW11mGIG3oTgwawv1rgRuSCtBZo9UjADg3WrNUl0+djAYgOG LESg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749675934; x=1750280734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6k7DYMy74okj2dIsFR6uR5f1biKw0KgYlhfJKo1lMmo=; b=VHu5pCe1Yy1SGOfwlv3m4lVSSQUMsfB6RlFmA7B23ZGdCjyW/SNCEbFocvugmcjv3n IHqR9UsBXsOc+ePRsh07YA/NPC9hZ89WiwzcIr40RVm7IPK/VnRf/yIXV96AsrmZrpjo Qbh7LHrZV+CnuDBIFsy2SkGQGlUTn1hpqaZpMXPXwse0dytP4YfJzCN/7rS/QIgh+xhU G5VZRox/32Ix0wZAbvHP6rL94dtNp1jM/ku2YAH6v9MkrpwyjIMihjgq20/tXV2+tS55 12x+QMNj8otmc6tIL2DGnH9Kmqcyegjz0WI3AAm5ipc/UiPwV/ZCs/26Al5+dJOOUj+4 GLIA== X-Gm-Message-State: AOJu0Yx27VqsQLlhL5I+H+AmkSPDe5vuEu9f9JdOF7gTM58UBvTzbDyf +ufA3ZdJAN1/p6CXkY8mrg8YY7y1WZDNZnPLripGlKBGOTjAX+iZoQDuKKiZmA== X-Gm-Gg: ASbGncsf8zk/cqXzoU1hPHrDGPBopTR8IPoThDB2KxXJvPi5TDvowa3k0GT64vX7yQX f1i9zdxanPDA8WuMQpIkExTmGb68aWn06rhXlWNsJhtLhdVxeSFtJbBiKIjklhXkNcRiZVxDqBv 2eg5LtngyDzj6+sO+hkUEJp7DqDpbgbsQpYeP8wsHEY1zoZHeRv1QtZC+Y7WsttUfiVl0zqVg8d YrnR+NBIw8qVnqoVdtLffgp3t+USpwFEArjc8o9zjv+bwJfUOiQWsWhv5VKpgtMNoMs/rbZF5HL kBE4vqGGJ5ec7PN6Ke4RN+7wcYJZGY2qmH5DI/nVyB+liELEcg+fsTNgrlgHro0cTBWFdCVR+Fo ofK3TAlXavL7eUx4+t6oJWZJqtOcfxVPoRY5Can/rC1++ChtsDRlOcHxZaaOZmxQT7YpG+1b/W9 w= X-Google-Smtp-Source: AGHT+IG+ME64GHV+dkyHU0LiT4g3HLpS5IQLGs1aqkAxyyM6oNPgyTUwlNvfZITDB6l2rKeayAqq4A== X-Received: by 2002:a05:600c:a346:b0:450:cd25:e69c with SMTP id 5b1f17b1804b1-453248bdcfbmr37073095e9.21.1749675933594; Wed, 11 Jun 2025 14:05:33 -0700 (PDT) Received: from [192.168.178.57] (p200301023700450060f2a9d7350ce887.dip0.t-ipconnect.de. [2003:102:3700:4500:60f2:a9d7:350c:e887]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e243e59sm327565e9.19.2025.06.11.14.05.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jun 2025 14:05:33 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Wed, 11 Jun 2025 23:05:32 +0200 X-Mailer: MailMate (2.0r6222) Message-ID: <8C00E7FB-C0FE-4A04-9EA1-85E76DAD95BB@gmail.com> In-Reply-To: References: <20250611204213.97295-1-epirat07@gmail.com> <20250611204213.97295-4-epirat07@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove useless error check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11 Jun 2025, at 22:53, Andreas Rheinhardt wrote: > Marvin Scholz: >> This can never be reached as the errors are already handled >> locally when they occur in the code preceding this. >> --- >> fftools/textformat/avtextformat.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c >> index e1aaa9ba57..6a309f040b 100644 >> --- a/fftools/textformat/avtextformat.c >> +++ b/fftools/textformat/avtextformat.c >> @@ -229,8 +229,6 @@ int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *form >> >> if (tctx->formatter->init) >> ret = tctx->formatter->init(tctx); >> - if (ret < 0) >> - goto fail; >> >> *ptctx = tctx; >> > > And when init fails? Doh indeed, I overlooked the assignment in the previous line. Disregard this patch. > > - Andreas > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".