Re: [FFmpeg-devel] [PATCH 4/4] fftools/textformat: remove useless error check

[Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org>]

On 11 Jun 2025, at 22:53, Andreas Rheinhardt wrote:

> Marvin Scholz:
>> This can never be reached as the errors are already handled
>> locally when they occur in the code preceding this.
>> ---
>>  fftools/textformat/avtextformat.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c
>> index e1aaa9ba57..6a309f040b 100644
>> --- a/fftools/textformat/avtextformat.c
>> +++ b/fftools/textformat/avtextformat.c
>> @@ -229,8 +229,6 @@ int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *form
>>
>>      if (tctx->formatter->init)
>>          ret = tctx->formatter->init(tctx);
>> -    if (ret < 0)
>> -        goto fail;
>>
>>      *ptctx = tctx;
>>
>
> And when init fails?

Doh indeed, I overlooked the assignment in the previous line.

Disregard this patch.

>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".