From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B6E184092E for ; Fri, 24 Dec 2021 08:47:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 26AB668B278; Fri, 24 Dec 2021 10:47:57 +0200 (EET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8D2EA68B24C for ; Fri, 24 Dec 2021 10:47:50 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1640335675; x=1671871675; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=TfQFStkJTEUsc2iXIzts063sB79J8OzahqR9fSxIBzk=; b=Cnk9903EhjWNRTkBigYUF+Huwhg7vGZbudLi7EdbfalYqTyuFH/mq8Jj jujYhdGdpeyMD4kJLUM4v2i3eY0I6O1YsbYSgC2WU+iA066N5V8/MOU+x zxKzfcb6tgtu2s2e9n6sLqVfT9TTrFN0vriwm55WeCEza4rol18s6msmN uQT+lHV4HHxGcuXkrb6gkvPwI/BpLqMXUeAqAmNMks331O1NHJ1z1oG5M QOKgvCpCOJ0OQhXp+uOoOb9MfEkeDVJRihxIPIf7rluUdJXg/b//6R8dK y9OyGOQk988Z4yjlGZh+9uLskQnzqoVi7JlQJk80gYgQVe9fBseVVlTx4 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10207"; a="240907669" X-IronPort-AV: E=Sophos;i="5.88,232,1635231600"; d="scan'208";a="240907669" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Dec 2021 00:47:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,232,1635231600"; d="scan'208";a="757088777" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga006.fm.intel.com with ESMTP; 24 Dec 2021 00:47:42 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 24 Dec 2021 00:47:42 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 24 Dec 2021 00:47:41 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 24 Dec 2021 00:47:41 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 24 Dec 2021 00:47:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HEohYRTWnUCTReLyJBEyJvcQmMgnQ7yMlij8aYU9K3nPanOK7O9T7mhsX16W+BuexFXu9F3N6ZpSGjUea+0SCIAJy2fG+9Uuhjf0R1E9uY69Iq4pjfq/ElrBmVD2a7Fg7fV4WzVAhl0UMjGb44Hgzi5fCNawXinuXnS0+eVqYvwIhSoO0+h5Dz3/vER1U0a26R5dC+AGFv705938uZ8wJwFEelHhNEYSTSs8IC2FO4YfkGPC5YjrmyuecyrvPkDVeFM1AbN1/ijXlXNbXmL0HTrCooWgrnBfD9sGWwCe1FGgcn9YYbtueVdYfL/lLAGrofw/WwuxIt8FPqHksbojZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TfQFStkJTEUsc2iXIzts063sB79J8OzahqR9fSxIBzk=; b=kbeTeFFg5a8vf7d9VVfuR4qOsNh3zAyyL2J6Ngy2sULX98wZ/jAo17tMKrxh2wSQ7hiJbDFIA8tmLv+CU142fGWD3BvW6qKbBgaOrKtyPhh2dYFpvdu0TME0xxhTDvVPGOR7H14wIxiB5zcnq7XZ5LSj9t6SS10w6D0dxMiK6L3TB5Nbmbny6mk2BqfFviVXw22GeTYQtzycUaZHjrrim6l8J4GdTnM1PCczwFcZYDsdDRME8xrQGDtgLNqdgyboEBSW26tAx3rqlO83ladl5cdtnP3DFPbIiL2YbHEisE/+Zf7DeH9dmfIWwOEd6nUSXQKYSXzaO/DVsIXeDy+npA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by BN9PR11MB5291.namprd11.prod.outlook.com (2603:10b6:408:118::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.19; Fri, 24 Dec 2021 08:47:38 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::bcfc:ceef:cd03:dd16%3]) with mapi id 15.20.4801.023; Fri, 24 Dec 2021 08:47:38 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option Thread-Index: AQHX+J7KWrLgQbEG+kaG1dP1eerKmKxBVI+A Date: Fri, 24 Dec 2021 08:47:38 +0000 Message-ID: <8934708a136d272ca0df2d3160f11b121722a49a.camel@intel.com> References: <20210806021033.31954-1-haihao.xiang@intel.com> <6196106b1fba86f91e4587afb9cbfe3527f582a5.camel@intel.com> <20211224081715.GA29574@gmail.com> In-Reply-To: <20211224081715.GA29574@gmail.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69720b1e-3f9e-4730-7abc-08d9c6ba0a26 x-ms-traffictypediagnostic: BN9PR11MB5291:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JYMHoV3Ay4gIVZY0UTdOdEAVqmUKhkUxEDTaN8ok5toBZP6AyRUHBq6UAPlr3qmTkNjv8RhYW4bAtNqyH/Qk4hRuqUQ1L44gGLjByEHoMq+SdSSOWNjio/9NbM/TOlocwu2D4E58034C8JmA3Au31qlOrN9/hQ2otxIgZG3PV6u4F+zoBDK8wY8TX+4OSCHTgWFtN+QPVI7WhRVObuqZPFctd8fClmGCpmACwADDZ4bozIaec14dpa9NUszK5D40Sv9tpCtzgYLk21UwrnpWxU27rqWQFK3GZKeq5t57RhtLSOHEceTMwiOaEu0glPBUOQcps70KAg1gSueyl0UBwhseZMXXakhSpG6aTAa4aH1ZwuVfThl3M3p6WYk/+OO1lEMDMsU/8CNxwxPjLPpyuIl3PXmTzeEj2yQ50M3mzPdp63dV+fGXNEwGElxHTiPxsyz99V8bSfEsZRAzA0n4BWkuTxzgrDAXeYymoYSnBW7o12Q6HPHTp3OMzzUxQ4tR840EwqlAkQMhlc3RYPln8nuc1yBy9DwT5REBTIw8RuHyFSacJG/K83M0CJpJ1cbSUYDs3AjJP1zlh8xdM/EIPobtNhYrAFy9+UQqXrzlr5UXmam5ZpwAhejxi1LgyObRDN0mSOjfJbFXA9CL/bHJ0eXw13KWnw8c0O1LJ9vUhZ9V7H+WWfjMxUizTziPtUUGKp+dUt7JMMrpsQ8TExlKGxPOJgWwUzrRU5A2JDWOCAG2uWV5EtgBvO17Bp89+O4uWr7KRl9GOvdplG9whwt4ADMHZRbahmPANQuoLZg++PiUhzYwO4wTKpVKm7f86Z5B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(86362001)(71200400001)(316002)(508600001)(38100700002)(966005)(122000001)(4001150100001)(82960400001)(36756003)(66476007)(2906002)(66446008)(8676002)(64756008)(66556008)(38070700005)(8936002)(91956017)(83380400001)(5660300002)(6486002)(6512007)(66946007)(76116006)(6916009)(6506007)(186003)(26005)(2616005)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V0duOTV2aWlVMC9kTXZNNlBGQ2ppNXh0ZDJCVi9qalJ6ZGNKdUhaN0dvZk0y?= =?utf-8?B?OHJyK0xmUjR6RFJKVUQyUi9UNTgzZGRKcS9qbjBNcEtmRWZXMlJPelloeEtM?= =?utf-8?B?NFc4aThpNGZEZ05ud2thWnpUZm9HQ0Y1L1dMUlVnOHpHWGNPcm5uYlM5V3RP?= =?utf-8?B?bVp1cXRTS2Ezb0NObW1mb080RTZFKzVSZncwSTBNSHJjMlVleEdlWm5yTUcz?= =?utf-8?B?QUpqWnFrbXNUYTVTQUErRG5HKzZ1K2N1RUNBUHlFR01pZVZmQ1lCcFBJVHhk?= =?utf-8?B?dTV6c0JRbytSdG1HT25Ybm5IUHM3QXljRWtENDBsTjZNNkpOc2dvS2FKZHJ4?= =?utf-8?B?dTZhZElrNHFtZ3JFTjFZazl0bUZjalhINTgzU0RQNittN1JKOTJlaHVNeVlO?= =?utf-8?B?Y1lFb1MrN1EwandwL2poVllzN2trbHpyQ2JpTU5HQ21JOHNKQm5nN2NnYmp0?= =?utf-8?B?YUdZZnJzWGVrMmpEcjdRN3J1a21MMDVLNkRSUVVTTWFGVFoxcit5enRkTkpG?= =?utf-8?B?YVBZLy9HcWkybmVMck1GVnY1eDNjRjFKR0RRckY0eHNkZkxFR05aQ3pINCt1?= =?utf-8?B?bTlycGVvVjNnNmpHNURRL08yanFBZ0JOZVpyOGZCZjVLU0JzOExSYnVYRHVa?= =?utf-8?B?Uis5T25zRW94bjFEenBjT3RoeTEya254bjFOWmFWRGxwRGlaTTNlUTluT1BB?= =?utf-8?B?M2wxYUJBUDI2ajBKdUwzbmJxZ2pEVFdDdzUxQmRRVFFkVkZHVE8yOUpqcVZ6?= =?utf-8?B?U2VqR21US0tvY1V1Sm1qMGJSY0lKMmVxSFFhY0drOUo3Y0Y4UndpZkF5SzRX?= =?utf-8?B?bzRZL2h3WEE5b0MwTkE4d29TMldoQjc0TFM1NkhUa1Z4M0dwWXBROGZNOHBw?= =?utf-8?B?RmdKK0pOVlIwYWQ2NHRNaU90cWFtbWFaVGxaWW00VkpPY3Q3Q21QK2lxc0tT?= =?utf-8?B?Z3k1Wi9IckM5aXF2Tng1ZnhtVWx2SGFVRDNaWml6ajA3aFBRdUhIckJENkVh?= =?utf-8?B?ZElHaWkxcDNUR3NSZS9Oc3M0T09vQ1hBcXBaOEgxRGYvTFgvRFJkY2hxZWVZ?= =?utf-8?B?K2hVMVJ3SDRvWXNMbWVTSHhZb3Z5akVJRS9jdHpLQnQxUWgyVjhmSk00azBz?= =?utf-8?B?N2swcFBGNzQ5ZmNtRS8vNEljaWxNUWJ4K1dRTVd3VTVzbHJodXFuMHNsRlJo?= =?utf-8?B?MTRGTGZadlFNM2lOYkp3RW9Jc3BoQnBNMVdtVVBvaUVETTUxUVNTMUxUd1Qr?= =?utf-8?B?ZThLbjZ1dGp0K29vTzZhczRjYWo3aEpEVHRoSUJzMXQzOXNKcVZzSTJJWHMv?= =?utf-8?B?SlFFTk50QWd6eWdUUncrNHl3K3hXeG5xeFRnQnpZS3JyRzBBWnZ1UlVlbGFk?= =?utf-8?B?bGRJZ21TeHArdWhybE1LV3U2bnVHUThoYlU0N2o4Zzg3NXZBc2N1cytmNHVj?= =?utf-8?B?NGNEUlFSQmpnSVdkMnYxMVZJZUVEM0VFajNSeFMwTWlPdjNtdEVZTHpHdWd3?= =?utf-8?B?VWFpbGVUN0JrUnJUVWc5OEcwYjk3M21XZFd5TkIvNTdEeW5YOWY3c2hjMzh2?= =?utf-8?B?OW9XQ2xZQzgxb29PclhuNjJKcWQ0WlN4YXlETElwTmhiekVzbzF2Zll1WTcx?= =?utf-8?B?ZWRRUjJtMnZuTUxka0RUY0w2ZEdxVVM2eE5rVlRtUUVKWi9YSkRmTUN5eGdy?= =?utf-8?B?NTZZeVpIa2NOZ0pyelhDRDFxN2t2WTBKbXNXeVQ0eWlac1hwU1NoSGc0clAw?= =?utf-8?B?QURLbkhLOFR6WDRlNWxOd3FpbUQ3K0NYTXpnOFFYaWM2Y3JqbXNSNkJ3QVho?= =?utf-8?B?cTM5RVBUc0RHczVlZm9wb0pVVWI1UzNJcWQzOU5ncHZ3aXZkZ3R2ekxnM3lY?= =?utf-8?B?cmpMT1hvOUx0amdpd1phdzlid01XWEJPNFdMaFYvTVVIRWZhWXhmZ2F5VldB?= =?utf-8?B?cDVET1FHd1lwM0NKWktJc1dZcTFEZjZZVkdqM2hUbDVsRXpYMkUrTjgwd3ov?= =?utf-8?B?OFFBS0RPa3I4czRMTjJMb0VQN0JhbjE5REU4NEsySnBtS21OY29SR2JrTkRh?= =?utf-8?B?eTV6VXRpMVZqem1seTltaG1XeG1mZUxqanJkaXhZUFREQ3lBN3VaYXY4Z0x1?= =?utf-8?B?SEs0MlRvK2ZFQWlKRFVzVWlrU1JoUktvM3E0S0cweHk5YjhmLzJJSjFyOFNF?= =?utf-8?Q?1oTDH8VZ3tMk2quFWu36PIg=3D?= Content-ID: <2B40467350E869489982BC451B52DE6F@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69720b1e-3f9e-4730-7abc-08d9c6ba0a26 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2021 08:47:38.5125 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MS+I8wxaw0nLzvuNrdilomCSVsOD5gsmMHDE5545YQLVVmLit7DawRvcD9E5Ou/DMQxzP5wuJ6IYupEKYM63og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5291 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc_hevc: add -pic_timing_sei option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 2021-12-24 at 16:17 +0800, lance.lmwang@gmail.com wrote: > On Fri, Dec 24, 2021 at 07:35:25AM +0000, Xiang, Haihao wrote: > > On Fri, 2021-08-06 at 10:10 +0800, Haihao Xiang wrote: > > > The SDK may insert picture timing SEI for hevc and the code to set mfx > > > parameter has been added in qsvenc, however the corresponding option is > > > missing in the hevc option array > > > --- > > > libavcodec/qsvenc_hevc.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > > > index b7b2f5633e..1e31968673 100644 > > > --- a/libavcodec/qsvenc_hevc.c > > > +++ b/libavcodec/qsvenc_hevc.c > > > @@ -248,6 +248,7 @@ static const AVOption options[] = { > > > { "tile_rows", "Number of rows for tiled > > > encoding", OFFSET(qsv.tile_rows), AV_OPT_TYPE_INT, { .i64 = 0 }, > > > 0, > > > UINT16_MAX, VE }, > > > { "recovery_point_sei", "Insert recovery point SEI > > > messages", OFFSET(qsv.recovery_point_sei), AV_OPT_TYPE_INT, { > > > .i64 > > > = -1 }, -1, 1, VE }, > > > { "aud", "Insert the Access Unit Delimiter NAL", OFFSET(qsv.aud), > > > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE}, > > > + { "pic_timing_sei", "Insert picture timing SEI with > > > pic_struct_syntax > > > element", OFFSET(qsv.pic_timing_sei), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, > > > VE > > It's better to use AV_OPT_TYPE_BOOL if the option is used for on/off or > enable/disable. > Thanks for your comment. I'll change it to AV_OPT_TYPE_BOOL, > I think you need to add description in the doc for the new options if > possible. Currently there isn't a doc for qsv decoder, we'll try to add it later. Thanks Haihao > > > > }, > > > > > > { NULL }, > > > }; > > > > Will apply > > > > -Haihao > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".