From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C9D4C4AC55 for ; Wed, 17 Jul 2024 11:29:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3FFF968DAD9; Wed, 17 Jul 2024 14:29:18 +0300 (EEST) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6BC5E68DA73 for ; Wed, 17 Jul 2024 14:29:12 +0300 (EEST) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1fbc09ef46aso48932345ad.3 for ; Wed, 17 Jul 2024 04:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721215750; x=1721820550; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=HexAjS6sN7GvWrCfdH6cilSxpL1+UHzvn9A6VKHsU1A=; b=F6hIIJSkw7Ygthn3TF3yshlqwCppaHyqZ743lX0cZ661GHOz2bn/l507nPi9rux5mg miBZjiiWkQOCNxOge8zRas08KHpK8RhchhLcBNzFnwIBIu6yBctunJ/c9lhHmLUzaBwL EJnrj7AVCgLNHgs4b/HYjdL8CexqzEqHjg5g1Y0WN0/uvWJU4El/bdomQccGY6J/HTFp M4BQkmJCKyg/cQNntDE6heTqL3Y46Tl8/wzHDjR4F6EpsT7A39zOxlEi2SKUTUSdD/Pc uqSysCHSizZfMoI6cs6VPWbAkn1laCD6mwU1hhBZEaAKWvUkT/yZRXSc5KaKJaA/Ylcp EsxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721215750; x=1721820550; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HexAjS6sN7GvWrCfdH6cilSxpL1+UHzvn9A6VKHsU1A=; b=lM8eaNsjjlAT47727zEorEVVNNHopPrOzQP66+UusoJwtOtkHG9t2pqCvOlw3Cu9nw Y7lncAWvpO7ZARxQqcOFq82G8yzR2n3uEMnDLT1WLQtIqeAHtNI70Qvs2rkzHOw75Ton Y4g7xATUOPRhfhOtRbCdJTXFZSUt7bSca1kQU73W3pW4xpywAQ0YYxXeXO/Sf92q3I/w VuKo8jC4IXnd2KCQUJEKXvZsbELmH2fga6T2xqrp8vMWh+lyyhZzKVtZimPxwgAGGSKi AdwQdxYz9f9Tv7yb/bnspZ1kb8FzBN/NYYXqU6pUDhlFRqoNS7Fc3aXCffysSSkTd05P jixQ== X-Gm-Message-State: AOJu0YwL4Q72fsUId0Zke98np/+tireJzAO4LGR7SwFierOfr3Ybk0qW ajbTEpHVz08BQ6AqP1RywN3NT9WEt3deGgOzz4qCEmj1IL/4PqRPKZMHUA== X-Google-Smtp-Source: AGHT+IE/VrJ3cBUWkRgfML7RPmRUqN4PbaHj0zMhg/2mN0FkunLmuLJ5XN/c1rDqNPRmUwGNiBPMgg== X-Received: by 2002:a17:902:f14c:b0:1fb:824e:5643 with SMTP id d9443c01a7336-1fc4e56f6c3mr7879025ad.43.1721215749910; Wed, 17 Jul 2024 04:29:09 -0700 (PDT) Received: from [192.168.0.12] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fc0bc27183sm73482885ad.167.2024.07.17.04.29.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 04:29:09 -0700 (PDT) Message-ID: <88b73c55-8a7f-401b-9612-f332de06211d@gmail.com> Date: Wed, 17 Jul 2024 08:29:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240717014925.16517-1-jamrial@gmail.com> <172119708795.21847.6585401142014653610@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <172119708795.21847.6585401142014653610@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 1/4] avformat/movenc: fix channel count and samplerate fields for IAMF tracks X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/17/2024 3:18 AM, Anton Khirnov wrote: > Quoting James Almer (2024-07-17 03:49:22) >> diff --git a/libavformat/movenc.c b/libavformat/movenc.c >> index 2bea55e33d..5de188f4cf 100644 >> --- a/libavformat/movenc.c >> +++ b/libavformat/movenc.c >> @@ -1399,6 +1399,11 @@ static int mov_write_audio_tag(AVFormatContext *s, AVIOContext *pb, MOVMuxContex >> avio_wb16(pb, 16); >> avio_wb16(pb, track->audio_vbr ? -2 : 0); /* compression ID */ >> } else { /* reserved for mp4/3gp */ >> +#if CONFIG_IAMFENC >> + if (track->tag == MKTAG('i','a','m','f')) >> + avio_wb16(pb, 0); /* channelcount must be 0 for IAMF */ >> + else >> +#endif >> avio_wb16(pb, track->par->ch_layout.nb_channels); > > avio_wb16(pb, track->tag == MKTAG('i', 'a', 'm', 'f') ? > 0 : track->par->ch_layout.nb_channels); > > looks more readable to me Ok, changed locally. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".