From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AD3F045319 for ; Fri, 21 Apr 2023 12:27:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A6CF768BF6D; Fri, 21 Apr 2023 15:27:49 +0300 (EEST) Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3191568BE31 for ; Fri, 21 Apr 2023 15:27:43 +0300 (EEST) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-1842c7c2daaso687763fac.0 for ; Fri, 21 Apr 2023 05:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682080061; x=1684672061; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zmpJtjnTgz+UsjKZc6yChinzEkky1jm5tXbzlaZcgNY=; b=SWPQMNUfkuRFIBev8HAiOWvOu/NxNDe9MKQzGKytGFkSNJwoBsBy0vfjTVSIF2NX3P NlXfAGa7qJKPuxBYYLGIdnXxlcFg9s8fzECZuxOXhQazrFm0ycBayGtsSQGOZx4n5S13 ptlECx9gIePBrjVTt0q1s5GyONkTdVo4PPJoZdTY9g18EPGxPonSBv7JAQLthl2u+Eyg F2+L/4njicw9QkuyKbiJzInG9hiWoGlQesU8ye5oaW4670WAoj8tJsLVLvRzxbq0Vcyz 4Hknfuh16GzTM1IuwW+YN12Gk0knhkQAZYEW6FglHsUJZGe3kH0W36CRDQD19t1CnZYz IdLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682080061; x=1684672061; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zmpJtjnTgz+UsjKZc6yChinzEkky1jm5tXbzlaZcgNY=; b=ChQaD8kcRWnahPVNx5Q2P4Gmo3mdjfuVvjWZ4uzZlNZTUKLyrEq0Rjwd4X4JYAoATs RVK6T0VC2bJgtG/dbTS6Yidb/o3F3GaUssYOd67d6PELnaRbLscBHzxPSCLgX2llXlRO CMnoj7oyZbehMHuL3UcFogNOVWKwTAiiBCo6HcPEFpbq5WzTPtdLIuXfBT3PshJrd/33 Kb3G9awWjMDPxr8NKMGpBv0Po9RtXcEddmsf6Z3eBVNQ17Hcn+qndPIJDoxy7+Cp4t/i VO0HcqWjH3jK0BerWBoZe+XwUWJwCP0Z/LIKfkfJWLsBNBOvnn9gA6Joc9lFHMs2syb6 39rA== X-Gm-Message-State: AAQBX9fcbqURTrmO7dyGvN0ineEKCtzabbeB97b0ME0JNQ1i9dwoDW9J HUnOAllUymvdweEByZGh3gn/NnlRbYk= X-Google-Smtp-Source: AKy350by6174JJR5AGp09rccNSD/Lzcxh7GXe4Vvx8a1F3KK/ctYUaIvc61m5uxXJYhgqcPgXEFCOw== X-Received: by 2002:a05:6870:d390:b0:17f:7dca:8926 with SMTP id k16-20020a056870d39000b0017f7dca8926mr3674910oag.20.1682080061439; Fri, 21 Apr 2023 05:27:41 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id du15-20020a0568703a0f00b001728669a604sm1736580oab.5.2023.04.21.05.27.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 05:27:41 -0700 (PDT) Message-ID: <885d0c40-8df2-353f-2bb3-adb23820c196@gmail.com> Date: Fri, 21 Apr 2023 09:27:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20230417235937.11038-1-jamrial@gmail.com> In-Reply-To: <20230417235937.11038-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/pcm_rechunk_bsf: assert that in_pkt is empty after merging its data into out_pkt X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/17/2023 8:59 PM, James Almer wrote: > If it's not empty here, then a leak would ocurr immediately after. > > Signed-off-by: James Almer > --- > libavcodec/pcm_rechunk_bsf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/pcm_rechunk_bsf.c b/libavcodec/pcm_rechunk_bsf.c > index 032f914916..28b5722ac9 100644 > --- a/libavcodec/pcm_rechunk_bsf.c > +++ b/libavcodec/pcm_rechunk_bsf.c > @@ -139,6 +139,7 @@ static int rechunk_filter(AVBSFContext *ctx, AVPacket *pkt) > av_packet_move_ref(pkt, s->out_pkt); > return send_packet(s, nb_samples, pkt); > } > + av_assert0(!s->in_pkt->size); > } else if (s->in_pkt->size > data_size) { > ret = av_packet_ref(pkt, s->in_pkt); > if (ret < 0) Will apply. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".