Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avformat/dhav: Add missed free for end_buffer
@ 2025-06-06 13:44 Derek Buitenhuis
  2025-06-08 10:32 ` Derek Buitenhuis
  0 siblings, 1 reply; 2+ messages in thread
From: Derek Buitenhuis @ 2025-06-06 13:44 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: kasper93

Accidentally left out of 36ec9217e6dca3432304c9d76078d9618247eb0f.

Found-by: Kacper Michajłow <kasper93@gmail.com>
Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
---
 libavformat/dhav.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavformat/dhav.c b/libavformat/dhav.c
index d9db775802..5a83a8aea9 100644
--- a/libavformat/dhav.c
+++ b/libavformat/dhav.c
@@ -280,6 +280,7 @@ static int64_t get_duration(AVFormatContext *s)
     }
 
     if (end_pos < 0 || end_pos + 16 > end_buffer_pos + end_buffer_size) {
+        av_freep(&end_buffer);
         avio_seek(s->pb, start_pos, SEEK_SET);
         return 0;
     }
@@ -288,6 +289,8 @@ static int64_t get_duration(AVFormatContext *s)
     get_timeinfo(date, &timeinfo);
     end = av_timegm(&timeinfo) * 1000LL;
 
+    av_freep(&end_buffer);
+
     avio_seek(s->pb, start_pos, SEEK_SET);
 
     return end - start;
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [FFmpeg-devel] [PATCH] avformat/dhav: Add missed free for end_buffer
  2025-06-06 13:44 [FFmpeg-devel] [PATCH] avformat/dhav: Add missed free for end_buffer Derek Buitenhuis
@ 2025-06-08 10:32 ` Derek Buitenhuis
  0 siblings, 0 replies; 2+ messages in thread
From: Derek Buitenhuis @ 2025-06-08 10:32 UTC (permalink / raw)
  To: ffmpeg-devel

On 6/6/2025 2:44 PM, Derek Buitenhuis wrote:
> Accidentally left out of 36ec9217e6dca3432304c9d76078d9618247eb0f.
> 
> Found-by: Kacper Michajłow <kasper93@gmail.com>
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis@gmail.com>
> ---
>  libavformat/dhav.c | 3 +++
>  1 file changed, 3 insertions(+)

Will push later today.

- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-06-08 10:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-06 13:44 [FFmpeg-devel] [PATCH] avformat/dhav: Add missed free for end_buffer Derek Buitenhuis
2025-06-08 10:32 ` Derek Buitenhuis

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git