Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Baptiste Coudurier <baptiste.coudurier@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/3] avformat/movenc: fix writing reserved bits in EC3SpecificBox
Date: Thu, 5 Jun 2025 15:07:34 -0700
Message-ID: <882B6180-FF57-440F-9474-E246BC991D31@gmail.com> (raw)
In-Reply-To: <20250605214938.142938-2-jamrial@gmail.com>

Hi James

> On Jun 5, 2025, at 2:49 PM, James Almer <jamrial@gmail.com> wrote:
> 
> As described in section F.6.1 from ETSI TS 102 366.
> 
> Found-by: nyanmisaka
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavformat/movenc.c         | 2 +-
> tests/ref/fate/copy-trac3074 | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 402611e81e..25360b004d 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -631,7 +631,7 @@ static int mov_write_eac3_tag(AVFormatContext *s, AVIOContext *pb, MOVTrack *tra
>         put_bits(&pbc, 3, info->substream[i].bsmod);
>         put_bits(&pbc, 3, info->substream[i].acmod);
>         put_bits(&pbc, 1, info->substream[i].lfeon);
> -        put_bits(&pbc, 5, 0); /* reserved */
> +        put_bits(&pbc, 3, 0); /* reserved */
>         put_bits(&pbc, 4, info->substream[i].num_dep_sub);
>         if (!info->substream[i].num_dep_sub) {
>             put_bits(&pbc, 1, 0); /* reserved */
> diff --git a/tests/ref/fate/copy-trac3074 b/tests/ref/fate/copy-trac3074
> index 53ba27e920..9ed42c8d8d 100644
> --- a/tests/ref/fate/copy-trac3074
> +++ b/tests/ref/fate/copy-trac3074
> @@ -1,5 +1,5 @@
> -36fcc0a62695bcf93068fcfe68283ee9 *tests/data/fate/copy-trac3074.mp4
> -334016 tests/data/fate/copy-trac3074.mp4
> +5b4a3ed9de3b2a92e5dcb127bca12e68 *tests/data/fate/copy-trac3074.mp4
> +334015 tests/data/fate/copy-trac3074.mp4
> #tb 0: 1/48000
> #media_type 0: audio
> #codec_id 0: eac3

Yes, I actually just noticed that :)

— 
Baptiste
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-06-05 22:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-05 21:49 [FFmpeg-devel] [PATCH 1/3] avcodec/ac3_parser: handle more header bits in ff_ac3_parse_header() James Almer
2025-06-05 21:49 ` [FFmpeg-devel] [PATCH 2/3] avformat/movenc: fix writing reserved bits in EC3SpecificBox James Almer
2025-06-05 22:07   ` Baptiste Coudurier [this message]
2025-06-05 21:49 ` [FFmpeg-devel] [PATCH 3/3] avformat/movenc: handle EAC-3 extension bits for Atmos James Almer
2025-06-05 22:09   ` Baptiste Coudurier
2025-06-05 22:15 ` [FFmpeg-devel] [PATCH 1/3] avcodec/ac3_parser: handle more header bits in ff_ac3_parse_header() Baptiste Coudurier
2025-06-05 23:07 ` Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=882B6180-FF57-440F-9474-E246BC991D31@gmail.com \
    --to=baptiste.coudurier@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git