From: "J. Dekker" <jdek@itanimul.li>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] aarch64: ac3dsp: Simplify the end of ff_ac3_sum_square_butterfly_float_neon
Date: Tue, 09 Apr 2024 16:51:37 +0200
Message-ID: <87frvur3la.fsf@itanimul.li> (raw)
In-Reply-To: <20240408105705.99898-1-martin@martin.st>
Martin Storsjö <martin@martin.st> writes:
> Before: Cortex A53 A72 A78
> ac3_sum_square_bufferfly_float_neon: 1005.7 516.5 224.5
> After:
> ac3_sum_square_bufferfly_float_neon: 981.7 504.5 223.2
> ---
> libavcodec/aarch64/ac3dsp_neon.S | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/libavcodec/aarch64/ac3dsp_neon.S b/libavcodec/aarch64/ac3dsp_neon.S
> index 20beb6cc50..7e97cc39f7 100644
> --- a/libavcodec/aarch64/ac3dsp_neon.S
> +++ b/libavcodec/aarch64/ac3dsp_neon.S
> @@ -103,17 +103,9 @@ function ff_ac3_sum_square_butterfly_float_neon, export=1
> fmla v3.4s, v17.4s, v17.4s
> subs w3, w3, #4
> b.gt 1b
> - faddp v0.4s, v0.4s, v0.4s
> - faddp v0.2s, v0.2s, v0.2s
> - st1 {v0.s}[0], [x0], #4
> - faddp v1.4s, v1.4s, v1.4s
> - faddp v1.2s, v1.2s, v1.2s
> - st1 {v1.s}[0], [x0], #4
> - faddp v2.4s, v2.4s, v2.4s
> - faddp v2.2s, v2.2s, v2.2s
> - st1 {v2.s}[0], [x0], #4
> - faddp v3.4s, v3.4s, v3.4s
> - faddp v3.2s, v3.2s, v3.2s
> - st1 {v3.s}[0], [x0]
> + faddp v0.4s, v0.4s, v1.4s
> + faddp v2.4s, v2.4s, v3.4s
> + faddp v0.4s, v0.4s, v2.4s
> + st1 {v0.4s}, [x0]
> ret
> endfunc
Thanks, LGTM. Pushed with M1 benchmark on Linux.
--
jd
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-04-09 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 10:57 Martin Storsjö
2024-04-09 14:51 ` J. Dekker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frvur3la.fsf@itanimul.li \
--to=jdek@itanimul.li \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git