From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9FBF54959A for ; Tue, 13 Feb 2024 12:17:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4482768CCAE; Tue, 13 Feb 2024 14:17:14 +0200 (EET) Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0E97D68CB01 for ; Tue, 13 Feb 2024 14:17:08 +0200 (EET) Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-59d11e0b9e1so2571320eaf.1 for ; Tue, 13 Feb 2024 04:17:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707826625; x=1708431425; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=ifBNtNfRZ8yjd8Nqd7X2Ft6lO7VNgKePDirX/3FqaZ0=; b=JUx3kIF+VdiKqJr7gWmk5gprEU4R0fIKwNcFO/WqXI+j7li5rJMMXksL2SBNSxtSFR aSIZmhhTD53DwH3YSoAkhtvu5zz0ZPV5Gk6dOyJ+bqTHHCp8mWNPGpjJ48wnDpLXwHwD fUTvNrX0S+p542bKuH8wbGuIxThNrfKaO7gHYbogDk2jqU8TQ/azhUvem12zLp9xMmGv tw7TSyKFlKdiRkHmjDu+IgMjL2PrRrusUcg9rbWgCitgTihHR5QtRXklxJ7N3RSfXyM0 M131C4mihCHJThTxDhLh/An7RpJCygPWULuDEmHvHc5LGcEi3fzvKQwSJPd4qZLbxxKG Q7Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707826625; x=1708431425; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ifBNtNfRZ8yjd8Nqd7X2Ft6lO7VNgKePDirX/3FqaZ0=; b=O0LiwwzXbuJZ5tOpJwPH5FLcTDL30LeQKnuxeob6Sz/h17ShGvVQ3nteztrn2duYY2 O15htEdEBOOKgeuz297rFqjyILYTyjboyrhfUWmlANMs0J4EAXZsf/LXCfME1hZLq94q zdGF/9uNcqH+bHnG/dvBBlrix4TfBEzuuE7rI64jF+p43lngzjWmcSN3kHCOc2TbEBVM ruvzPcqFXMaxca+DarNgkjlvgN6OyRBGpD1fP0NHmuDYWCyM8H6eqkSgJaPLhGOQd4gY gNHMDJD1Tt6MtBbFY1RNRLKLirmOrkeBBzJi/jDt3Wh7E130sth0KSeQLaMoltV6+xjo ADIw== X-Gm-Message-State: AOJu0YxXD2cp903B08KBuGtSjN63fLKKVVdAWVjRZqWMy7Cpk2bWjbxq RHS+m3eLkv4WzxvMpA/3/QlwV54PrrXgFIdiOZledz20pJtFgHblRBuTb4hc X-Google-Smtp-Source: AGHT+IEv5f4r6yxHYfsTRoKM/6Ez1yKhIzvCUbOsDdybRSGrGP4l6T2hNmIy42IhHiupXmB+x/VenQ== X-Received: by 2002:a05:6358:840d:b0:178:b97c:f087 with SMTP id b13-20020a056358840d00b00178b97cf087mr14816086rwk.15.1707826625071; Tue, 13 Feb 2024 04:17:05 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id i126-20020a62c184000000b006dddad3589asm7591307pfg.195.2024.02.13.04.16.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Feb 2024 04:16:52 -0800 (PST) Message-ID: <87a3bd7b-f508-4f9d-aaac-7fcc1ef9b9ba@gmail.com> Date: Tue, 13 Feb 2024 09:16:54 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v4 2/2] lavc/vulkan_av1: port to the new stable API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/13/2024 9:10 AM, Lynne wrote: > Feb 13, 2024, 01:59 by ffmpeg-devel@ffmpeg.org: > >> On Sun Feb 11, 2024 at 10:15 AM EST, Lynne wrote: >> >>> From: Lynne >>> Date: Fri, 19 Jan 2024 10:49:02 +1000 >>> Subject: [PATCH v4 2/2] lavc/vulkan_av1: port to the new stable API >>> >>> Most of this patch was written by Dave Airlie , >>> with some additions by me. >>> --- >>> >>> >>> - ap->av1_pic_info = (VkVideoDecodeAV1PictureInfoMESA) { >>> - .sType = VK_STRUCTURE_TYPE_VIDEO_DECODE_AV1_PICTURE_INFO_MESA, >>> - .frame_header = &ap->av1_frame_header, >>> - .tile_list = &ap->tile_list, >>> + ap->av1_pic_info = (VkVideoDecodeAV1PictureInfoKHR) { >>> + .sType = VK_STRUCTURE_TYPE_VIDEO_DECODE_AV1_PICTURE_INFO_KHR, >>> + .pStdPictureInfo = &ap->std_pic_info, >>> + .tileCount = ap->tile_count, >>> + .pTileOffsets = ap->tile_offsets, >>> >> >> Mentioned this on IRC earlier, but this means the driver always get >> pTileOffsets = NULL, since ap->tile_offsets only gets filled out during >> vk_av1_decode_slice(). >> > > Thanks, already fixed it, I did report back on IRC. > > >>> + >>> + ap->loop_restoration = (StdVideoAV1LoopRestoration) { >>> + .FrameRestorationType[0] = remap_lr_type[frame_header->lr_type[0]], >>> + .FrameRestorationType[1] = remap_lr_type[frame_header->lr_type[1]], >>> + .FrameRestorationType[2] = remap_lr_type[frame_header->lr_type[2]], >>> + .LoopRestorationSize[0] = AV1_RESTORATION_TILESIZE_MAX >> (2 - frame_header->lr_unit_shift), >>> + .LoopRestorationSize[1] = ap->loop_restoration.LoopRestorationSize[0] >> frame_header->lr_uv_shift, >>> + .LoopRestorationSize[2] = ap->loop_restoration.LoopRestorationSize[0] >> frame_header->lr_uv_shift, >>> + }; >>> >> >> Not sure what the C spec says, but at least on GCC 13.2.1 it seems like >> the assignment for LoopRestorationSize[1] and [2] happens before the >> initalization of LoopRestorationSize[0]. >> > > Nothing here on gcc-12, gcc-14 and clang-19. If some compilers break with it, then it needs to be changed. So make it: > ap->loop_restoration = (StdVideoAV1LoopRestoration) { > .FrameRestorationType[0] = remap_lr_type[frame_header->lr_type[0]], > .FrameRestorationType[1] = remap_lr_type[frame_header->lr_type[1]], > .FrameRestorationType[2] = remap_lr_type[frame_header->lr_type[2]], > .LoopRestorationSize[0] = AV1_RESTORATION_TILESIZE_MAX >> (2 - frame_header->lr_unit_shift), > }; > ap->loop_restoration.LoopRestorationSize[1] = > ap->loop_restoration.LoopRestorationSize[2] = ap->loop_restoration.LoopRestorationSize[0] >> frame_header->lr_uv_shift, _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".