From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] swscale/x86/input: add AVX2 optimized RGB24 to YUV functions
Date: Tue, 4 Jun 2024 16:37:36 -0300
Message-ID: <876497f3-da0d-49b2-b307-717a2d21d5a2@gmail.com> (raw)
In-Reply-To: <GV1P250MB07376D15D1450C88BEFE69198FF82@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>
On 6/4/2024 4:32 PM, Andreas Rheinhardt wrote:
> James Almer:
>> On 6/4/2024 4:25 PM, Andreas Rheinhardt wrote:
>>> James Almer:
>>>> rgb24_to_uv_8_c: 39.3
>>>> rgb24_to_uv_8_sse2: 14.3
>>>> rgb24_to_uv_8_ssse3: 13.3
>>>> rgb24_to_uv_8_avx: 12.8
>>>> rgb24_to_uv_8_avx2: 14.3
>>>
>>> Worse than avx and ssse3
>>
>> Can't be disabled for small sizes.
>>
>
> Why can't this be disabled?
The function pointer is for all sizes. And adding a check + jmp in the
assembly is not going to be better. Also, this being for 8 pixel wide
buffers, it's not going to be anyone's bottleneck.
>
>>>
>>>> rgb24_to_uv_128_c: 582.8
>>>> rgb24_to_uv_128_sse2: 127.3
>>>> rgb24_to_uv_128_ssse3: 107.3
>>>> rgb24_to_uv_128_avx: 111.3
>>>
>>> Worse than ssse3
>>
>> I know, but it's not related to this patch.
>> Same for all the comments below.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-04 19:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 19:07 James Almer
2024-06-04 19:25 ` Andreas Rheinhardt
2024-06-04 19:30 ` James Almer
2024-06-04 19:32 ` Andreas Rheinhardt
2024-06-04 19:37 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876497f3-da0d-49b2-b307-717a2d21d5a2@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git