From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 83F994DA18
for <ffmpegdev@gitmailbox.com>; Mon, 21 Apr 2025 19:34:28 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C718F687DDD;
Mon, 21 Apr 2025 22:34:22 +0300 (EEST)
Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F5AF687AEB
for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 22:34:14 +0300 (EEST)
Received: from localhost (localhost [127.0.0.1])
by iq.passwd.hu (Postfix) with ESMTP id 16F9BEC9D0
for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 21:31:32 +0200 (CEST)
X-Virus-Scanned: amavisd-new at passwd.hu
Received: from iq.passwd.hu ([127.0.0.1])
by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024)
with ESMTP id rFC_VGqYI__o for <ffmpeg-devel@ffmpeg.org>;
Mon, 21 Apr 2025 21:31:30 +0200 (CEST)
Received: from iq (iq [217.27.212.140])
by iq.passwd.hu (Postfix) with ESMTPS id 36518EC9CB
for <ffmpeg-devel@ffmpeg.org>; Mon, 21 Apr 2025 21:31:30 +0200 (CEST)
Date: Mon, 21 Apr 2025 21:31:30 +0200 (CEST)
From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <DM8P223MB0365F6CE5ADDBFBD31C13CEFBAB82@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
Message-ID: <876061f7-1b81-1d4c-6dbc-51ac2119e2f3@passwd.hu>
References: <pull.72.ffstaging.FFmpeg.1745179871512.ffmpegagent@gmail.com>
<af9371b0-8684-404f-8bde-33e4dcaec555@gyani.pro>
<DM8P223MB0365F6CE5ADDBFBD31C13CEFBAB82@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of
stream start offsets
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/876061f7-1b81-1d4c-6dbc-51ac2119e2f3@passwd.hu/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On Mon, 21 Apr 2025, softworkz . wrote:
>
>
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of Gyan
>> Doshi
>> Sent: Montag, 21. April 2025 06:51
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH] avformat/dump: Change precision of
>> stream start offsets
>>
>>
>>
>> On 2025-04-21 01:41 am, softworkz wrote:
>>> From: softworkz <softworkz@hotmail.com>
>>>
>>> Changing this to 6 digits to align with other
>>> printed times
>>>
>>> Signed-off-by: softworkz <softworkz@hotmail.com>
>>> ---
>>> avformat/dump: Change precision of stream start offsets
>>>
>>> Changing this to 6 digits to align with other printed times
>>>
>>> Signed-off-by: softworkz softworkz@hotmail.com
>>>
>>> Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-
>> ffstaging-72%2Fsoftworkz%2Fsubmit_start_offsets-v1
>>> Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-
>> ffstaging-72/softworkz/submit_start_offsets-v1
>>> Pull-Request: https://github.com/ffstaging/FFmpeg/pull/72
>>>
>>> libavformat/dump.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavformat/dump.c b/libavformat/dump.c
>>> index 8c7db7b275..1bd0424f3d 100644
>>> --- a/libavformat/dump.c
>>> +++ b/libavformat/dump.c
>>> @@ -680,7 +680,7 @@ FF_ENABLE_DEPRECATION_WARNINGS
>>>
>>> if (st->start_time != AV_NOPTS_VALUE && st->start_time != 0 &&
>> st->time_base.den && st->time_base.num) {
>>> const double stream_start = av_q2d(st->time_base) * st-
>>> start_time;
>>> - av_log(NULL, AV_LOG_INFO, ", Start-Time %.3fs",
>> stream_start);
>>> + av_log(NULL, AV_LOG_INFO, ", Start-Time %.6fs",
>> stream_start);
>>
>> The camel case is incongruous with the formatting of the text next To
>> It.
>
> Hi Gyan,
>
> as far as I'm seeing it, captions/labels are title case and values are
> lower case. I would consider "Start-Time" to be a caption/label. Let's
> look at an example:
>
> Stream #0:0[0x8fd]: Video: h264 (High) ([27][0][0][0] / 0x001B), yuv420p(tv, bt709, top first), 1920x1080 [SAR 1:1 DAR 16:9], Level 40, 25 fps, 50 tbr, 90k tbn, Start-Time 32476.588s
> Stream #0:1[0x907](dut): Audio: mp2 ([3][0][0][0] / 0x0003), 48000 Hz, stereo, fltp, 256 kb/s, Start-Time 32476.706s
> Stream #0:2[0x908](dut): Audio: ac3 (AC-3 / 0x332D4341), 48000 Hz, 5.1(side), fltp, 448 kb/s, Start-Time 32476.643s
> Stream #0:3[0x909](GOS): Audio: mp2 ([3][0][0][0] / 0x0003), 48000 Hz, stereo, fltp, 256 kb/s, Start-Time 32476.674s (visual impaired) (descriptions)
> Stream #0:4[0x962](dut): Subtitle: dvb_subtitle ([6][0][0][0] / 0x0006), Start-Time 32476.588s
> Stream #0:5[0x963](dut): Subtitle: dvb_subtitle ([6][0][0][0] / 0x0006), Start-Time 32476.719s (hearing impaired)
I think Gyan means fps, tbr or tbn. These are all lowercase and
abbreviations. The one-line stream info should be as compact as possible.
So we should make it shorter, and we should lose the "s" unit as
well. Something like:
"in 1234.567"
IMHO that would fit better to the existing concept.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".