From: "J. Dekker" <jdek@itanimul.li>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock
Date: Sat, 24 Feb 2024 19:32:45 +0100
Message-ID: <874jdxk7k8.fsf@itanimul.li> (raw)
In-Reply-To: <2bdf433-abe-4048-4de2-96d53a267c60@martin.st>
Martin Storsjö <martin@martin.st> writes:
> [...]
>
> Are you sure the input is within valid range? It's always possible that
> checkasm produces inputs that the real decoder wouldn't - but it's also
> possible that this is a real decoder bug that just hasn't been triggered by any
> other test yet.
>
> // Martin
The checkasm was just written to just to trigger all the theoretical
edgecases. I know there is a decent range of values which pass the d0 +
d3 < beta check and overflow in (9 * (q0 - p0) - 3 * (q1 - p1) + 8) for
int16_t. I'm not 100% sure that these values can be output by the
decoder, and even if so they're rare.
--
jd
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-24 19:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 11:10 [FFmpeg-devel] [PATCH 1/3] checkasm/hevc_deblock: add luma and chroma full J. Dekker
2024-02-21 11:10 ` [FFmpeg-devel] [PATCH 2/3] avcodec/x86: disable hevc 12b luma deblock J. Dekker
2024-02-23 3:14 ` Andreas Rheinhardt
2024-02-24 9:54 ` J. Dekker
2024-02-23 12:45 ` Nuo Mi
2024-02-24 9:49 ` J. Dekker
2024-02-24 10:46 ` Martin Storsjö
2024-02-24 18:32 ` J. Dekker [this message]
2024-02-21 11:10 ` [FFmpeg-devel] [PATCH 3/3] avcodec/aarch64: add hevc deblock NEON J. Dekker
2024-02-21 12:08 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jdxk7k8.fsf@itanimul.li \
--to=jdek@itanimul.li \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git