Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/qsvvpp: remove usage of deprecated fields
Date: Sat, 29 Jul 2023 09:43:02 +0000
Message-ID: <86dd4edbc87841826b2c363bbd373e67db306c9d.camel@intel.com> (raw)
In-Reply-To: <20230729033538.1731-1-jamrial@gmail.com>

On Sa, 2023-07-29 at 00:35 -0300, James Almer wrote:
> Added by mistake in 88b3841149b9f41d6c5ec7930dcd5c6caf28b198.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavfilter/qsvvpp.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c
> index a03de05d9c..2833703891 100644
> --- a/libavfilter/qsvvpp.c
> +++ b/libavfilter/qsvvpp.c
> @@ -540,14 +540,19 @@ static QSVFrame *query_frame(QSVVPPContext *s,
> AVFilterLink *outlink, const AVFr
>          mfxExtBuffer *extbuf = s->vpp_param.ExtParam[i];
>  
>          if (extbuf->BufferId == MFX_EXTBUFF_VPP_DEINTERLACING) {
> +#if FF_API_INTERLACED_FRAME
> +FF_DISABLE_DEPRECATION_WARNINGS
>              out_frame->frame->interlaced_frame = 0;
> +FF_ENABLE_DEPRECATION_WARNINGS
> +#endif
> +            out_frame->frame->flags &= ~AV_FRAME_FLAG_INTERLACED;
>              break;
>          }
>      }
>  
>      out_frame->surface.Info.PicStruct =
> -        !out_frame->frame->interlaced_frame ? MFX_PICSTRUCT_PROGRESSIVE :
> -        (out_frame->frame->top_field_first ? MFX_PICSTRUCT_FIELD_TFF :
> +        !(out_frame->frame->flags & AV_FRAME_FLAG_INTERLACED) ?
> MFX_PICSTRUCT_PROGRESSIVE :
> +        ((out_frame->frame->flags & AV_FRAME_FLAG_TOP_FIELD_FIRST) ?
> MFX_PICSTRUCT_FIELD_TFF :
>           MFX_PICSTRUCT_FIELD_BFF);
>  
>      return out_frame;

LGTM, thanks for fixing this!

- Haihao
 

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-07-29  9:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-29  3:35 James Almer
2023-07-29  9:43 ` Xiang, Haihao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86dd4edbc87841826b2c363bbd373e67db306c9d.camel@intel.com \
    --to=haihao.xiang-at-intel.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git