From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0069845172 for ; Thu, 9 Feb 2023 16:14:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 68DB968BE7D; Thu, 9 Feb 2023 18:14:46 +0200 (EET) Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F55868BA48 for ; Thu, 9 Feb 2023 18:14:40 +0200 (EET) Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4PCMQ56FDMz9sWp for ; Thu, 9 Feb 2023 17:14:37 +0100 (CET) Message-ID: <86be93dc-464e-ab10-c1bd-c225f43c7dbf@gyani.pro> Date: Thu, 9 Feb 2023 21:44:23 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230202160708.29461-1-ffmpeg@gyani.pro> <20230202160708.29461-2-ffmpeg@gyani.pro> <6a0bb352-0971-42a4-8f34-8637dda46ccc@gyani.pro> <167559347438.1179.9555381791681889990@lain.khirnov.net> <167595755517.10789.7873391517950427481@lain.khirnov.net> From: Gyan Doshi In-Reply-To: <167595755517.10789.7873391517950427481@lain.khirnov.net> X-Rspamd-Queue-Id: 4PCMQ56FDMz9sWp Subject: Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/flvenc: add option to read metadata from file X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-02-09 09:15 pm, Anton Khirnov wrote: > Quoting Gyan Doshi (2023-02-05 12:05:19) >> >> On 2023-02-05 04:07 pm, Anton Khirnov wrote: >>> Quoting Gyan Doshi (2023-02-04 11:11:12) >>>> On 2023-02-03 09:04 pm, Andreas Rheinhardt wrote: >>>>> What does this achieve that can't be achieved by other means (namely by >>>>> an API-user updating the relevant metadata dictionaries)? >>>> This option together with meta_period is for CLI users. >>> Options for CLI users should be in the CLI, not the libraries. >> Do I then add and use a AVFMT flag to avoid recurring metadata updates >> for all other muxers? > I don't follow, why should there be a lavf flag for an ffmpeg CLI > option? The meta period option will control how frequently the metadata file is read and the muxer ctx dict updated in ffttools write_packet. Only one muxer - flvenc - can be triggered to recheck the dict in its .write_packet, so it seems wasteful to carry out those ops generally. The AVFMT flag can guard that. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".