Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2 7/7] swscale/input: add rgbaf16 input support
Date: Sun, 14 Aug 2022 19:15:34 -0400
Message-ID: <86bac914-e467-7720-3c94-e5c5b05e08a4@gmail.com> (raw)
In-Reply-To: <20220814164833.19965-7-timo@rothenpieler.org>

On 8/14/22 12:48, Timo Rothenpieler wrote:
> This is by no means perfect, since at least ddagrab will return scRGB
> data with values outside of 0.0f to 1.0f for HDR values.
> Its primary purpose is to be able to work with the format at all.
> ---
>   libavutil/Makefile            |   1 +
>   libswscale/half2float.c       |  19 +++++
>   libswscale/input.c            | 130 ++++++++++++++++++++++++++++++++++
>   libswscale/slice.c            |   9 ++-
>   libswscale/swscale_internal.h |  10 +++
>   libswscale/utils.c            |   2 +
>   libswscale/version.h          |   2 +-
>   7 files changed, 171 insertions(+), 2 deletions(-)
>   create mode 100644 libswscale/half2float.c
> 
> diff --git a/libavutil/Makefile b/libavutil/Makefile
> index 3d9c07aea8..1aac1a4cc0 100644
> --- a/libavutil/Makefile
> +++ b/libavutil/Makefile
> @@ -131,6 +131,7 @@ OBJS = adler32.o                                                        \
>          float_dsp.o                                                      \
>          fixed_dsp.o                                                      \
>          frame.o                                                          \
> +       half2float.o                                                     \
>          hash.o                                                           \
>          hdr_dynamic_metadata.o                                           \
>          hdr_dynamic_vivid_metadata.o                                     \

This .o Makefile addition appears in patch 7/7, but the actual creation 
of the .c file is in patch 4/7. Is this intentional? Because if it is, I 
am a bit confused.

- Leo Izen (thebombzen)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-08-14 23:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-14 16:48 [FFmpeg-devel] [PATCH v2 1/7] avutil: move half-precision float helper to avutil Timo Rothenpieler
2022-08-14 16:48 ` [FFmpeg-devel] [PATCH v2 2/7] avutil/half2float: adjust conversion of NaN Timo Rothenpieler
2022-08-18  8:51   ` Tomas Härdin
2022-08-14 16:48 ` [FFmpeg-devel] [PATCH v2 3/7] avutil/half2float: move tables to header-internal structs Timo Rothenpieler
2022-08-14 16:48 ` [FFmpeg-devel] [PATCH v2 4/7] avutil/half2float: move non-inline init code out of header Timo Rothenpieler
2022-08-14 16:48 ` [FFmpeg-devel] [PATCH v2 5/7] avutil/half2float: use native _Float16 if available Timo Rothenpieler
2022-08-14 16:48 ` [FFmpeg-devel] [PATCH v2 6/7] swscale: add opaque parameter to input functions Timo Rothenpieler
2022-08-14 16:48 ` [FFmpeg-devel] [PATCH v2 7/7] swscale/input: add rgbaf16 input support Timo Rothenpieler
2022-08-14 23:15   ` Leo Izen [this message]
2022-08-15  4:15     ` Andreas Rheinhardt
2022-08-18 15:37 ` [FFmpeg-devel] [PATCH v2 1/7] avutil: move half-precision float helper to avutil Timo Rothenpieler
2022-08-19 21:21   ` Timo Rothenpieler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bac914-e467-7720-3c94-e5c5b05e08a4@gmail.com \
    --to=leo.izen@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git