From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 18A794C360 for <ffmpegdev@gitmailbox.com>; Thu, 8 May 2025 10:23:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D9C9468C237; Thu, 8 May 2025 13:23:11 +0300 (EEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A2D2D68C1EC for <ffmpeg-devel@ffmpeg.org>; Thu, 8 May 2025 13:22:53 +0300 (EEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-22e09f57ed4so20973985ad.0 for <ffmpeg-devel@ffmpeg.org>; Thu, 08 May 2025 03:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746699772; x=1747304572; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=kTQqpKwW4/Zir//ii6adlinIuaQ8lRLZTAQ681MqjxM=; b=hGiScU3iZxQuhWJvov04tr/jGa0Geg4dItN7d122b/ztSL26MX2NTNWYF+dJpPJkbJ weEH0CwTYypmxnmAHjglVNGXlHD/emDvKu03dlQXt36UGvY6GO8Ij60mhLdhDGb+GTB0 efIHfrEBKkMkFKQDEDvSh5xZ9ZsnLYmZYyppvd7Q3dsUTvoeLLmPr4pWMLMUHceN2Msf hpMr79Jk4UyEobGaC8Ji4dTj+R5xp+z/mRXL8lcSkrZr2ac/lggQu1iNRoZzqFK+SNvA ZqhXnI02ONBfHhrn6cFJhYCqXzHh4khmevjArZ1/OHV45g4xAJkQDfAhadUZsy8TcRlN mCqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746699772; x=1747304572; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kTQqpKwW4/Zir//ii6adlinIuaQ8lRLZTAQ681MqjxM=; b=XuVXSl7EhYu3N14sEfc9BcsDAZnlIORUIEc/PGkz8x3RlwGi9pwib3+ukfc2ZCQp9D ty3oV170D7os1b0VoVlDJvj2A/CF1dWGvkVqrKFrpR2hNqexWrUCm10s/3wLFyyeKWu+ zgotjlaQeVqsF2ECM76UZ3697RA3HMHecJmG4pczJ2uqrSRhNkZXbaoJT2QTCMg1t+F+ PqCFJZyX0lobouyu3IWtJrqQSSSG8Vy96lyEOCS9LHBvzlYqP8sz6BpMAzkFpDy6eu0H qdPAKKXcRoPb2T4yh2VIY70QylLKugQoIiHkvD/foAgG8BQ+AvIxBR6uVME1UDKE03lG Ka7g== X-Gm-Message-State: AOJu0Yw0JkuY168dwd/7J6aHjG7Brw/c56h2BdUUOQc+EdE2Hr1aaKNM oXg3IvJTyeAkd/Lnv7XC0zSe7PKCKhGxF6EGNrToSg170dQjnSyIu9uWIg== X-Gm-Gg: ASbGncsbG9LZ8TGKIrEv7O6BqYF0Gas77/24S2oqvtIFxWQSNKokffmYM0y8VkVbJUK dlQIKX/7L1ZqvtKpU1ryu8a8REgCPph46FEgow0IPhcFoolDnHbMu+e9PT7jJPTX+VSlPaM88Gh Joc/RivQLzqN9qDVxWoVLyukqORC21GQVJpFdQq9BVmwTIwNvButTBByzkfBMPsUxvMW06xOvGf 0/J5xFxP2JdWXJEvxRtpf7AvCKHTJ2ucSARIg3taRmOjEeLNDoLoup8NwME7ud8lxPpMsofQq9e Qrl9oORW/0cuFLygRbixrrB/KIKQH1cjxvCscTaX2bud+9g3GhhjL/HQjvU= X-Google-Smtp-Source: AGHT+IFQWPwFkwCxvSlZpPb6ZRVDRwtIXJuVFnYb7BvUEYnlR5x/MGI++lLzHJqNEYw4DvMH3guzfQ== X-Received: by 2002:a17:903:2115:b0:221:89e6:ccb6 with SMTP id d9443c01a7336-22e8478fc3dmr32494775ad.25.1746699771785; Thu, 08 May 2025 03:22:51 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22e1522f84dsm109044665ad.231.2025.05.08.03.22.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 May 2025 03:22:51 -0700 (PDT) From: softworkz <ffmpegagent@gmail.com> X-Google-Original-From: softworkz <softworkz@hotmail.com> Message-Id: <866fd3aa3bde0d6e6bbdf1bee98b52ac6aef7f35.1746699749.git.ffmpegagent@gmail.com> In-Reply-To: <pull.76.ffstaging.FFmpeg.1746699749.ffmpegagent@gmail.com> References: <pull.76.ffstaging.FFmpeg.1746699749.ffmpegagent@gmail.com> Date: Thu, 08 May 2025 10:22:27 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 3/5] doc/developer: Reorder Submission procedures content X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Cc: softworkz <softworkz@hotmail.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/866fd3aa3bde0d6e6bbdf1bee98b52ac6aef7f35.1746699749.git.ffmpegagent@gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> From: softworkz <softworkz@hotmail.com> Signed-off-by: softworkz <softworkz@hotmail.com> --- doc/developer.texi | 48 ++++++++++++++++++++++++---------------------- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/doc/developer.texi b/doc/developer.texi index a723d41f39..5a026fff0e 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -752,10 +752,7 @@ We think our rules are not too hard. If you have comments, contact us. First, read the @ref{Coding Rules} above if you did not yet, in particular the rules regarding patch submission. -When you submit your patch, please use @code{git format-patch} or -@code{git send-email}. We cannot read other diffs :-). - -Also please do not submit a patch which contains several unrelated changes. +Please do not submit a patch which contains several unrelated changes. Split it into separate, self-contained pieces. This does not mean splitting file by file. Instead, make the patch as small as possible while still keeping it as a logical unit that contains an individual change, even @@ -768,13 +765,6 @@ The tool is located in the tools directory. Run the @ref{Regression tests} before submitting a patch in order to verify it does not cause unexpected problems. -It also helps quite a bit if you tell us what the patch does (for example -'replaces lrint by lrintf'), and why (for example '*BSD isn't C99 compliant -and has no lrint()') - -Also please if you send several patches, send each patch as a separate mail, -do not attach several unrelated patches to the same mail. - @section Patch submission checklist @@ -892,23 +882,35 @@ of leaks, out of array accesses, etc. Patches should be posted to the @uref{https://lists.ffmpeg.org/mailman/listinfo/ffmpeg-devel, ffmpeg-devel} -mailing list. Use @code{git send-email} when possible since it will properly -send patches without requiring extra care. If you cannot, then send patches -as base64-encoded attachments, so your patch is not trashed during -transmission. Also ensure the correct mime type is used -(text/x-diff or text/x-patch or at least text/plain) and that only one -patch is inline or attached per mail. -You can check @url{https://patchwork.ffmpeg.org}, if your patch does not show up, its mime type -likely was wrong. +mailing list. + +There are several ways how this can be accomplished: -@subheading How to setup git send-email? +@subsection Using @code{git send-email}: Git sends e-mail directly via SMTP + +@code{git send-email} will properly format and send +send patches without requiring extra care if the required setup is feasible. Please see @url{https://git-send-email.io/}. + For gmail additionally see @url{https://shallowsky.com/blog/tech/email/gmail-app-passwds.html}. -@subheading Sending patches from email clients -Using @code{git send-email} might not be desirable for everyone. The -following trick allows to send patches via email clients in a safe + +@subsection With @code{git format-patch}: Sending patches from email clients + +You can create patch files via @code{git format-patch} and send them as inline +text or as base64-encoded attachments, so your patch is not trashed during +transmission. Also ensure the correct mime type is used +(text/x-diff or text/x-patch or at least text/plain). + +If you send several patches, send each patch as a separate mail, +do not attach several unrelated patches to the same mail. + +You can check @url{https://patchwork.ffmpeg.org}, if your patch does not show up, its mime type +likely was wrong. + + +The following trick allows to send patches via email clients in a safe way. It has been tested with Outlook and Thunderbird (with X-Unsent extension) and might work with other applications. -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".