From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A55774A3D8 for ; Wed, 27 Mar 2024 13:04:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3231968CEBC; Wed, 27 Mar 2024 15:04:41 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2110.outbound.protection.outlook.com [40.107.20.110]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 16CB868CC33 for ; Wed, 27 Mar 2024 15:04:35 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oP6Kt08lwKrWFRYlqIamnp4w1hsPNLCxOSR0Glhh3GwrjgoKH3QBTODEMeaAdgTyQZJhFbMP2+9uBpGE5a5198LwM4lOQAk/srS93iIb6ZfwCfZ9naWm0CIkHDLTFnvqITrvROFbScOqnnCwYwvgntPXBeWjYFItvrW3KzmyQl+Wd/ke5hy6kUClpS3b+FBX9eRKylOUXAsyndF8IMqs55Ye/akTgJg5iOaa/MNVEnLqyQR4AqaxxA//WU9025IGGxJ6bDyjchdejAIKCGx2cfTZW7TwZ41lQU2ET5CdU7AKqNfZIHadtJf8AjNpNObCRXvlkPMQHH6iL2GpW+mzbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KSaxUqNQIEep2JBTNg0yfsD6n6zVG4Zf8RrrOcXTsW0=; b=fW4M/OkdJzZnlW72zhfTgnA+WL1Zmim4zW0re5yrFrRMdHHwSat5o44H8qfy0IeAWV/hFbJCBgIF70xdwFw/FRGfu/Nrki4lGFl5L9OhANkVXoBceKeDkHbUhmPlKHw3pmumCXt1JWFZml3ciz2l+YsmOWeTy/ph33D5GDwj92mCj0k48kPzHyEJcAHTkXF+C3kbbh57Ihw+tHoihRnbUBz3YTGCGf6dqG5CYtFuLzGZnpgvuwR35cv4EB022xAF/okqjQ5tbKKvLNzknzjh7rp9zKazPdHgdzHUQnx6ci+dna7bYfBzd+VVdrXqMN2Xw2qNesvsB4DO92nHYwn0Tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=noa-archive.com; dmarc=pass action=none header.from=noa-archive.com; dkim=pass header.d=noa-archive.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=noa-archive.com; Received: from DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) by AM7PR09MB4135.eurprd09.prod.outlook.com (2603:10a6:20b:118::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Wed, 27 Mar 2024 13:04:32 +0000 Received: from DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::2a3e:8641:1f40:c79]) by DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::2a3e:8641:1f40:c79%5]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 13:04:32 +0000 Message-ID: <860afbba-c394-4340-a011-8ea8084d32ad@noa-archive.com> Date: Wed, 27 Mar 2024 14:04:30 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <1711536691-15749-1-git-send-email-t.rapp@noa-archive.com> <1711536691-15749-2-git-send-email-t.rapp@noa-archive.com> <91da0313-e4c4-46e7-9379-30306ee3f0ca@noa-archive.com> <171154399229.7287.1645038161790058856@lain.khirnov.net> Content-Language: en-US From: Tobias Rapp Organization: NOA GmbH In-Reply-To: <171154399229.7287.1645038161790058856@lain.khirnov.net> X-ClientProxiedBy: FR0P281CA0123.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::9) To DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB4PR09MB5847:EE_|AM7PR09MB4135:EE_ X-MS-Office365-Filtering-Correlation-Id: 56efcff3-de96-41a5-a764-08dc4e5e71e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8RUagQzXP7w8T4XmN8FJ47mXAECkC00bjb0Nyr/WXZBizPQqORlW4G+S6cIZVAh4ljLPIOcE913mg1i75gPEUdHNVvfIyg0WJumb81H+yTv9k1tnsjWmy7QvYdS7zk/f6z9qUwLsHet+QcSCksWKLflsLA5H7WcJv0w4ADH+uegyutcHW7dIzXSTEu6gfoEXnxVMmmUYUWLwT8xpyNTy97ZQvLKzUrP5UgNuGpWgKwAqHSmygaWjZ0yP7BZEV5V5E+UuZcpuBpL8xo9y8XXAie3W5wUJGDSLQ4TmIv8BGfm+B5fZqMVCfHn0v1o4Js3XJ/Fgqtfp/1HkoQCgi05+YvOBdnihyYajN0J98cJ5rsK0hduQ/ECjsqiEGfWmfFCzwPhlxifCMupi4SkMZAfEmIFohkzINcO6uXHpDonLoiu5V+Dc8/4XLDh9x2c5DuNRQeiaSIygFC43hOR56if0Zq1xk2xMU0G9KIGsNHpIr9bvWzvThT2/A4dg7euhNccfENSV+a9d10EZ9uEkh+oE++iol+Ds9lqt0e092b+fpXJeFSW0CpjDzAix43hyLYfBM1jGHX4S/he9ZeThQIiSUiVxzPcqN8tShEXKG82C9jE4xXdpxbR5AnfjLR2T8dj1xa44AcZoA7Lp73ywAM1b5vaoi7c3ULoB+yt/mlC+zIA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB4PR09MB5847.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clpwOEV4WC84eCtGeTk2b2hQdGE5dStGRFpQeS92ZVFpaHRmZndjMTRoeTRP?= =?utf-8?B?cEVySUdzQnRSc01YU0F5dnhRT25XODlKc05Vd1FNaXFxMEU1aHFiOFMyMkpy?= =?utf-8?B?V0p5bzg3c2Ridnd4MGd1WGpLbVZrV1ozVytvTkhtS2E4WWJwaTR0Z2EzNG12?= =?utf-8?B?NXBHdGtaRFRYbk82SWlOUU9UOEdvRHV3MTZBNG5rMVlkVW9mdDZ3SUdBUTA2?= =?utf-8?B?WUhUcUtjWC9WNzNoUDdzbWZWYWZQenNRTHdPSHkvOW4vaFIyQlJXdjlQYkp5?= =?utf-8?B?dy9XdG1zelNEN0hKeEc5bGRkUW9TSWs1YjBxRzl1T2N1Y2E2QktXU1BaMGw2?= =?utf-8?B?MzdrZmFMWGZZL0JRWG5ZNkVHemljazdxNngzWkcwdHkxeVVqT0RoMHp6TGZP?= =?utf-8?B?alQ5R2FRWkRoS2Nvc0lIYlFxVTZaU1lnY3RZVStGRC9FeDlEb01vSmVXNzAr?= =?utf-8?B?SnFXN2FIb25xQlBqVFdXbXh3aW5tbnprQkJOSXFnVFJrUnpDY0dpOU5UMytG?= =?utf-8?B?dmIvdjVWR2pXYzRnZnVvbDNvaVF1VXlYdElrQUtEeDlVNlJjS29yeTdwNkk4?= =?utf-8?B?bUwzZTFOcERiWXptWWx0Z1g2V3UyNWtCUm0ycGlJcGtUc0Z3aGhpTHBwdjVD?= =?utf-8?B?SHdzM1BwVE5KbTJZVVZJNEhudldlSmh6TGRMVFA0MmtuMnpwVllZNDAxV1pF?= =?utf-8?B?VjkwUEx3TjNaR01GY09SMlk3M0lZK2VlWG9zS2JGbWVGVWJKM3JiNVg0N1hm?= =?utf-8?B?RUdKTlFpNDdhbitPMzdmSUxFTUUwMCtpbGZleVJGcStDQTJNUmpmSE04SUJE?= =?utf-8?B?WnNzRUFQTnZHTTZhbmc0NHhVcXFZb1F6UjJZMnR6UER5VU5IS2Z2eER2bUt4?= =?utf-8?B?cW9Qa3BTMlN3cGs1N0pBTXhGNzByMTAybFI2eGtaSUt4MnlZYS84M1hISEJl?= =?utf-8?B?R1ZzK2NqUlIra0IyeklRa1BXZGpKY1RJQ1lyNEF0bWFCVEViU0VtOVREUTdh?= =?utf-8?B?OHljNHg0SjFDU2xFcENhcHVMTisyNXp5OExabXdwMmVrTzh0WUt4cHBUQ1pV?= =?utf-8?B?RnUxdlNLbFJLMlY5cGdUTCt5QXBUUHJ1WW5zVFU5UEUvdGNxTDdMWmJRNDdY?= =?utf-8?B?b0FSNkNBMWxxVlNXRHRaSUxFTm1hMUlwSXc4K3NudFBYbGtCZ2ZMM3RjSmRG?= =?utf-8?B?VW9LNnI3QUpEUUt5SU90UzlhWDNxYTJZMytUd2h3dU9xZ2xqajlaclJYaGlh?= =?utf-8?B?KzdpMW91aHRleE12UmxMWmJtN2lnRnUzMk5NQXk1ank3ZndWa3JvcUw0TUlU?= =?utf-8?B?eitRdUtjOStmZ0RiY1dLc1ZHRldZUE5lU2Q2RXFQNTB5OXllZTFBVHRGWUlF?= =?utf-8?B?OU1jcXdRc0RSQUZDNTZsZFM4RFp1V2dVS2RoN1ZqNVNma3RvOGxtdkx5djBr?= =?utf-8?B?M2pKdkFOVUNIbHpMbXQ2aWFwMkZpeVhZMWVhN3pXV3hYUDU2ci9zZWpEMFdq?= =?utf-8?B?cWMrTS9Ia0R5UHpiOGw2TmdtdTY1QzNMUjlZZEttTFVaUGd5VStlak9kbEhT?= =?utf-8?B?UTA0MXQ5Tzlqd1BMYjJMWmRUbUpoNHVXekg4Q2QwdnFYV3l3TVVMZEROK0Ri?= =?utf-8?B?Uk42aTNSNTUzclJOMUhEaXdndm5ZUEJXSWc3T1JKUnFpTjMrZ0pqQlo3S3Bn?= =?utf-8?B?VGtpL3lDKzhYKzVES1czQzVidjE2Wm9meGp6YTFIci94YkdtVjNFcG9Ocm80?= =?utf-8?B?ak5SRk52c0d1elJUYWJiYVU3UVI4MHBaOGJTcXgyV1AwR0F2ZXZ5ZEp0Z0RN?= =?utf-8?B?UHAycm15dUkrTlpZL2owUHpkcE5BZTdyQnFORGNFWTNibDVDOHFUa2x3VTdy?= =?utf-8?B?MmdseUh6WWRPeXJFcmcwZGVWdVY4NkNRQW5mT3BvS1hrOEF2U2tSczUwdDAw?= =?utf-8?B?L2FzR3Bad3ZnOHIzUlMrQVdFMUtRUjJDWXNFeWhpTDlUQTNvaTZJTnZDdEd6?= =?utf-8?B?ZWtiMlV4QnRHQkdMS2Z4ZkZadVJCN2p4cGlkWVVLV2lSUGd6enhIbThsRkVn?= =?utf-8?B?djdDVVFNRm4rNENPck1QSmo1anZRV3c2ZUVpVjE1NkNMaHBjY0ErMmtObDI3?= =?utf-8?B?d3dLOWVFcStqUXBCM3N2OU9iN0cyU2svZ09KY0hIK055UmlVYmUzSjREY3Zl?= =?utf-8?B?T2c9PQ==?= X-OriginatorOrg: noa-archive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56efcff3-de96-41a5-a764-08dc4e5e71e8 X-MS-Exchange-CrossTenant-AuthSource: DB4PR09MB5847.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 13:04:32.5935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a676c8d7-7f39-4c99-a306-48abb76a98e9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gw+C6xQjZ+iFm89KjkW1SGegF32wU4QLfoWQTEy42P5ZAI4OJ1CIvwNm8dV1i6TzVxHyMoqyeKcUnp8niDjxBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR09MB4135 Subject: Re: [FFmpeg-devel] [PATCH 2/2] examples/decode_filter_video: Add loop for draining the filtergraph X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 27/03/2024 13:53, Anton Khirnov wrote: > Quoting Tobias Rapp (2024-03-27 13:46:40) >> On 27/03/2024 13:06, Stefano Sabatini wrote: >> >>> On date Wednesday 2024-03-27 11:51:31 +0100, Tobias Rapp wrote: >>>> Depending on the filters used the filtergraph can produce trailing data >>>> after feeding it the last input frame. Update the example to include the >>>> necessary loop for draining the filtergrap. >>>> >>>> Signed-off-by: Tobias Rapp >>>> --- >>>> doc/examples/decode_filter_video.c | 19 +++++++++++++++++++ >>>> 1 file changed, 19 insertions(+) >>>> >>>> diff --git a/doc/examples/decode_filter_video.c b/doc/examples/decode_filter_video.c >>>> index 454c192..a57e6df 100644 >>>> --- a/doc/examples/decode_filter_video.c >>>> +++ b/doc/examples/decode_filter_video.c >>>> @@ -276,6 +276,25 @@ int main(int argc, char **argv) >>>> } >>>> av_packet_unref(packet); >>>> } >>>> + if (ret == AVERROR_EOF) { >>>> + /* signal EOF to the filtergraph */ >>>> + if (av_buffersrc_add_frame_flags(buffersrc_ctx, NULL, 0) < 0) { >>>> + av_log(NULL, AV_LOG_ERROR, "Error while closing the filtergraph\n"); >>>> + goto end; >>>> + } >>>> + >>>> + /* pull remaining frames from the filtergraph */ >>>> + while (1) { >>>> + ret = av_buffersink_get_frame(buffersink_ctx, filt_frame); >>>> + if (ret == AVERROR(EAGAIN) || ret == AVERROR_EOF) >>>> + break; >>> how are we supposed to handle the EAGAIN case? Shouldn't this be a >>> sleep and retry? >> Good suggestion. I could add something like usleep(100) upon EAGAIN. > No, EAGAIN from a filter after EOF on all inputs is a bug. Ok. Also from a second look at the example all the other locations where EAGAIN is handled do not perform a retry. So adding that would be orthogonal to this patch, IMHO. Regards, Tobias _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".