Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Don't pretend array to be bigger than it is
Date: Mon, 11 Sep 2023 18:50:36 +0200
Message-ID: <86081aedffc73e87bc3f32fb3e6d3605a7574dfa.camel@haerdin.se> (raw)
In-Reply-To: <AS8P250MB0744AEAC5C889814181E32E58FF2A@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

mån 2023-09-11 klockan 18:29 +0200 skrev Andreas Rheinhardt:
> mxf_match_uid() accepts two const UID and a len parameter.
> UID is a typedef for an array of 16 uint8_t, so the const UID
> parameter is actually a pointer to const uint8_t.
> 
> The point of mxf_match_uid() is to check whether the initial
> part of two UIDs match; the length of said part is given
> by the len parameter. Once an incomplete UID has been passed
> to mxf_match_uid() (albeit with the correct len, so safe),
> which makes GCC emit -Wstringop-overread warnings.
> 
> Fix this by using a const uint8_t[] as type; it is more
> natural for incomplete UIDs.

OK

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2023-09-11 16:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 16:29 Andreas Rheinhardt
2023-09-11 16:50 ` Tomas Härdin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86081aedffc73e87bc3f32fb3e6d3605a7574dfa.camel@haerdin.se \
    --to=git@haerdin.se \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git