From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 266DF4F7FC for ; Mon, 23 Jun 2025 13:38:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 622DC68E178; Mon, 23 Jun 2025 16:37:38 +0300 (EEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2140468E151 for ; Mon, 23 Jun 2025 16:37:37 +0300 (EEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-234bfe37cccso53687285ad.0 for ; Mon, 23 Jun 2025 06:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750685855; x=1751290655; darn=ffmpeg.org; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=j+iD64IcDw4Kys+qeQR2FvrrZLrZVcERrU5NM0InwaA=; b=MFCBk481iMBEFFqRGE1Ts5ZbOglQkI3M++K8bYJoSqHUWjlgBR6LlNRR3G+NXOejUZ fiQtH3m95sPKOcMlIyGyAfxnwyoY9ArgXMRUdPu0oXdKn3pP6VWdicW6+ycqJOyK7mb/ 3degZ2Z5+PerftxEbApg9+968fy8PrpgjDdw4tFO24EhsjZdkfci6b0aVM5CVh/gypVA kZI/fdvQJRo5y4Z/Tf8UTEVFD1MqOLCcujtKmkAlk09qGzdwwx2VLljojUOT0V13zxuv imQZP6tK+xg9n+vT4okk2NUYAmeWEDexdXyF71fySpRBBN9oNgLv3DixLKjYKPpaDWHa 8ofA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750685855; x=1751290655; h=cc:to:mime-version:content-transfer-encoding:fcc:subject:date :references:in-reply-to:message-id:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j+iD64IcDw4Kys+qeQR2FvrrZLrZVcERrU5NM0InwaA=; b=EM74Zi/eCOjv/O93nsD0CGY73OC/8IudSzlE53tT9Ig7lumEiyL4TJxb/Yt3v94+9d +xfb+zPWrDBSjg1TBiSt1jpcGshPTeJ3AIP3VLztQRhsbZ9+mDDRusRbDp0db+IP7Jmz gen4r5+rxmEt4CqDgLrP6QvTEQZ8k+Hl9XzI4NWx/4JLjDg0Q3kOO4AY73vkaXhsAXl6 A4R6vW2yqntzWdm63maTopnltbSKaL9rgsOw10FzE3StdSS7gIupqbs6enGKlqUkzpHL bT0TtKcBuyB+H84aQZC/FyLkBL1Q2ANQ0voxGTvsc4QwaEVB9d1hpXVJ5NLU19OECG1p 7r+g== X-Gm-Message-State: AOJu0Yw4ZthhVlOZ5V9Du0Cx2XPiXGO2vtXLCkL7EtxzNOFBWYPGr/Qx /OzoyuCg9j792wPNys6qXk2uad7JwVxtFt+2fryID26CAcKZ/LErqdGrwycqfg== X-Gm-Gg: ASbGncvRkARs9JP7q/0hyPjWdmdjBdPXpa90sOCzp6jxjQEvk3yOcHauBFXPenc38Ts Sj8V3oCqUpgdOG+pclzOGAoc/j0lerPTYXIbKozuicb7z/NBoMhEyUiTep3KuODkbf2eo6DLwSX t0u5gSrQxveDqklbrlMtgFjHS+xkFqGUq0DOZxDs5M/fU/3UhAFwhfyE6DLG/r7DiifFX8gZysT qfRw+tn4yaXldAOICOc/HJhxNhAdccVvexOaXA8Ry6+ObJ0HqhF8ACjopzsF5HgRgg7j9FxK7Oe hG5THfazDTSOHdUo5yyn8GApPC1uzYtKxMHcsPFzjcZB8stJLRrZCH5pZ5amCR0wvdfeWXvIXuT /tvFbS7V1RjcFNxjW X-Google-Smtp-Source: AGHT+IFWlirTE185CZKsCAlvxZMNZQlr8uHqdlQrNZOauv5frD1bsvuZYNBAzAVWYvMZ4jaDu+lD7g== X-Received: by 2002:a17:903:b0e:b0:235:7c6:eba2 with SMTP id d9443c01a7336-237d9984c4dmr164937545ad.37.1750685855395; Mon, 23 Jun 2025 06:37:35 -0700 (PDT) Received: from [127.0.0.1] (master.gitmailbox.com. [34.83.118.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-237d83d5c97sm85717105ad.70.2025.06.23.06.37.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jun 2025 06:37:35 -0700 (PDT) From: Andreas Rheinhardt X-Google-Original-From: Andreas Rheinhardt Message-Id: <85da088377db9402f8f0fe0eaa9dacd1f40d61b8.1750685809.git.ffmpegagent@gmail.com> In-Reply-To: References: Date: Mon, 23 Jun 2025 13:36:07 +0000 Fcc: Sent MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH 07/48] avcodec/mpegvideo_dec: Factor debugging dct coefficients out X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Andreas Rheinhardt This allows to hint to the compiler that the branch is likely not taken by marking the factored out function as av_cold. It is also in preparation for further commits. Signed-off-by: Andreas Rheinhardt --- libavcodec/mpegvideo_dec.c | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/libavcodec/mpegvideo_dec.c b/libavcodec/mpegvideo_dec.c index f8551b93c8..c687f3a972 100644 --- a/libavcodec/mpegvideo_dec.c +++ b/libavcodec/mpegvideo_dec.c @@ -1064,6 +1064,19 @@ void mpv_reconstruct_mb_internal(MpegEncContext *s, int16_t block[12][64], } } +static av_cold void debug_dct_coeffs(MPVContext *s, const int16_t block[][64]) +{ + /* print DCT coefficients */ + av_log(s->avctx, AV_LOG_DEBUG, "DCT coeffs of MB at %dx%d:\n", s->mb_x, s->mb_y); + for (int i = 0; i < 6; i++) { + for (int j = 0; j < 64; j++) { + av_log(s->avctx, AV_LOG_DEBUG, "%5d", + block[i][s->idsp.idct_permutation[j]]); + } + av_log(s->avctx, AV_LOG_DEBUG, "\n"); + } +} + void ff_mpv_reconstruct_mb(MpegEncContext *s, int16_t block[12][64]) { const int mb_xy = s->mb_y * s->mb_stride + s->mb_x; @@ -1082,17 +1095,8 @@ void ff_mpv_reconstruct_mb(MpegEncContext *s, int16_t block[12][64]) *mbskip_ptr = 0; /* not skipped */ } - if (s->avctx->debug & FF_DEBUG_DCT_COEFF) { - /* print DCT coefficients */ - av_log(s->avctx, AV_LOG_DEBUG, "DCT coeffs of MB at %dx%d:\n", s->mb_x, s->mb_y); - for (int i = 0; i < 6; i++) { - for (int j = 0; j < 64; j++) { - av_log(s->avctx, AV_LOG_DEBUG, "%5d", - block[i][s->idsp.idct_permutation[j]]); - } - av_log(s->avctx, AV_LOG_DEBUG, "\n"); - } - } + if (s->avctx->debug & FF_DEBUG_DCT_COEFF) + debug_dct_coeffs(s, block); av_assert2((s->out_format <= FMT_H261) == (s->out_format == FMT_H261 || s->out_format == FMT_MPEG1)); if (!s->avctx->lowres) { -- ffmpeg-codebot _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".