From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 62A7549A69 for ; Mon, 26 Feb 2024 22:12:36 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F1AFF68C8F2; Tue, 27 Feb 2024 00:12:33 +0200 (EET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3A13268BD9A for ; Tue, 27 Feb 2024 00:12:26 +0200 (EET) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-29ab7073dd2so1105809a91.0 for ; Mon, 26 Feb 2024 14:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708985543; x=1709590343; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=btP/QhDvLFIie+3dltiDYMEXlQ+0++Hgylnjnt9cbQM=; b=ViU9rqF9gA/+K3wdfdEyPWgm9hh1Ag11uAM0zbMz12su7VImH+OkoY/TKlP5x1yvkp C78SlBF1UrIHhKQrm8HVB77HtIh4o/6esXkNYPqmytFl9tGwby84176vCiDIMSnnfXhE Y77AU8Gn+3wH+8wtmjQgBcwhRIYqDlcX7IvqaLhCGDTKHfQBKexxVfD0gnrw1aVMeCE+ SQ2Ww+7ysLgIYgnr0+YEp8i+OrcXQnEmkbfS/hxzAHYNN6SUdzlNso8zHvVmqJBZYyec iJ7ScRLyvhzowOsR71LitEXKgAOozM+Z0uw9zn6GOYk9/q6uvgNxB/Y2TLqc/XKC+3qO AMvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708985543; x=1709590343; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=btP/QhDvLFIie+3dltiDYMEXlQ+0++Hgylnjnt9cbQM=; b=R95U9nqYWZAwUs5jqjCKwfgCpZ8HH/7rXLVsDV8E4MQiAaoCpCMqd3JXd3JaSnBhLX nc0D+keuMgvypB0alH4rx3fFnS95CsN3+JV3hSIJIcnUNBIxvOwMuFGVUWn8WDtJk3p3 13mCZaMAO5ImTl3WDaMSPxtElgJIvf8brJSxt0IAnGH6MKkY/zh0kL1umOr/2u0NaB6x J3WfGOatHYmmyy1aCdO6/LyiIUhxK9nk3SpfeB1wvafX2voO0q4FQwfllQXP2N3mkIF2 Rw2f5nc+mNvo/y2XUh2ebgPXdJ5dBSyDdMPMH76wlrQddmVLAyvJf7+G+BcrWxrnWCq1 TOjQ== X-Gm-Message-State: AOJu0Yw22etqq/j+s1v4t6AGyFoBAj+W1eNKUzczlyEu8JutCoDF/Uwh EkOd5b6aSPyhaJkiOJDqaLrA5lAHYxgHCDL0JQDI8BZOSWlfmQCVED2xmobX X-Google-Smtp-Source: AGHT+IE4wTqq0cxL8+JxflEVJWdQfn0oQWbUAK4H5V9ODHWccJBi3RQlI4RqpLa/3h+/qJRXydCmsQ== X-Received: by 2002:a17:90b:11cf:b0:29a:e119:3510 with SMTP id gv15-20020a17090b11cf00b0029ae1193510mr325382pjb.42.1708985543627; Mon, 26 Feb 2024 14:12:23 -0800 (PST) Received: from [192.168.0.11] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id r7-20020a17090b050700b00298dd684b8csm4970385pjz.32.2024.02.26.14.12.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 14:12:23 -0800 (PST) Message-ID: <85bf7dc2-d9e5-4242-9bf6-5ec3d262b922@gmail.com> Date: Mon, 26 Feb 2024 19:12:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] Revert "avformat/mov: zero initialize the index ranges buffer" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/26/2024 7:11 PM, Andreas Rheinhardt wrote: > This reverts commit eee3b7e2fb0664b889e58c03f76e19ef23e4d1d8. > It has been made in an attempt to fix UBSan test failures with > GCC 13 (see e.g. [1]), but it did not help at all. So revert it, > but use av_malloc_array() instead of going back to av_malloc(). > > [1]: https://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc-ubsan&time=20240226182430 > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mov.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index effa46120f..71e8f7ae8f 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -4031,7 +4031,8 @@ static void mov_fix_index(MOVContext *mov, AVStream *st) > } > > // allocate the index ranges array > - msc->index_ranges = av_calloc((msc->elst_count + 1), sizeof(msc->index_ranges[0])); > + msc->index_ranges = av_malloc_array(msc->elst_count + 1, > + sizeof(msc->index_ranges[0])); > if (!msc->index_ranges) { > av_log(mov->fc, AV_LOG_ERROR, "Cannot allocate index ranges buffer\n"); > return; LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".