From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: Re: [FFmpeg-devel] [PATCH v2 1/4] avutil/aarch64: Skip define AV_READ_TIME for apple
Date: Fri, 7 Jun 2024 12:10:49 +0300 (EEST)
Message-ID: <857932f9-4936-a0cc-5a6-d339832c8e0@martin.st> (raw)
In-Reply-To: <tencent_136357879CA8E1805AA635FF812C34693E09@qq.com>
On Fri, 7 Jun 2024, Zhao Zhili wrote:
> From: Zhao Zhili <zhilizhao@tencent.com>
>
> It will fallback to mach_absolute_time inside libavutil/timer.h
> ---
> libavutil/aarch64/timer.h | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/libavutil/aarch64/timer.h b/libavutil/aarch64/timer.h
> index 8b28fd354c..fadc9568f8 100644
> --- a/libavutil/aarch64/timer.h
> +++ b/libavutil/aarch64/timer.h
> @@ -24,13 +24,7 @@
> #include <stdint.h>
> #include "config.h"
>
> -#if defined(__APPLE__)
> -
> -#include <mach/mach_time.h>
> -
> -#define AV_READ_TIME mach_absolute_time
> -
> -#elif HAVE_INLINE_ASM
> +#if HAVE_INLINE_ASM && !defined(__APPLE__)
>
> #define AV_READ_TIME read_time
>
> --
> 2.34.1
LGTM
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-06-07 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 17:20 Zhao Zhili
2024-06-07 9:10 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857932f9-4936-a0cc-5a6-d339832c8e0@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=zhilizhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git