Re: [FFmpeg-devel] [PATCH 06/13] lavu/mem: Add ff_fast_recalloc()

[James Almer <jamrial@gmail.com>]

On 6/15/2022 6:59 AM, Tomas Härdin wrote:
> tis 2022-06-14 klockan 22:26 +0200 skrev Michael Niedermayer:
>> On Tue, Jun 14, 2022 at 04:42:06PM +0200, Tomas Härdin wrote:
>>> Left this as an ff_ funtion for now since it's only used by the j2k
>>> code
>>>
>>> /Tomas
>>
>>>   mem.c |   24 ++++++++++++++++++++++++
>>>   mem.h |   55
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>   2 files changed, 79 insertions(+)
>>> 21be65bd06e3260f9f36598d5d574ee32e7131a6  0006-lavu-mem-Add-
>>> ff_fast_recalloc.patch
>>>  From 5d36d431ffe4c8ba0f698d0c288ebc16b83f0bbc Mon Sep 17 00:00:00
>>> 2001
>>> From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <git@haerdin.se>
>>> Date: Tue, 14 Jun 2022 13:35:18 +0200
>>> Subject: [PATCH 06/13] lavu/mem: Add ff_fast_recalloc()
>>
>> You cannot call a ff_* function thats in libavutil from outside
>> libavutil
>> this will fail with shared libs as the ff* stuff is not exported
> 
> Ah, I suspected as much. Would there be much opposition to a public
> function like this in lavu? I could just keep it local to the j2k code

Just make it public by using the av_ prefix (You in fact added it to 
mem.h, which is installed. You'd need to add it to mem_internal.h if you 
wanted to avoid exposing it).

Don't forget to add an APIChanges entry and minor lavu version bump 
before you push if you do.

> 
> /Tomas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".