From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BB85240516 for ; Mon, 24 Jan 2022 21:21:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B82BA68B10F; Mon, 24 Jan 2022 23:21:44 +0200 (EET) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2DF9668B0F9 for ; Mon, 24 Jan 2022 23:21:39 +0200 (EET) Received: by mail-oi1-f182.google.com with SMTP id s127so27650880oig.2 for ; Mon, 24 Jan 2022 13:21:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=QH06IFtSpDP7vwE7qDql1b0Z48LEdscv4bes/Iw3Gjw=; b=c41JTLuhttoJukj8/oywDBti0KPIl9tGByn0JvSI+By4p4lMn/30hClcIp8H+SXqTr dQXSU5/hJKxLiyDBSYkdXcyLX1s0leGpY8y9G63Jh2sfSLOxh119ye1nC/er1Uhm4XJY PZa3lM7QUmYh1bO3fF7Ml2Nz9MYrTw7/P2ufb5f3UE0tDJWf1AKg1nwXCmD3htIiaR1B qf/rWocYXk3iAPn/iUebfnjktjLkFp6UASlAdchDZA6mRhCCtiXZG4vrvqz48uiF1sKf xcT8A6/cyJ/Ybk4OKQrxgJIMK/Q6U8w3/njgUbMxI2gc66PKVasl8t5n+nj4tgDVfv5/ j7UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=QH06IFtSpDP7vwE7qDql1b0Z48LEdscv4bes/Iw3Gjw=; b=Z9uI7ka/5XKhQa5G8g1l33b4LC3yDZLTyXG82sdS0N7qo0Ej1pWGnHG96Yzdg0JnvM mfYhZDfZLiKc2pJKf5BFvXbexnoi6Fg25oVUbc0Gv4NyXWOi21iD+e0qIAHAk/D1dsNt F6xyyCpZSO0rIlpvwixC/8A3KnDuQunKwGje3otOw3/vH89yxosum76vMo3DfZmlfVv9 2gl0XIsKbxouw5HiueqXWws//VKOXDoj9jA6qMc7O+2j4V46qxa1U3RU9hOl5Q/DU4GH Ur6EItghEdJg2ITsE7T93Y4fK0UC2X4F/54MGDeuh6AdKdWBZk8vT0PM/zD1PpBCS1Yb rJLw== X-Gm-Message-State: AOAM531i2xUS23dCzsJJRCM+rGJtV1VqKtUYRlktImhY9b3zMpn3yKxo bu4Hh5ukWK90vRQ00MKmZO+7nm/M+KU= X-Google-Smtp-Source: ABdhPJzKWMRgG9f1rJ4BbKbdHjr68RRgQVbF34vBFMnYzSILGuU2uQMss1q4a4M7p8OcJsBKbXh+FA== X-Received: by 2002:aca:1119:: with SMTP id 25mr3005485oir.45.1643059297322; Mon, 24 Jan 2022 13:21:37 -0800 (PST) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id f6sm4761285oos.7.2022.01.24.13.21.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 13:21:36 -0800 (PST) Message-ID: <84d13ae0-26c4-c2c3-fb60-dc3528d69b4f@gmail.com> Date: Mon, 24 Jan 2022 18:21:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220124204656.48625-1-jamrial@gmail.com> <8a44dca2-4c46-4fcc-5e4f-b2c536a6a28c@passwd.hu> From: James Almer In-Reply-To: <8a44dca2-4c46-4fcc-5e4f-b2c536a6a28c@passwd.hu> Subject: Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/24/2022 6:08 PM, Marton Balint wrote: > > > On Mon, 24 Jan 2022, James Almer wrote: > >> From: Anton Khirnov >> >> The new API is more extensible and allows for custom layouts. >> More accurate information is exported, eg for decoders that do not >> set a channel layout, lavc will not make one up for them. >> >> Deprecate the old API working with just uint64_t bitmasks. >> >> Expanded and completed by Vittorio Giovara >> and James Almer . >> Signed-off-by: Vittorio Giovara >> Signed-off-by: James Almer >> --- >> Changes since last version: >> >> *Both av_channel_layout_describe() and av_channel_layout_from_string() >> now >> support a "2 channels (FL+LFE)" syntax, to signal native (usually >> non-standard) or custom order layouts. >> *a single decimal value is now interpreted as a mask by >> av_channel_layout_from_string(), same as a single hexadecimal value. >> *De-duplicated code by simplifying >> av_channel_layout_channel_from_string(). > > AV_CHAN_UNKWNOWN is fixed in the Amibsonic patch, but it should be fixed > in this patch. Constant rebases and amends can do that, sorry. Fixed in the github branch. > >> +/** >> + * Check whether a channel layout is valid, i.e. can possibly >> describe audio >> + * data. >> + * >> + * @param channel_layout input channel layout >> + * @return 1 if channel_layout is valid, 0 otherwise. >> + */ >> +int av_channel_layout_check(const AVChannelLayout *channel_layout); > > I still find the name av_channel_layout_valid() more readable, but feel > free to keep it as is if you disagree. If others also prefer it then I'll change it. I personally don't find av_channel_layout_check() worse than av_channel_layout_valid(). > > Thanks, > Marton > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".