From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 959D94B7FD for ; Tue, 22 Jul 2025 01:00:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 185EA68CC5E; Tue, 22 Jul 2025 04:00:10 +0300 (EEST) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D1E12687D16 for ; Tue, 22 Jul 2025 04:00:03 +0300 (EEST) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-ae0ccfd5ca5so698710166b.3 for ; Mon, 21 Jul 2025 18:00:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753146003; x=1753750803; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ER4t+FIqhT18UNgRVii7alN4loHJAjIwqDACQRU+MP0=; b=eJq1Q8mk8srRSTghnzvyubOnsTTgbP/PvopzIxc8TtwL3DJ9UQ3ChJaaTsWRPJ7jH1 56PRHUpUltGJo1JjLHuh5RtsCia54EJmBtGMj7uFGB+G7IBp8zpA5T/EDCwn0htgrE49 CeyOBwHckORVrwMU34e1thVArmgTTGflpJDOpwc72MLZyveGakENIXRtCRnOq6U26IFP UMpCfpF5U8gBhxet8A7DMcZYbEeuUFsmK7Q8qHdpo6FbYfaZGAgjr7nyd+VrnZEb0kRr O6dfn2MPyZSLs04COjIOHFu5kvWzVZn4uy1yMUPYJeG9XneJImZOHG3STHGYW3x9nw8V +Eog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753146003; x=1753750803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ER4t+FIqhT18UNgRVii7alN4loHJAjIwqDACQRU+MP0=; b=a/ts2low3shL8xjhQLzZ4mBStK7MtUoUka3tFwINd1XMqC96XbcDsy7f6+OPHuUVGt z+qFhgNzxcWYOoYKjbiRhHo8M3nU5rHsi/CGxW4hG8SorC/GKvvbUOVUqt1Z0wYsiDrt lqEs2SlJMNcPzLc3sEcwDM/RwLTQl4gprqRaowl9/teUbp1ugMPukeWGUUHCXoWG7WPt rY8MfLm+BHJjt1VyZzbo6O5KPoscmBtNaJZIvOKL5nXg63JnWqTV3xVpFE+31Nsvgfha WcsW+fELw8kav9RpjrW1nYRYoevEA3yYQChtFkri9SiEiJi8hIzcHp7W7Q87hRemLlw4 hmlg== X-Gm-Message-State: AOJu0YxqUaleftLANGIy2VHVdymbWfEAc/EEcoVFLpTd4d8XU9Ydo0Of yuVtVCVg62C+FXaMH33YOkyzsQthZenhTxyEgJB0sVzv+xUcLdkRAB5XReNt3q5N X-Gm-Gg: ASbGncsTc5SKjo6oMcDgJ+tso6veJKO6e9mtYxgfHKMyf1CbwJGuVNSKJ3neV0gxVb8 TC05F6PSUTG6kXuenTY0UC5b0leLKvgzEXtD83sdS/lmUFJzgCVcc3/Kq5ouISveusx8dc8wx0n EmWUm0GSjbxZ7DbWCVA1POK5imauGZqigzM+ISXWdokZ5zs9BHPyT/FOOA/NLvdTYMObU2+0Dpr t3jUo6N5DAPewiyB3pxxFecHOzcQN/5y5/iQtuAZQG3x99jGMLcTMzLLa8yMj3vmmUXRZzKFcRp CoWagFP2H3Pk/ZbiiSowWIsY5MEdCd5Dt40UnViQdjZJlfqhMFaZhTrSRgULWz4YjCaTNRuwpy5 eIqwQhd+wjmDg6Vnbt82gI8oMmoRRyEhbKOn5/pQ8NnEFJbN3X0WBdae7f4vIOlJ6J5rDS28cqW 524vXLP3Mh8NEMHk8JpFBkbHs++NAbD92VBB/r X-Google-Smtp-Source: AGHT+IEolqzF8VZKhfcWzBA+zjxOoPqgcCjE+ROLiuX8KFiQQd5aFLG0dlxf9KsJIMmLSloWwK32Uw== X-Received: by 2002:a17:907:6d11:b0:ae7:fc3:919d with SMTP id a640c23a62f3a-ae9cde595a2mr2202373266b.25.1753146002934; Mon, 21 Jul 2025 18:00:02 -0700 (PDT) Received: from [192.168.178.143] (p200301023701fa0031f124c1d1087870.dip0.t-ipconnect.de. [2003:102:3701:fa00:31f1:24c1:d108:7870]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6c79e16esm764208066b.15.2025.07.21.18.00.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Jul 2025 18:00:02 -0700 (PDT) From: Marvin Scholz To: ffmpeg-devel@ffmpeg.org Date: Tue, 22 Jul 2025 03:00:01 +0200 X-Mailer: MailMate Free Mode (2.0r6222) Message-ID: <8477CE88-2573-40F5-A6C7-F1D3D6699C90@gmail.com> In-Reply-To: <20250710115117.13102-3-epirat07@gmail.com> References: <20250708180617.59679-1-epirat07@gmail.com> <20250710115117.13102-1-epirat07@gmail.com> <20250710115117.13102-3-epirat07@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v4 3/3] avformat/tls_openssl: load default verify locations X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 10 Jul 2025, at 13:51, Marvin Scholz wrote: > When no explicit CAs file is set, load the default locations, > else there is no way for verification to succeed. > > This matches the behavior of other TLS backends. > --- > libavformat/tls_openssl.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c > index 33b3a46dfd..79801b7261 100644 > --- a/libavformat/tls_openssl.c > +++ b/libavformat/tls_openssl.c > @@ -699,6 +699,12 @@ static av_cold int openssl_init_ca_key_cert(URLContext *h) > if (c->ca_file) { > if (!SSL_CTX_load_verify_locations(p->ctx, c->ca_file, NULL)) > av_log(h, AV_LOG_ERROR, "SSL_CTX_load_verify_locations %s\n", openssl_get_error(p)); > + } else { > + if (!SSL_CTX_set_default_verify_paths(p->ctx)) { > + // Only log the failure but do not error out, as this is not fatal > + av_log(h, AV_LOG_WARNING, "Failure setting default verify locations: %s\n", > + openssl_get_error(p)); > + } > } > > if (c->cert_file) { > -- > 2.39.5 (Apple Git-154) Pushed as e56fd2af1a0b65bf5a7788462cbaee3b4b909591 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".