From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E09A42514 for ; Tue, 4 Jan 2022 23:52:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E3CD068A2D7; Wed, 5 Jan 2022 01:52:05 +0200 (EET) Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C4A44687992 for ; Wed, 5 Jan 2022 01:51:59 +0200 (EET) Received: by mail-oo1-f47.google.com with SMTP id v7-20020a4a2447000000b002daf9b0cb1eso10408088oov.8 for ; Tue, 04 Jan 2022 15:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=diQihs4RgCaVSpvS661VYkuojCv51wlKFwiAtEHGaHQ=; b=lSFPh9pnQPpU2SQQijv2l64pjZjpHSWgxtMYwMznFXfvWadPqPFtrrjPVQN2ESPS53 LcdnOrjsp+OiEp+/ndgbYWs1wW5Z242qoqUhn0C7Jbk0V8J5sLCk+N0zi0WbJmUW21QV ol+Esvk5IaejwIZRRFG5/mWj6bRI6lHnmXwkDO/38QldYnzQp7RdcFXmWD7NVovJJArA qwK7eEpS6DUy95UAHHHrptEYpYeR9jkZu36SdRaulaTsNm3PGHfDhW21sMAEjWyHXpFX /Et5jvitsCJEVGVZI+HfH/EncXf5v0mMgWVRsrowxY+FDBEUK1Fy7yjCStg/u6izHkKa wyYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=diQihs4RgCaVSpvS661VYkuojCv51wlKFwiAtEHGaHQ=; b=zBTPYkXkKj3ZBpaxkzIg7GKdRA7P54nzxItuIiuR3+DtyIEtvcmA2KXNrAkfLh/w15 EVpsmS8MTnsJXvWnH/P8spaREuzDNklm5sqNgV00sRCja/b/qrR/pYuEXM08Pijhl02i ttukfSn6NOi2hsyrlABeG/5MYJenM0SHQm2uThKMwKymF//qZY1tkvgkEiZhKz9IwFZd GdEB04WF8la5ygJehIF56md791XLD6qLUGwcYvorzRWNQq2xc97eN9XSr0MhcxokSNMb Wi9lkfB8sG1pId5VxS9oLYYEKwXMLCNL4uWlA9toGKd4+sV4aaJFwedItODw9kKnIZTe 2SLw== X-Gm-Message-State: AOAM533dPS06xvuqJbygsWHvvH+ts+tEaylm3bv+syEjLmP7DcE2wCJS nud6+LUBRObMslGRPcSAixVrRa8J6GB7cQ== X-Google-Smtp-Source: ABdhPJwzIMKm7LP2xOcYnd6VSOq523KN7Jfpm56eE7R82RvW3831cSSolhtuElmmJBC3t2xB7cIorw== X-Received: by 2002:a4a:a98e:: with SMTP id w14mr33055261oom.16.1641340317436; Tue, 04 Jan 2022 15:51:57 -0800 (PST) Received: from smtpclient.apple ([2600:1700:4830:3f7f:ccc6:7d04:4bed:4398]) by smtp.gmail.com with ESMTPSA id bf17sm10284985oib.27.2022.01.04.15.51.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jan 2022 15:51:56 -0800 (PST) Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.40.0.1.81\)) From: Cameron Gutman In-Reply-To: <1641289393-4372-1-git-send-email-lance.lmwang@gmail.com> Date: Tue, 4 Jan 2022 17:51:56 -0600 Message-Id: <8448DF04-D4A1-40AB-A4CF-2F4E65301300@gmail.com> References: <1641289393-4372-1-git-send-email-lance.lmwang@gmail.com> To: FFmpeg development discussions and patches X-Mailer: Apple Mail (2.3693.40.0.1.81) Subject: Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Limin Wang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > On Jan 4, 2022, at 3:43 AM, lance.lmwang@gmail.com wrote: > > From: Limin Wang > > Please reproduced with the following minimal configure command: > ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox > > You'll get below error: > > Undefined symbols for architecture x86_64: > "_ff_videotoolbox_vpcc_extradata_create", referenced from: > _videotoolbox_start in videotoolbox.o > ld: symbol(s) not found for architecture x86_64 > clang: error: linker command failed with exit code 1 (use -v to see invocation) > > Reported-by: Cameron Gutman > Signed-off-by: Limin Wang > --- Thanks, this fixes the build break for me. Please merge it into 5.0 if possible. Tested-by: Cameron Gutman > libavcodec/videotoolbox.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > index 69beb38..51d4eac 100644 > --- a/libavcodec/videotoolbox.c > +++ b/libavcodec/videotoolbox.c > @@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec > if (data) > CFDictionarySetValue(avc_info, CFSTR("hvcC"), data); > break; > +#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL > case kCMVideoCodecType_VP9 : > data = ff_videotoolbox_vpcc_extradata_create(avctx); > if (data) > CFDictionarySetValue(avc_info, CFSTR("vpcC"), data); > break; > +#endif > default: > break; > } > -- > 1.8.3.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".