From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8F7054CABA for ; Tue, 13 Aug 2024 19:47:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5104A68DA8E; Tue, 13 Aug 2024 22:47:29 +0300 (EEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5218068D9ED for ; Tue, 13 Aug 2024 22:47:23 +0300 (EEST) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-710ce81bf7dso3830369b3a.0 for ; Tue, 13 Aug 2024 12:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723578440; x=1724183240; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=98oK4OhN7HO2doN1ojesr2f4Utd5+1OlvPd6UcumOnc=; b=ng96EZkNC9IVbj/jy70iIC+4Z0FmI1DOowItvUzSgWBHQsCB4wXNOhUnZbawNcUGHY C+JrRw01QSfd3/bkNTatxH5H2gJiArqaqxZLBhttz2j5r21I7IjbnAUMUhKcpvcpozO/ YZzlodg0YYE5fuPUJvxIdMKzsdjGAytcry/ysbw9Rd3wEUOqZiq8bTv4sYnWCV7m15Lk lSZ4yFp81S6rqUsyeCyfY5JegQRL8CluclttI9d2//YZhKooXEfgN/Z3Oc0pH79zHQ3R 0Ii1XWhV86QLs2q008tY33TlrXTISTwE+uJ57nTjlJmemzL1dL1O46c4UkkdqZf1cTOo nDgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723578440; x=1724183240; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=98oK4OhN7HO2doN1ojesr2f4Utd5+1OlvPd6UcumOnc=; b=wAbUC4ADwdUlYFpq4P4uFWzd4KNR7mA0aHDbSLQoyzAzF7n1PlTMxenxInrundeA1t Lyzbxn0X82i8HxHkYmZ/9DS8Yzt/hPFg6iKQP6GKgZXxz9L6VhKrYB4wyDzSXdP9u/0H OIT7JNr0byMw05GcZ4mZy5X7vvjER/VMnTpSZa4XQ8In8fHp+JbJu+QfZbR52x8w9TuZ LfIEoF1OHrcsM1sK1iJ29O0EQQj6veqOcqinGD3pJM4y/N9aFHzjNhLtQ/XtONTMeOXV UEKm7XKsoTMrHM8JS7NGfQ/7X3v2/K7MqK2zoCU1SMSvoXWt/HECnF+ogb9mMvGtQTFw ng1A== X-Gm-Message-State: AOJu0YwOyLJtZAPH2ZsllUZ7dV5z2l8geGV1K7Uz0xDOBxS17Eh6/j2C YNttLnfN5wZm9LmVLvgN8uMANT+MLjsqV4+KtpTkXxgrLV6Bc2NJKoqbeg== X-Google-Smtp-Source: AGHT+IFqqT0sLPp+wHOcNkzGWrgFmFCRdoc0WSHViU3hDyLQIohkBOUNFPrLNhPimRwLBX6MG0C68g== X-Received: by 2002:a05:6a00:23c8:b0:706:5dab:83c4 with SMTP id d2e1a72fcca58-71267120b40mr921263b3a.14.1723578440447; Tue, 13 Aug 2024 12:47:20 -0700 (PDT) Received: from [192.168.0.14] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-710e58a0b5dsm6075022b3a.47.2024.08.13.12.47.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 12:47:19 -0700 (PDT) Message-ID: <840d1e0e-17a1-481e-82df-44ed855c05cf@gmail.com> Date: Tue, 13 Aug 2024 16:47:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/13/2024 4:31 PM, Dale Curtis wrote: > Film grain support adds a huge amount of overhead to the H264Context > structure for a feature that is rarely used. On low end devices or > pages that have lots of media this bloats memory usage rapidly. > > This introduces a --disable-h264-film-grain option which makes > these fields optional and reduces the H264Context size from > 851808 bytes to 53444 bytes. > > Bug: https://crbug.com/359358875 > Signed-off-by: Dale Curtis > > Note: I'm not sure this is the right way to go about making this optional, > please > let me know if there's a better way. > > - dale The proper name for the option and define should be H274, or simply film_grain if you're also including AV1FG in it. I'm not against a change like this, but it needs to be thorough like we did with iamfenc and iamfdec, and there's more code handling film grain in other modules. Not sure what Niklas thinks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".