From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5BCD947068 for ; Tue, 25 Jul 2023 21:08:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9983968C6D4; Wed, 26 Jul 2023 00:08:08 +0300 (EEST) Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 98EFB68C687 for ; Wed, 26 Jul 2023 00:08:02 +0300 (EEST) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-1bb717ece50so1695357fac.0 for ; Tue, 25 Jul 2023 14:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690319280; x=1690924080; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=n75l1MeZ3INLV0l1nBMi90L8p9/viVuDmaSyM+7ycqU=; b=jW8ZnZFcRQMCrqFrLgcIOLe7eW/Z0qYmXp2sXguQmt1DUKg4BEEd8WPIhu7wU1W0Vk Q8S3+L8VPMhFY8eOh7nvFNOWD7AGj7Gw2cVAJV12qKEt8MN4GIi9bDzLfm9J/Lj+tKhJ XSo41+B9nX72PpZMAtZL0y0OVrACKlN+kpDUK+HLMbzwS7byr1iFCKp6nGhirXTisthJ YJWG9x7TfU9V7EVPQGjyGs6kK731MS8Uesy/OmsFiSMPppxszf+HL7RPsncqsv1X1RfM L49PizyDjeYxe39bYVjrw+ZoJBB2xtLizcHt2g3AavrQLY4PGh80Jd2PrAqSzcCKD0PR Y7+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690319280; x=1690924080; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n75l1MeZ3INLV0l1nBMi90L8p9/viVuDmaSyM+7ycqU=; b=iXULKvwXUBq86MxIoycUO/LpMgi6fzxOoOazou6SVwnjmo0rI+haTmmzR37A/2EQWK C3tpchtMyLjVugbKbbL8aCi38TSp7PfpvmpQV4aquF+mRNW0sV8DVYtFXln84spUA8Hn Bk6/OxLozCcnHB3Wrm2Htew0vPAdR+j4MZhpDO9MwGfLEJNypShBmPe9NNqG/2liCWSR /2Fa1F03dB2hbO1OyWCJ1MQxaf8dOsQrnYBhA+4u8Eg+pH5WgIrk90MfOad9zKawxd7w hsVRCUYeW0WxevtL2QDndD8Z+emJNnocEKP0RCVKJDo2Oa8r6DcKvNHJXg24OGxNkON9 DjdA== X-Gm-Message-State: ABy/qLa0vAwPZAIxxVE9E9lh3fl2wJ84KkYw8tzIlBCm4htA221T8ZFE 861d+ckiEiWJZVcF5rIRH07kKP0ckM8= X-Google-Smtp-Source: APBJJlE7jP6scVGw4KzLh4YWAQAGdUD/dSj/CnRlr3AX8JyAREE4Y9crxxZX75YAbkKMsA8gxYyBpA== X-Received: by 2002:a05:6870:588f:b0:1b3:dfb4:6431 with SMTP id be15-20020a056870588f00b001b3dfb46431mr283786oab.8.1690319280493; Tue, 25 Jul 2023 14:08:00 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id q130-20020a4a3388000000b00541fbbbcd31sm5887298ooq.5.2023.07.25.14.07.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jul 2023 14:08:00 -0700 (PDT) Message-ID: <83fe6d6f-d7ef-937c-df8c-54bac691db2a@gmail.com> Date: Tue, 25 Jul 2023 18:08:02 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: ffmpeg-devel@ffmpeg.org References: <20230725004609.17750-1-michael@niedermayer.cc> <20230725004609.17750-2-michael@niedermayer.cc> <20230725210306.GT7802@pb2> Content-Language: en-US From: James Almer In-Reply-To: <20230725210306.GT7802@pb2> Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec/cbs_h266_syntax_template: Check num_subpic_cols for 0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/25/2023 6:03 PM, Michael Niedermayer wrote: > On Mon, Jul 24, 2023 at 10:54:20PM -0300, James Almer wrote: >> On 7/24/2023 9:46 PM, Michael Niedermayer wrote: >>> Fixes: division by zero >>> Fixes: 60306/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5538913553612800 >>> >>> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/cbs_h266_syntax_template.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c >>> index dce0216fbc..18ecf17e3b 100644 >>> --- a/libavcodec/cbs_h266_syntax_template.c >>> +++ b/libavcodec/cbs_h266_syntax_template.c >>> @@ -1187,6 +1187,8 @@ static int FUNC(sps)(CodedBitstreamContext *ctx, RWContext *rw, >>> } else { >>> int num_subpic_cols = tmp_width_val / >>> (current->sps_subpic_width_minus1[0] + 1); >>> + if (!num_subpic_cols) >>> + return AVERROR_INVALIDDATA; >>> infer(sps_subpic_ctu_top_left_x[i], >>> (i % num_subpic_cols) * >>> (current->sps_subpic_width_minus1[0] + 1)); >> >> Does the following fix it too? > > yes, feel free to push this, or i can if you prefer? Just pushed it. Thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".