From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C2D8D4520C for ; Wed, 15 Mar 2023 15:00:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5B25268BE80; Wed, 15 Mar 2023 17:00:16 +0200 (EET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2118.outbound.protection.outlook.com [40.107.22.118]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A19C368A9DF for ; Wed, 15 Mar 2023 17:00:10 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OR3KCcnK78qqFxAYus5Al5LZBgmn3hjZt/eMHOe9zi/D1cHKcj5OAemr38xLD44iGeUogEsxi9PcJASeisnSYEgLK2AemBh0KJyBk3GyEgzES0x2cAu3/uSsb8VKZyUXe1nkG8cYaR5Iamg6V9OpWFG99Cm3Jag7lGf4Ta/BOVKtO46rRYxfWJx7iX0Lc+HrRK2KdFsjgyr+/q9n/PkgmVk2qNs6Hp1dUdnudUodgVKdGyHU/S2tnZC6YHnb7ld06IWMXJI1ASsdTCca16rHMZeE56hJvg8IJ398jYGZwhMjzwJBsTnebgKKJVgmwXeX14yQRuNge/FUewrZGOQE9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F29J1G8YwBAJwQOTRKQDDTzxcMZWT02nRKtciNkO6s4=; b=YqzUQTNRqZYIOC5uWXQPlRjVyoUlkKLYS2bCEnMwt97waeR4pjJZDYLB4BBBCi8y7V5sQp0WuVpHGdd/GLMzadIr0A7FBTwTPV8FigWN5wOpVzmE7sgyWuLAgFj5fcE79twBw5dXhtPQU15TzSZW7KgO1Gs1kln3+CrwuILv0vdrQ5uHZjrsGK6G+T1AQlzm0500SnfcRRwnwFCZD3Dspvb9h6kCTD5y4AviGWEbyzsE4t0BN4G72aMaY5PRgMDIQ36Bde9u+7Yww47G5pxavJ4GKMXeCeC+jBdSDKa0qqBeGJ7LCKgY3FoGXGvX+t7qBj2b6uYbkNoFmwEV9hZgJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=noa-archive.com; dmarc=pass action=none header.from=noa-archive.com; dkim=pass header.d=noa-archive.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=noa-archive.com; Received: from DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) by DBBPR09MB4794.eurprd09.prod.outlook.com (2603:10a6:10:20b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Wed, 15 Mar 2023 15:00:07 +0000 Received: from DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::19cf:147d:7271:2112]) by DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::19cf:147d:7271:2112%6]) with mapi id 15.20.6178.029; Wed, 15 Mar 2023 15:00:06 +0000 Message-ID: <83f63316-ee67-16ea-d58d-d513ead8a0d3@noa-archive.com> Date: Wed, 15 Mar 2023 16:00:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230315144525.4140-1-anton@khirnov.net> From: Tobias Rapp Organization: NOA GmbH In-Reply-To: <20230315144525.4140-1-anton@khirnov.net> X-ClientProxiedBy: FR3P281CA0156.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::17) To DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB4PR09MB5847:EE_|DBBPR09MB4794:EE_ X-MS-Office365-Filtering-Correlation-Id: d5fc5090-9bc8-48ee-7827-08db2565f6ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i6bj5F1YCBv9F/6WCm6FQ5RAS5o7jkqYoPlZgnKoh2nhGKd35cBvWlqehhk2bQh78Qr/uamrDtzGoc5zLh1pZiykeFaBRCs1rUNMvG/DT4nSkafymPoz/FUb7unkRwvzJyk8gD86tKDG6FfMQsoAXoJ9Y0tH9BgmWTClAsjViJyDhGnxvDZpANhcNvIASvlwPFx/sBiRnC0d6Bu5mtFQy6Of463moz9F+ULSAQPlxFfuhonOL0Jhs6zVSegpPTQMfZRlbgo4kcmJK7N5dGJKuMLubnm0RUAsrpewJZiJ+edY7xglXRVX/T0cHNJPpK2FmkcJq+37IR9kAwsaaGYtAeyBzxbEIqSQJFgWjO9GFHTM7OI9nllVV2+1akTCnEENDHjcWxEw7Cbmyae/fDVvtBaWL4iRfqnCGNMHjBDSE+ggfrRUcMohsbIcGzcUKS0R89cTIGo3UpqteCFPi72IJRzpcdew+D9sF1MiuiV2Lcqs/j/81GExR0lMnFO6xDmbqjU7WBkyPYe6YVZZP0qYqEHrhtJrxggKe1hzyyXhlq2Gf8eIR/Y1u4kR7PKkqvh8rjOXerOXQEkVI+dQowfJsRGOEQPWXOhXuCnGcPNOsUQfZf4YXGRtx5FG+qAc9xqpB8QFSpgXlFCXevl0Xjid+UMxy1nLQiwA71ur7lqNymIjOKVVqVqStLKxZB9Y8jOmLZZ0swSrkIT2+MlOo/VXEhsVOipeAEHwdUD52E5Qe7o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB4PR09MB5847.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(136003)(366004)(39830400003)(346002)(451199018)(2906002)(31686004)(83380400001)(6486002)(36916002)(6512007)(36756003)(26005)(6506007)(53546011)(2616005)(5660300002)(31696002)(316002)(186003)(41300700001)(86362001)(8936002)(66946007)(66476007)(6916009)(8676002)(38100700002)(66556008)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wk4vTkM2RkNYdC8xYk5UWUo5WE8wZHBaZk54bVV1S0lhTmhKS1I2anlNWjFH?= =?utf-8?B?aEJzMFVPSzlqelVqRmpicDJ6a0VvTkdPcWlTeVo2Yk9SU3JKd2RsSlZ0RURW?= =?utf-8?B?Umo2eXlDVHNGUTF1L3FlVkxZZ05hSDFZdzZEZTRvWG5JWTl2ZmNLK1FtM3FE?= =?utf-8?B?bjhvQ0M2ay9kWFgzenRDNTNoUlM4MHZEd2dFL2NuTG1tU2NTYStkYm1na3RI?= =?utf-8?B?cGEybFMzNmlHU2JOQ2lzUFlHckxuTlVEdm9hcU16WkIwZ1NEQkROVTVWMUt4?= =?utf-8?B?YWsycWx3MVNkblFJTTRsall3TDF3eWk5NGJxTVd4SWNSd0J4NTJhSW8wa1VV?= =?utf-8?B?aFdVSWZZeVdtbFBxYXN0dlBzT3lkNm54ZnQwQzI5eG04ejExUkRrb1c1bERS?= =?utf-8?B?aFMvVEJqWUlSMXdub2lLRmhWYmExdUZ2c0pFY01RcjltOE1jeFBGWXNNb1M3?= =?utf-8?B?VEJ3ME5ueDlCbzlpSmFZb2JIeTRIUExIa3E1bGxtVDUyeUtIL21NTnhZOWxI?= =?utf-8?B?TWxRVkFHWWo5ZU1EbEJ1VGNTcmpjbnBINitDL0ExLzdpc0xOT1RodnMyQWxo?= =?utf-8?B?bUNROW9IaVR5eGtPeTJDbnB6amJHOFM1VFh1c0ZZVVM3WCtmcy9mNjlaWmpk?= =?utf-8?B?OHRLY1dIVFJ5b2pmNEhjOGMxZm9SbUJBU1FkT2hlNjhzVHZCMVIzYWxUZnhl?= =?utf-8?B?ajZSaldNTGNwVWZYS2d1MnF3cys4V28xbFVQdzFNWDQ4TTZXSElXdnBRdWc4?= =?utf-8?B?VkxvMU5WY1E0a1ZXRkRNdTBRNDRuUTZMSEdJTmtBTjNnVWh3KzVkeTVSa0VX?= =?utf-8?B?Y3NTc0pZWkRacDFnNXlaK29vTFROYzVwZGovOEZyNXNpN1o2UDNJdVFkekpi?= =?utf-8?B?Y0RCQ2dYTkdsaHFQY1QrQXFkazBEbVUreTAwaTA0cTFpakRlbStPcnEySEF1?= =?utf-8?B?cEdMcWZTRUFSbVkyMXBwTmR0U0g5eWJDWk1DL0E2NEJnckU3SGVMaklweUFN?= =?utf-8?B?LzJOYTN3bEN5Mk1NUjNHWWNJaGFwWDNBUG5idTZQUG5wdzhYbWZjdzdITEJ2?= =?utf-8?B?VjhQMDg2WkpDcU5XcHAzd0lRcmVDaFlMaVN1am5SQ0xCYzF3WVNsby9NRUk4?= =?utf-8?B?cEZqSGtab2VPaEFINkRkelVid3NUNWllTGRqTFpyUXR1dzdnaWhzZXNWeGNw?= =?utf-8?B?OUlLVWlVdW1pcG0yLzdxeVFpSHNlTVhEaXN2dW51VitFdlRlZlpxYWcwaW9X?= =?utf-8?B?V2JtK09wTVNzNjEvRVViYmp5a2Joamh1ekphOVdHNGRzQnB0UjJlN3VSYzZu?= =?utf-8?B?TjY5M010akZtaWVCUEZ2czlQUUdGNXlFN21PMi9xaDFidzAzYjI1bGcxYngy?= =?utf-8?B?VTdka1laZVNrWm9nSFp6NExWTWVwa3Bmd0k4Tm9TT05ybFQ0NWY5b0wwQ1U0?= =?utf-8?B?djQyNXhUYk1SMDREOEgybmhYbytPY0psRnBHS1lJRXpnZEVEUWVyUGgwOGkx?= =?utf-8?B?U1NqOVFISWYxZEVrYzdkNkdpTHRvNmUwcENkSnZGY2FjWGJJRFBDaVNOTFJx?= =?utf-8?B?Q2JxUnpWbXRQZXliUTdCek42N2t2NzA1NmZubVQ1WGJTQmdpZEpmWUo4MGJw?= =?utf-8?B?Q1lZQ0l1TUcwSVpIRitmbFZGNVd3VU81bjhYRzRGVWljaWMzNW5kc1FIV2tr?= =?utf-8?B?WkVRQkZuVk1sWDFKV2YxaWhZZ0poY29uRngveUlLK1FxeGdSMnE1c3o4a2tq?= =?utf-8?B?V2VWVXZkaXhlbjgxMXRDOHV0d2NVN1dFWW5hWEEzREoybXFBSjFGU1dQNXhH?= =?utf-8?B?NENrZTFEakpTOXFWWG5IaFRZb3UvRHlpalI5dkF2dytFRjVVZVVveEJua3Bw?= =?utf-8?B?ZFV3WExHaDNoYTNjeEZKT3BmQVBEbFlLemhJeFVUMFBGUkpITU90UFNLUjcz?= =?utf-8?B?OWwzM0JZbVRMaXVINTdtZ3NQYjFwMnd4ek5lMzI2TkdRd3VCalhxakVQTGlR?= =?utf-8?B?NWd5WUtiY3NVa3hSVUoweU5mbzZHbWw0SGFGQ3J4bGdLVkF6c2ZuS3orc2R1?= =?utf-8?B?cXFHeUtzTWQ0ejB5TWVncjdNMXBVeUJJbysrVm82N1ltS2l5V1NXTEhFWnZK?= =?utf-8?B?dDJIaHNHb0xQTVY3ankxVHFBUlkrbnFJYm41dHdoZXphUkVJeGhXeU1NWUNW?= =?utf-8?B?TWc9PQ==?= X-OriginatorOrg: noa-archive.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5fc5090-9bc8-48ee-7827-08db2565f6ca X-MS-Exchange-CrossTenant-AuthSource: DB4PR09MB5847.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 15:00:06.8726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a676c8d7-7f39-4c99-a306-48abb76a98e9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uy0/C8ltOEqQyXcerUyQuY6rReiuKLmVtGRm3lGxMVT6ncmvV18fL3AxPHljhpqPLJLAqdM9q1RfMSDWBqYYmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR09MB4794 Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx265: flag as experimental X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 15/03/2023 15:45, Anton Khirnov wrote: > This encoder leaks and overreads, as can be seen e.g. by running an > encode under valgrind with default encoder parameters. This was known > upstream since at least 2019 (e.g. bitbucket issue #482) but never fixed > until now. > > Since upstream does not seem to practice basic code hygiene, make sure > people do not use this encoder without knowing what they are getting > into. > --- > libavcodec/libx265.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > index 420d0953af..d4511251a5 100644 > --- a/libavcodec/libx265.c > +++ b/libavcodec/libx265.c > @@ -895,7 +895,8 @@ FFCodec ff_libx265_encoder = { > .p.id = AV_CODEC_ID_HEVC, > .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | > AV_CODEC_CAP_OTHER_THREADS | > - AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, > + AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE | > + AV_CODEC_CAP_EXPERIMENTAL, > .p.priv_class = &class, > .p.wrapper_name = "libx265", > .init = libx265_encode_init, My understanding of this flag for encoders is that it indicates some possible experimental/non-standard bitstream features contained in output data, not that the implementation itself is considered sub-par. Regards, Tobias _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".