Re: [FFmpeg-devel] [PATCH 2/2] avutil: add HDR10+ dynamic metadata serialization function

[James Almer <jamrial@gmail.com>]

On 3/13/2023 7:25 PM, Andreas Rheinhardt wrote:
> James Almer:
>> On 3/9/2023 11:18 AM, Raphaël Zumer wrote:
>>> Hi,
>>>
>>> While I omitted adding v2/v3 here, I believe all comments on this set
>>> of patches have been addressed so far, unless anyone strongly
>>> disagrees with the rationale for moving dynamic HDR parsing and
>>> serialization to libavutil or with the function signature.
>>>
>>> Please let me know if I missed anything.
>>>
>>> Thanks,
>>> Raphaël Zumer
>>
>> I'll apply this (and patch 1/1) in a few days if nobody comments.
>> The code needs to be in lavu if we want muxers and demuxers to use this
>> functionality, so moving the existing lavc functions is fine unless we
>> add more avpriv_ functions that people tend to dislike.
> 
> Can we wait with this until we have the actual patches that make use of it?
> (And is lavfi actually supposed to make use of this? Or why is it moved
> to lavu at all? lavf can also use it in lavc.)

I have patches ready to make use of one of the two functions in the 
matroska demuxer. Will send them after this is pushed. And I'll attempt 
to write one to make use of the serialization function in the matroska 
muxer too.

And it makes sense for this to be in lavu even if only lavf uses these, 
given there's a public header for it already. Installing two headers for 
HDR10+ functions in two separate libraries seems overkill when they use 
the same struct.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".