Re: [FFmpeg-devel] [PATCH 4/5] lavfi/graphparser: reimplement avfilter_graph_parse* using new API

[James Almer <jamrial@gmail.com>]

On 1/20/2023 6:39 PM, Nicolas George wrote:
> Nicolas George (12023-01-20):
>> - Writing a large patch for a part of the code you know well or for a
>>    new feature is fine, of course.
> 
> In fact, even for code we know well, we should consult, as long as we
> are not the only one who knows it well: as long as other developers
> might also have plans that we would be interfering with, sharing intents
> early is the only correct thing to do towards our peers.

Nobody is disrespecting you for writing a big patch that implements or 
rewrites some API from a part of the code you consider yourself 
knowledgeable about without consulting you personally beforehand. He in 
fact sent a Request for Comment initial set precisely because he wanted 
input on the overall approach before sending a version that's ready for 
a proper review.
What's the difference between a RFC and a "I have this idea, what do you 
think of this mock up?" email? That if suggestions are made to improve 
or change said approach, then at worst what happens is that the writer 
wasted /his/ time writing 30k lines of which a fifth might need to be 
redone.
In all cases, you lost nothing, and the author at worst lost time. I 
have no idea how you come to the conclusion that you were disrespected, 
or not considered a peer.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".